* [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names for rk3288
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
@ 2019-03-20 20:14 ` Douglas Anderson
2019-03-21 21:08 ` Matthias Kaehlcke
2019-03-20 20:14 ` [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi Douglas Anderson
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Douglas Anderson @ 2019-03-20 20:14 UTC (permalink / raw)
To: Heiko Stuebner
Cc: mka, ryandcase, Douglas Anderson, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
The device tree compiler yells like this:
Warning (unit_address_vs_reg):
/gpu-opp-table/opp@100000000:
node has a unit name, but no reg property
Let's match the cpu opp node names and use a dash.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/rk3288.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index e9f454248398..79cd3c53e737 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1282,27 +1282,27 @@
gpu_opp_table: gpu-opp-table {
compatible = "operating-points-v2";
- opp@100000000 {
+ opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
opp-microvolt = <950000>;
};
- opp@200000000 {
+ opp-200000000 {
opp-hz = /bits/ 64 <200000000>;
opp-microvolt = <950000>;
};
- opp@300000000 {
+ opp-300000000 {
opp-hz = /bits/ 64 <300000000>;
opp-microvolt = <1000000>;
};
- opp@400000000 {
+ opp-400000000 {
opp-hz = /bits/ 64 <400000000>;
opp-microvolt = <1100000>;
};
- opp@500000000 {
+ opp-500000000 {
opp-hz = /bits/ 64 <500000000>;
opp-microvolt = <1200000>;
};
- opp@600000000 {
+ opp-600000000 {
opp-hz = /bits/ 64 <600000000>;
opp-microvolt = <1250000>;
};
--
2.21.0.225.g810b269d1ac-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names for rk3288
2019-03-20 20:14 ` [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names " Douglas Anderson
@ 2019-03-21 21:08 ` Matthias Kaehlcke
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Kaehlcke @ 2019-03-21 21:08 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, ryandcase, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
On Wed, Mar 20, 2019 at 01:14:00PM -0700, Douglas Anderson wrote:
> The device tree compiler yells like this:
> Warning (unit_address_vs_reg):
> /gpu-opp-table/opp@100000000:
> node has a unit name, but no reg property
>
> Let's match the cpu opp node names and use a dash.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index e9f454248398..79cd3c53e737 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1282,27 +1282,27 @@
> gpu_opp_table: gpu-opp-table {
> compatible = "operating-points-v2";
>
> - opp@100000000 {
> + opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> opp-microvolt = <950000>;
> };
> - opp@200000000 {
> + opp-200000000 {
> opp-hz = /bits/ 64 <200000000>;
> opp-microvolt = <950000>;
> };
> - opp@300000000 {
> + opp-300000000 {
> opp-hz = /bits/ 64 <300000000>;
> opp-microvolt = <1000000>;
> };
> - opp@400000000 {
> + opp-400000000 {
> opp-hz = /bits/ 64 <400000000>;
> opp-microvolt = <1100000>;
> };
> - opp@500000000 {
> + opp-500000000 {
> opp-hz = /bits/ 64 <500000000>;
> opp-microvolt = <1200000>;
> };
> - opp@600000000 {
> + opp-600000000 {
> opp-hz = /bits/ 64 <600000000>;
> opp-microvolt = <1250000>;
> };
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
2019-03-20 20:14 ` [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names " Douglas Anderson
@ 2019-03-20 20:14 ` Douglas Anderson
2019-03-21 21:12 ` Matthias Kaehlcke
2019-03-20 20:14 ` [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Douglas Anderson
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Douglas Anderson @ 2019-03-20 20:14 UTC (permalink / raw)
To: Heiko Stuebner
Cc: mka, ryandcase, Douglas Anderson, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
They are pointless. As dtc points out:
Warning (avoid_unnecessary_addr_size):
/mipi@ff960000:
unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Let's remove them.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/rk3288.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 79cd3c53e737..99a7620bddac 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1119,8 +1119,6 @@
clock-names = "ref", "pclk";
power-domains = <&power RK3288_PD_VIO>;
rockchip,grf = <&grf>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
ports {
--
2.21.0.225.g810b269d1ac-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi
2019-03-20 20:14 ` [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi Douglas Anderson
@ 2019-03-21 21:12 ` Matthias Kaehlcke
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Kaehlcke @ 2019-03-21 21:12 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, ryandcase, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
On Wed, Mar 20, 2019 at 01:14:01PM -0700, Douglas Anderson wrote:
> They are pointless. As dtc points out:
> Warning (avoid_unnecessary_addr_size):
> /mipi@ff960000:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Let's remove them.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 79cd3c53e737..99a7620bddac 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1119,8 +1119,6 @@
> clock-names = "ref", "pclk";
> power-domains = <&power RK3288_PD_VIO>;
> rockchip,grf = <&grf>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
>
> ports {
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
2019-03-20 20:14 ` [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names " Douglas Anderson
2019-03-20 20:14 ` [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi Douglas Anderson
@ 2019-03-20 20:14 ` Douglas Anderson
2019-03-21 21:14 ` Matthias Kaehlcke
2019-03-21 21:06 ` [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Matthias Kaehlcke
2019-03-25 12:35 ` Heiko Stuebner
4 siblings, 1 reply; 9+ messages in thread
From: Douglas Anderson @ 2019-03-20 20:14 UTC (permalink / raw)
To: Heiko Stuebner
Cc: mka, ryandcase, Douglas Anderson, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
They are pointless. As dtc points out:
Warning (avoid_unnecessary_addr_size):
/gpio-keys:
unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Let's remove them.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 0bc2409f6903..192dbc089ade 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -25,8 +25,6 @@
gpio_keys: gpio-keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
pinctrl-names = "default";
pinctrl-0 = <&pwr_key_l>;
--
2.21.0.225.g810b269d1ac-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys
2019-03-20 20:14 ` [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Douglas Anderson
@ 2019-03-21 21:14 ` Matthias Kaehlcke
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Kaehlcke @ 2019-03-21 21:14 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, ryandcase, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
On Wed, Mar 20, 2019 at 01:14:02PM -0700, Douglas Anderson wrote:
> They are pointless. As dtc points out:
> Warning (avoid_unnecessary_addr_size):
> /gpio-keys:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Let's remove them.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288-veyron.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 0bc2409f6903..192dbc089ade 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -25,8 +25,6 @@
>
> gpio_keys: gpio-keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> pinctrl-names = "default";
> pinctrl-0 = <&pwr_key_l>;
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
` (2 preceding siblings ...)
2019-03-20 20:14 ` [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Douglas Anderson
@ 2019-03-21 21:06 ` Matthias Kaehlcke
2019-03-25 12:35 ` Heiko Stuebner
4 siblings, 0 replies; 9+ messages in thread
From: Matthias Kaehlcke @ 2019-03-21 21:06 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, ryandcase, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
On Wed, Mar 20, 2019 at 01:13:59PM -0700, Douglas Anderson wrote:
> It can be seen that 0xffb40000 < 0xffc01000, thus efuse comes first.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 09868dcee34b..e9f454248398 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1378,19 +1378,6 @@
> reg = <0x0 0xffaf0080 0x0 0x20>;
> };
>
> - gic: interrupt-controller@ffc01000 {
> - compatible = "arm,gic-400";
> - interrupt-controller;
> - #interrupt-cells = <3>;
> - #address-cells = <0>;
> -
> - reg = <0x0 0xffc01000 0x0 0x1000>,
> - <0x0 0xffc02000 0x0 0x2000>,
> - <0x0 0xffc04000 0x0 0x2000>,
> - <0x0 0xffc06000 0x0 0x2000>;
> - interrupts = <GIC_PPI 9 0xf04>;
> - };
> -
> efuse: efuse@ffb40000 {
> compatible = "rockchip,rk3288-efuse";
> reg = <0x0 0xffb40000 0x0 0x20>;
> @@ -1404,6 +1391,19 @@
> };
> };
>
> + gic: interrupt-controller@ffc01000 {
> + compatible = "arm,gic-400";
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + #address-cells = <0>;
> +
> + reg = <0x0 0xffc01000 0x0 0x1000>,
> + <0x0 0xffc02000 0x0 0x2000>,
> + <0x0 0xffc04000 0x0 0x2000>,
> + <0x0 0xffc06000 0x0 0x2000>;
> + interrupts = <GIC_PPI 9 0xf04>;
> + };
> +
> pinctrl: pinctrl {
> compatible = "rockchip,rk3288-pinctrl";
> rockchip,grf = <&grf>;
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
` (3 preceding siblings ...)
2019-03-21 21:06 ` [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Matthias Kaehlcke
@ 2019-03-25 12:35 ` Heiko Stuebner
4 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2019-03-25 12:35 UTC (permalink / raw)
To: Douglas Anderson
Cc: mka, ryandcase, devicetree, linux-kernel, linux-rockchip,
Rob Herring, Mark Rutland, linux-arm-kernel
Am Mittwoch, 20. März 2019, 21:13:59 CET schrieb Douglas Anderson:
> It can be seen that 0xffb40000 < 0xffc01000, thus efuse comes first.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
applied patch1 for 5.2 and the other 3 as fixes for 5.1
Thanks
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread