* [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map()
@ 2022-04-22 8:52 cgel.zte
2022-04-22 10:42 ` Dmitry Baryshkov
2022-04-22 12:40 ` [PATCH] " AngeloGioacchino Del Regno
0 siblings, 2 replies; 6+ messages in thread
From: cgel.zte @ 2022-04-22 8:52 UTC (permalink / raw)
To: robdclark, sean, dmitry.baryshkov
Cc: quic_abhinavk, airlied, daniel, swboyd, quic_mkrishn,
angelogioacchino.delregno, vulab, linux-arm-msm, dri-devel,
freedreno, linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
The irq_of_parse_and_map() function returns 0 on failure, and does not
return an negative value.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
index 3b92372e7bdf..1fb1ed9e95d9 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
@@ -570,7 +570,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
}
irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
- if (irq < 0) {
+ if (!irq) {
ret = irq;
DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
goto fail;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map()
2022-04-22 8:52 [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map() cgel.zte
@ 2022-04-22 10:42 ` Dmitry Baryshkov
2022-04-22 22:40 ` Dmitry Baryshkov
2022-04-22 12:40 ` [PATCH] " AngeloGioacchino Del Regno
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-04-22 10:42 UTC (permalink / raw)
To: cgel.zte
Cc: robdclark, sean, quic_abhinavk, airlied, daniel, swboyd,
quic_mkrishn, angelogioacchino.delregno, vulab, linux-arm-msm,
dri-devel, freedreno, linux-kernel, Lv Ruyi, Zeal Robot
On Fri, 22 Apr 2022 at 11:52, <cgel.zte@gmail.com> wrote:
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> index 3b92372e7bdf..1fb1ed9e95d9 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> @@ -570,7 +570,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
> }
>
> irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> - if (irq < 0) {
> + if (!irq) {
> ret = irq;
> DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
> goto fail;
> --
> 2.25.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map()
2022-04-22 10:42 ` Dmitry Baryshkov
@ 2022-04-22 22:40 ` Dmitry Baryshkov
2022-04-24 3:19 ` [PATCH v2] " cgel.zte
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-04-22 22:40 UTC (permalink / raw)
To: cgel.zte
Cc: robdclark, sean, quic_abhinavk, airlied, daniel, swboyd,
quic_mkrishn, angelogioacchino.delregno, vulab, linux-arm-msm,
dri-devel, freedreno, linux-kernel, Lv Ruyi, Zeal Robot
On 22/04/2022 13:42, Dmitry Baryshkov wrote:
> On Fri, 22 Apr 2022 at 11:52, <cgel.zte@gmail.com> wrote:
>>
>> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>>
>> The irq_of_parse_and_map() function returns 0 on failure, and does not
>> return an negative value.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
>> ---
>> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
>> index 3b92372e7bdf..1fb1ed9e95d9 100644
>> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
>> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
>> @@ -570,7 +570,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
>> }
>>
>> irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
>> - if (irq < 0) {
>> + if (!irq) {
>> ret = irq;
As noted by Stephen, this will cause the function to prematurely return
0 (success).
>> DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
>> goto fail;
>> --
>> 2.25.1
>>
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map()
2022-04-22 22:40 ` Dmitry Baryshkov
@ 2022-04-24 3:19 ` cgel.zte
2022-04-25 22:23 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: cgel.zte @ 2022-04-24 3:19 UTC (permalink / raw)
To: dmitry.baryshkov
Cc: airlied, angelogioacchino.delregno, cgel.zte, dri-devel,
freedreno, linux-arm-msm, linux-kernel, lv.ruyi, quic_abhinavk,
quic_mkrishn, sean, swboyd, vulab, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
The irq_of_parse_and_map() function returns 0 on failure, and does not
return an negative value.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
v2: don't print irq, and return ERR_PTR(-EINVAL)
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
index 3b92372e7bdf..44e395e59df9 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
@@ -570,9 +570,9 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
}
irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
- if (irq < 0) {
- ret = irq;
- DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
+ if (!irq) {
+ ret = -EINVAL;
+ DRM_DEV_ERROR(&pdev->dev, "failed to get irq\n");
goto fail;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map()
2022-04-24 3:19 ` [PATCH v2] " cgel.zte
@ 2022-04-25 22:23 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-04-25 22:23 UTC (permalink / raw)
To: cgel.zte
Cc: airlied, angelogioacchino.delregno, dri-devel, freedreno,
linux-arm-msm, linux-kernel, lv.ruyi, quic_abhinavk,
quic_mkrishn, sean, swboyd, vulab, Zeal Robot
On 24/04/2022 06:19, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> v2: don't print irq, and return ERR_PTR(-EINVAL)
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> index 3b92372e7bdf..44e395e59df9 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> @@ -570,9 +570,9 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
> }
>
> irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> - if (irq < 0) {
> - ret = irq;
> - DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
> + if (!irq) {
> + ret = -EINVAL;
> + DRM_DEV_ERROR(&pdev->dev, "failed to get irq\n");
> goto fail;
> }
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map()
2022-04-22 8:52 [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map() cgel.zte
2022-04-22 10:42 ` Dmitry Baryshkov
@ 2022-04-22 12:40 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-04-22 12:40 UTC (permalink / raw)
To: cgel.zte, robdclark, sean, dmitry.baryshkov
Cc: quic_abhinavk, airlied, daniel, swboyd, quic_mkrishn, vulab,
linux-arm-msm, dri-devel, freedreno, linux-kernel, Lv Ruyi,
Zeal Robot
Il 22/04/22 10:52, cgel.zte@gmail.com ha scritto:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-25 22:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 8:52 [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map() cgel.zte
2022-04-22 10:42 ` Dmitry Baryshkov
2022-04-22 22:40 ` Dmitry Baryshkov
2022-04-24 3:19 ` [PATCH v2] " cgel.zte
2022-04-25 22:23 ` Dmitry Baryshkov
2022-04-22 12:40 ` [PATCH] " AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).