From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <ak@suse.de>
Cc: akpm@osdl.org, richard.brunner@amd.com,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] 2.6 workaround for Athlon/Opteron prefetch errata
Date: Thu, 11 Sep 2003 10:34:36 -0400 [thread overview]
Message-ID: <3F6087FC.7090508@pobox.com> (raw)
In-Reply-To: <20030911162634.64438c7d.ak@suse.de>
Andi Kleen wrote:
> It was not created for that (I know that because I created it ;-)
hehe
> X86_GENERIC is merely an optimization hint (currently it only changes the cache
> line size hint) It does not change anything related to correctness. Everything
> that handles correctness is checked unconditionally.
When, building non-Pentium4-related code when CONFIG_MPENTIUM4 &&
!CONFIG_X86_GENERIC, it's OK that the code is incorrect for (picking
example) AMD processors.
It would be a user bug to boot that on an AMD box, just like it would be
user bug to boot a CONFIG_M586 kernel on an ancient 386.
> is_prefetch is a correctness thing.
When we know at compile time it's not needed, it should not be enabled.
>>If I disabled CONFIG_X86_GENERIC and select CONFIG_MPENTIUM4, I darned
>>well better not get any Athlon code. The cpu setup code in particular I
>>want to conditionalize, and there are other bits that need work... but
>>for the most part it works as intended.
>
>
> Now that's becomming silly. It's alttogether only a few KB and all
> __init code anyways.
If you're doing crazy LinuxBIOS stuff where flash size is limited, it
makes a lot of sense. (and I do such crazy things) The core 2.6 kernel
has really bloated with optional features, IMO.
Jeff
next prev parent reply other threads:[~2003-09-11 14:34 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-11 0:56 Update on AMD Athlon/Opteron/Athlon64 Prefetch Errata richard.brunner
2003-09-11 1:27 ` [PATCH] 2.6 workaround for Athlon/Opteron prefetch errata Andi Kleen
2003-09-11 1:44 ` Andrew Morton
2003-09-11 1:47 ` Andi Kleen
2003-09-11 14:15 ` Jeff Garzik
2003-09-11 14:26 ` Andi Kleen
2003-09-11 14:34 ` Jeff Garzik [this message]
2003-09-11 14:58 ` Andi Kleen
2003-09-11 15:06 ` Jeff Garzik
2003-09-11 20:08 ` bill davidsen
2003-09-11 19:56 ` bill davidsen
2003-09-11 20:44 ` Alan Cox
2003-09-11 21:29 ` Mike Fedyk
2003-09-11 21:38 ` bill davidsen
2003-09-12 17:32 ` Eric W. Biederman
2003-09-12 17:56 ` Andi Kleen
2003-09-12 17:59 ` Jeff Garzik
2003-09-12 18:22 ` Adrian Bunk
2003-09-12 18:28 ` Andi Kleen
2003-09-12 18:39 ` Jeff Garzik
2003-09-12 18:45 ` Jeff Garzik
2003-09-12 18:48 ` Adrian Bunk
2003-09-12 19:07 ` Andi Kleen
2003-09-12 19:05 ` Martin Schlemmer
2003-09-12 19:30 ` Andi Kleen
2003-09-12 19:58 ` Martin Schlemmer
2003-09-12 20:00 ` Adrian Bunk
2003-09-15 0:15 ` bill davidsen
2003-09-14 23:51 ` bill davidsen
2003-09-14 23:49 ` bill davidsen
2003-09-14 23:47 ` bill davidsen
2003-09-15 1:02 ` Zwane Mwaikambo
2003-09-15 2:08 ` Nick Piggin
2003-09-15 3:55 ` Bill Davidsen
2003-09-15 7:45 ` Alan Cox
2003-09-15 12:11 ` Bill Davidsen
2003-09-15 13:48 ` Alan Cox
2003-09-15 18:50 ` Bill Davidsen
2003-09-12 18:03 ` Mike Fedyk
2003-09-11 13:54 ` Linus Torvalds
2003-09-11 14:01 ` Andi Kleen
2003-09-11 14:14 ` Dave Jones
2003-09-11 14:29 ` Andi Kleen
2003-09-11 14:14 ` Alan Cox
2003-09-11 14:24 ` Andi Kleen
2003-09-11 14:28 ` Dave Jones
2003-09-11 14:32 ` Andi Kleen
2003-09-11 20:14 ` bill davidsen
2003-09-11 16:58 ` Jamie Lokier
2003-09-11 17:05 ` Andi Kleen
2003-09-11 17:32 ` Jamie Lokier
2003-09-11 17:39 ` Andi Kleen
2003-09-11 17:48 ` Jamie Lokier
2003-09-11 18:18 ` Andi Kleen
2003-09-11 18:59 ` Jamie Lokier
2003-09-11 3:43 Nakajima, Jun
2003-09-11 4:03 ` Valdis.Kletnieks
[not found] <uqD5.3BI.3@gated-at.bofh.it>
2003-09-11 4:14 ` Andi Kleen
2003-09-11 4:58 ` dada1
2003-09-11 5:11 ` Andi Kleen
2003-09-11 5:58 ` dada1
2003-09-11 4:55 richard.brunner
2003-09-11 16:55 ` Jamie Lokier
2003-09-12 14:14 ` Martin Schlemmer
2003-09-11 17:09 richard.brunner
2003-09-11 17:14 richard.brunner
2003-09-11 17:17 richard.brunner
2003-09-13 16:54 ` Pavel Machek
2003-09-12 21:24 John Bradford
2003-09-15 6:32 John Bradford
2003-09-15 7:40 ` Alan Cox
2003-09-15 12:02 ` Bill Davidsen
2003-09-15 11:48 ` Bill Davidsen
2003-09-15 20:55 ` Adrian Bunk
2003-09-16 0:26 ` Bill Davidsen
2003-09-15 8:31 John Bradford
2003-09-15 8:32 ` Nick Piggin
2003-09-15 20:51 ` Adrian Bunk
2003-09-15 9:39 John Bradford
2003-09-15 9:58 ` Nick Piggin
2003-09-15 10:54 John Bradford
2003-09-15 10:52 ` Nick Piggin
2003-09-15 13:45 ` Alan Cox
2003-09-15 18:44 ` Bill Davidsen
2003-09-15 11:46 John Bradford
2003-09-15 12:38 ` Nick Piggin
2003-09-15 13:46 ` Chris Meadors
2003-09-15 14:00 ` Nick Piggin
2003-09-16 15:06 ` Bill Davidsen
2003-09-16 15:24 ` Nick Piggin
2003-09-15 12:28 Mikael Pettersson
2003-09-15 18:13 ` Bill Davidsen
2003-09-16 11:54 ` Jamie Lokier
2003-09-15 12:43 John Bradford
2003-09-15 18:21 ` Bill Davidsen
2003-09-15 14:21 John Bradford
2003-09-15 16:21 richard.brunner
2003-09-15 19:15 ` Bill Davidsen
2003-09-16 11:46 ` Jamie Lokier
2003-09-16 13:30 ` Dave Jones
2003-09-16 13:52 ` Bill Davidsen
2003-09-16 15:25 ` Timothy Miller
2003-09-16 16:53 ` Bill Davidsen
2003-09-16 17:22 ` Jamie Lokier
2003-09-16 17:23 ` Jamie Lokier
2003-09-18 7:43 ` Pavel Machek
2003-09-18 14:05 ` Dave Jones
2003-09-18 15:56 ` Jamie Lokier
2003-09-18 17:34 ` Bill Davidsen
[not found] <200309150632.h8F6WnHb000589@81-2-122-30.bradfords.org.uk.suse.lists.linux.kernel>
[not found] ` <1063611650.2674.1.camel@dhcp23.swansea.linux.org.uk.suse.lists.linux.kernel>
2003-09-15 18:29 ` Andi Kleen
2003-09-15 19:19 John Bradford
2003-09-15 19:34 John Bradford
2003-09-15 19:25 ` Bill Davidsen
2003-09-15 22:28 ` Alan Cox
2003-09-15 19:51 richard.brunner
2003-09-16 0:01 ` David Lang
2003-09-16 0:20 ` Bill Davidsen
2003-09-16 11:50 ` Jamie Lokier
2003-09-16 13:46 ` Bill Davidsen
2003-09-16 17:21 ` Jamie Lokier
2003-09-15 20:03 Nakajima, Jun
2003-09-15 20:20 Nakajima, Jun
2003-09-16 2:23 richard.brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F6087FC.7090508@pobox.com \
--to=jgarzik@pobox.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.brunner@amd.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).