Re: [PATCH v6 5/5] clk: meson: a1: add support for Amlogic A1 Peripheral clock driver

[Jian Hu <jian.hu@amlogic.com>]

Hi, Stephen

Thanks for your review

On 2020/1/29 13:42, Stephen Boyd wrote:
> Quoting Jian Hu (2020-01-16 00:04:40)
>> diff --git a/drivers/clk/meson/a1.c b/drivers/clk/meson/a1.c
>> new file mode 100644
>> index 000000000000..2cf20ae1db75
>> --- /dev/null
>> +++ b/drivers/clk/meson/a1.c
>> @@ -0,0 +1,2249 @@
> [...]
>> +       &a1_ceca_32k_clkout,
>> +       &a1_cecb_32k_clkin,
>> +       &a1_cecb_32k_div,
>> +       &a1_cecb_32k_sel_pre,
>> +       &a1_cecb_32k_sel,
>> +       &a1_cecb_32k_clkout,
>> +};
>> +
>> +static struct regmap_config clkc_regmap_config = {
> 
> Can this be const?
OK, I will add const in next v8 version.
> 
>> +       .reg_bits       = 32,
>> +       .val_bits       = 32,
>> +       .reg_stride     = 4,
>> +};
>> +
>> +static int meson_a1_periphs_probe(struct platform_device *pdev)
>> +{
>> +       struct device *dev = &pdev->dev;
>> +       struct resource *res;
>> +       void __iomem *base;
>> +       struct regmap *map;
>> +       int ret, i;
>> +
>> +       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +
>> +       base = devm_ioremap_resource(dev, res);
> 
> Can you use the combination function that does the get resource and
> ioremap in one function?
OK, I will use 'devm_platform_ioremap_resource' here.
> 
>> +       if (IS_ERR(base))
>> +               return PTR_ERR(base);
>> +
>> +       map = devm_regmap_init_mmio(dev, base, &clkc_regmap_config);
>> +       if (IS_ERR(map))
>> +               return PTR_ERR(map);
>> +
>> +       /* Populate regmap for the regmap backed clocks */
> 
> Seems like a useless comment.
OK, I will remove it.
> 
>> +       for (i = 0; i < ARRAY_SIZE(a1_periphs_regmaps); i++)
>> +               a1_periphs_regmaps[i]->map = map;
>> +
> 
The same with a1-pll.c file, I will modify, too.
> .
>