From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Hector Martin <marcan@marcan.st>, linux-arm-kernel@lists.infradead.org
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Sven Peter <sven@svenpeter.dev>, Marc Zyngier <maz@kernel.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs
Date: Thu, 14 Oct 2021 10:04:51 +0200 [thread overview]
Message-ID: <410c0ccb-68d3-478b-2b5b-9165890e614a@canonical.com> (raw)
In-Reply-To: <00925242-b837-d75b-3655-536d45dcd4d2@marcan.st>
On 14/10/2021 09:52, Hector Martin wrote:
> On 14/10/2021 16.36, Krzysztof Kozlowski wrote:
(...)
>
>>> Ah, I didn't realize that was a valid option for MODULE_LICENSE. I guess
>>> anything containing "GPL" works with EXPORT_SYMBOL_GPL?
>>
>> I don't think exporting symbols is related to how you license your code.
>
> It is; only modules with a GPL-compatible MODULE_LICENSE get to use
> symbols exported via EXPORT_SYMBOL_GPL.
Although there might be such correlation but it's not a rule. You can
have a GPL module exporting symbols without GPL requirement
(EXPORT_SYMBOLS). You can have a GPL+MIT module exporting symbols as
GPL. Obviously you cannot have a non-GPL module, as we do not accept
these and there is no such choice.
So answering your question that "GPL" works with EXPORT_SYMBOL_GPL -
everything is GPL but it works with both EXPORT_SYMBOL and
EXPORT_SYMBOL_GPL.
>
> See kernel/module.c for the symbol lookup logic and
> include/linux/license.h for the logic to check the string (seems like
> "Dual MIT/GPL" is explicitly whitelisted there).
Not related to export symbol. It is used for determining the tainted
kernel via other licenses.
>
> Of course, this is a futile effort, as ~every time I see a proprietary
> module in some embedded device, it either falsely declares itself to be
> GPL, or they have a shim module that re-exports GPL symbols as non-GPL.
>
This is being removed soon (or already).
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-10-14 8:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 16:56 [RFC PATCH 0/9] Apple SoC CPU P-state switching Hector Martin
2021-10-11 16:56 ` [RFC PATCH 1/9] MAINTAINERS: apple: Add apple-mcc and clk-apple-cluster paths Hector Martin
2021-10-11 16:57 ` [RFC PATCH 2/9] dt-bindings: memory-controller: Add apple,mcc binding Hector Martin
2021-10-12 8:48 ` Krzysztof Kozlowski
2021-10-19 22:43 ` Rob Herring
2021-10-11 16:57 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple,cluster-clk binding Hector Martin
2021-10-12 8:51 ` Krzysztof Kozlowski
2021-10-12 9:35 ` Viresh Kumar
[not found] ` <D0DE08FE-562E-4A48-BCA0-9094DAFCA564@marcan.st>
[not found] ` <20211012094302.3cownyzr4phxwifs@vireshk-i7>
[not found] ` <64584F8C-D49F-41B5-9658-CF8A25186E67@marcan.st>
[not found] ` <20211012095735.mhh2lzu52ohtotl6@vireshk-i7>
2021-10-12 13:48 ` Hector Martin
2021-10-11 16:57 ` [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Hector Martin
2021-10-12 3:21 ` Viresh Kumar
2021-10-12 5:34 ` Hector Martin
2021-10-12 5:51 ` Viresh Kumar
2021-10-12 5:57 ` Hector Martin
2021-10-12 9:26 ` Viresh Kumar
2021-10-12 9:31 ` Hector Martin "marcan"
2021-10-12 9:32 ` Viresh Kumar
2021-10-14 6:52 ` Hector Martin
2021-10-14 6:56 ` Viresh Kumar
2021-10-14 7:03 ` Hector Martin
2021-10-14 7:22 ` Viresh Kumar
2021-10-14 7:23 ` Hector Martin
2021-10-14 11:08 ` Ulf Hansson
2021-10-14 9:55 ` Ulf Hansson
2021-10-14 11:43 ` Hector Martin
2021-10-14 12:55 ` Ulf Hansson
2021-10-14 17:02 ` Hector Martin
2021-10-15 11:26 ` Ulf Hansson
2021-10-11 16:57 ` [RFC PATCH 5/9] PM: domains: Add of_genpd_add_provider_simple_noclk() Hector Martin
2021-10-11 16:57 ` [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs Hector Martin
2021-10-12 9:19 ` Krzysztof Kozlowski
2021-10-14 6:59 ` Hector Martin
2021-10-14 7:36 ` Krzysztof Kozlowski
2021-10-14 7:52 ` Hector Martin
2021-10-14 8:04 ` Krzysztof Kozlowski [this message]
2021-10-14 8:31 ` Hector Martin
2021-10-11 16:57 ` [RFC PATCH 7/9] clk: apple: Add clk-apple-cluster driver to manage CPU p-states Hector Martin
[not found] ` <163424925931.1688384.9647104000291025081@swboyd.mtv.corp.google.com>
2021-10-17 9:16 ` Hector Martin
2021-10-11 16:57 ` [RFC PATCH 8/9] arm64: apple: Select MEMORY and APPLE_MCC Hector Martin
2021-10-11 16:57 ` [RFC PATCH 9/9] arm64: apple: Add CPU frequency scaling support for t8103 Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410c0ccb-68d3-478b-2b5b-9165890e614a@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alyssa@rosenzweig.io \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sven@svenpeter.dev \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).