From: Johannes Berg <johannes@sipsolutions.net>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot
Date: Tue, 29 Oct 2019 10:07:30 +0100 [thread overview]
Message-ID: <4725dcbd6297c74bf949671e7ad48eeeb0ceb0d0.camel@sipsolutions.net> (raw)
In-Reply-To: <m37e4orkxr.fsf@t19.piap.pl>
On Tue, 2019-10-29 at 09:54 +0100, Krzysztof Hałasa wrote:
> The problem I can see is that the dialog_tokens are 8-bit, way too small
> to eliminate conflicts.
Well, they're also per station, we could just randomize the start and
then we'd delete the old session and start a new one, on the receiver.
So that would improve robustness somewhat (down to a 1/256 chance to hit
this problem).
> > Really what I think probably happened is that one of your stations lost
> > the connection to the other, and didn't tell it about it in any way - so
> > the other kept all the status alive.
>
> You must have missed my previous mail - I simply rebooted that station,
> and alternatively rmmoded/modprobed ath9k. But the problem originated in
> a station going out of and back in range, in fact.
I was on vacation, so yeah, quite possible I missed it.
Sounds like we need not just
4b08d1b6a994 ("mac80211: IBSS: send deauth when expiring inactive STAs")
but also send a deauth when we disconnect. Surprising we don't do that,
actually.
> > I suspect to make all this work well we need to not only have the fixes
> > I made recently to actually send and parse deauth frames, but also to
> > even send an auth and reset the state when we receive that, so if we
> > move out of range and even the deauth frame is lost, we can still reset
> > properly.
>
> That's one thing. The other is a station trying ADDBA for the first time
> after boot (while the local station has seen it before that reboot).
That's the situation though - the local station needs to know that it
has in fact *not* seen the same instance of the station, but that the
station has reset and needs to be removed & re-added.
> I guess we need to identify "new connection" reliably. Otherwise,
> the new connections are treated as old ones and it doesn't work.
Right. But we can implement the (optional) authentication (which you
actually already get when you implement [encrypted] IBSS with wpa_s),
and reset the station state when we get an authentication frame.
johannes
next prev parent reply other threads:[~2019-10-29 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 12:11 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot Krzysztof Hałasa
2019-10-21 12:18 ` [PATCH] " Krzysztof Hałasa
2019-10-22 9:42 ` Sergei Shtylyov
2019-10-21 12:18 ` Krzysztof Hałasa
2019-10-25 10:21 ` [PATCH v2] " Krzysztof Hałasa
2019-10-28 12:21 ` Johannes Berg
2019-10-29 8:41 ` Koen Vandeputte
2019-10-29 8:58 ` Sebastian Gottschall
2019-10-29 9:40 ` Koen Vandeputte
2019-10-29 9:03 ` Johannes Berg
2019-10-29 9:47 ` Koen Vandeputte
2019-10-29 8:54 ` Krzysztof Hałasa
2019-10-29 9:07 ` Johannes Berg [this message]
2019-10-29 10:51 ` Krzysztof Hałasa
2019-10-29 10:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4725dcbd6297c74bf949671e7ad48eeeb0ceb0d0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).