From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Krzysztof Hałasa" <khalasa@piap.pl>,
"Johannes Berg" <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot
Date: Tue, 22 Oct 2019 12:42:00 +0300 [thread overview]
Message-ID: <628ec530-1f68-e34b-39a5-b3d994d9376c@cogentembedded.com> (raw)
In-Reply-To: <m3v9shl6jz.fsf@t19.piap.pl>
Hello!
On 21.10.2019 15:18, Krzysztof Hałasa wrote:
> Fix a bug where the mac80211 RX aggregation code sets a new aggregation
> "session" at the remote station's request, but the head_seq_num
> (the sequence number the receiver expects to receive) isn't reset.
>
> Spotted on a pair of AR9580 in IBSS mode.
>
> Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>
>
> diff --git a/net/mac80211/agg-rx.c b/net/mac80211/agg-rx.c
> index 4d1c335e06e5..775a51cc51c9 100644
> --- a/net/mac80211/agg-rx.c
> +++ b/net/mac80211/agg-rx.c
> @@ -354,9 +354,11 @@ void ___ieee80211_start_rx_ba_session(struct sta_info *sta,
> */
> rcu_read_lock();
> tid_rx = rcu_dereference(sta->ampdu_mlme.tid_rx[tid]);
> - if (tid_rx && tid_rx->timeout == timeout)
> + if (tid_rx && tid_rx->timeout == timeout) {
> + tid_rx->ssn = start_seq_num;
> + tid_rx->head_seq_num = start_seq_num;
> status = WLAN_STATUS_SUCCESS;
> - else
> + } else
If you add {} on one branch of *if*, you also need to add {} to all other
branches, says CodingStyle...
[...]
MBR, Sergei
next prev parent reply other threads:[~2019-10-22 9:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 12:11 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot Krzysztof Hałasa
2019-10-21 12:18 ` [PATCH] " Krzysztof Hałasa
2019-10-22 9:42 ` Sergei Shtylyov [this message]
2019-10-21 12:18 ` Krzysztof Hałasa
2019-10-25 10:21 ` [PATCH v2] " Krzysztof Hałasa
2019-10-28 12:21 ` Johannes Berg
2019-10-29 8:41 ` Koen Vandeputte
2019-10-29 8:58 ` Sebastian Gottschall
2019-10-29 9:40 ` Koen Vandeputte
2019-10-29 9:03 ` Johannes Berg
2019-10-29 9:47 ` Koen Vandeputte
2019-10-29 8:54 ` Krzysztof Hałasa
2019-10-29 9:07 ` Johannes Berg
2019-10-29 10:51 ` Krzysztof Hałasa
2019-10-29 10:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628ec530-1f68-e34b-39a5-b3d994d9376c@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).