From: khalasa@piap.pl (Krzysztof Hałasa)
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot
Date: Tue, 29 Oct 2019 09:54:24 +0100 [thread overview]
Message-ID: <m37e4orkxr.fsf@t19.piap.pl> (raw)
In-Reply-To: <e5b07b4ce51f806ce79b1ae06ff3cbabbaa4873d.camel@sipsolutions.net> (Johannes Berg's message of "Mon, 28 Oct 2019 13:21:15 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> I think you just got very lucky (or unlucky) to have the same dialog
> token, because we start from 0
Right, it seems to be the case.
> - maybe we should initialize it to a
> random value to flush out such issues.
The problem I can see is that the dialog_tokens are 8-bit, way too small
to eliminate conflicts.
> Really what I think probably happened is that one of your stations lost
> the connection to the other, and didn't tell it about it in any way - so
> the other kept all the status alive.
You must have missed my previous mail - I simply rebooted that station,
and alternatively rmmoded/modprobed ath9k. But the problem originated in
a station going out of and back in range, in fact.
> I suspect to make all this work well we need to not only have the fixes
> I made recently to actually send and parse deauth frames, but also to
> even send an auth and reset the state when we receive that, so if we
> move out of range and even the deauth frame is lost, we can still reset
> properly.
That's one thing. The other is a station trying ADDBA for the first time
after boot (while the local station has seen it before that reboot).
> In any case, this is not the right approach - we need to handle the
> "lost connection" case better I suspect, but since you don't say what
> really happened I don't really know that that's what you're seeing.
I guess we need to identify "new connection" reliably. Otherwise,
the new connections are treated as old ones and it doesn't work.
Now how can it be fixed?
--
Krzysztof Halasa
ŁUKASIEWICZ Research Network
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2019-10-29 8:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 12:11 802.11n IBSS: wlan0 stops receiving packets due to aggregation after sender reboot Krzysztof Hałasa
2019-10-21 12:18 ` [PATCH] " Krzysztof Hałasa
2019-10-22 9:42 ` Sergei Shtylyov
2019-10-21 12:18 ` Krzysztof Hałasa
2019-10-25 10:21 ` [PATCH v2] " Krzysztof Hałasa
2019-10-28 12:21 ` Johannes Berg
2019-10-29 8:41 ` Koen Vandeputte
2019-10-29 8:58 ` Sebastian Gottschall
2019-10-29 9:40 ` Koen Vandeputte
2019-10-29 9:03 ` Johannes Berg
2019-10-29 9:47 ` Koen Vandeputte
2019-10-29 8:54 ` Krzysztof Hałasa [this message]
2019-10-29 9:07 ` Johannes Berg
2019-10-29 10:51 ` Krzysztof Hałasa
2019-10-29 10:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37e4orkxr.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).