From: Jiri Slaby <jslaby@suse.cz>
To: dsterba@suse.cz
Cc: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org,
akpm@linux-foundation.org, jeff@garzik.org, jkosina@suse.cz,
stephen@symmetric.co.nz, benm@symmetric.co.nz
Subject: Re: [PATCH] ipwireless_cs driver for 4G PC Card
Date: Fri, 30 Nov 2007 14:11:59 +0100 [thread overview]
Message-ID: <47500C1F.7080803@suse.cz> (raw)
In-Reply-To: <20071130125555.GA10977@ds.suse.cz>
On 11/30/2007 01:55 PM, David Sterba wrote:
> Hi,
>
> I'm submitting driver for IPWireless PC Card, used for 4G
> internet connection.
> The driver has been in -mm series as ipwireless_cs.git tree for
> some time, is actively used and there are currently no
> outstanding bugs.
Almost :).
[...]
> Rewieved-by: Jiri Slaby <jslaby@suse.cz>
[...]
> diff --git a/drivers/char/pcmcia/ipwireless_cs_hardware.c b/drivers/char/pcmcia/ipwireless_cs_hardware.c
> new file mode 100644
> index 0000000..d67ce2e
> --- /dev/null
> +++ b/drivers/char/pcmcia/ipwireless_cs_hardware.c
[...]
> +static struct ipw_rx_packet *pool_allocate(struct ipw_hardware *hw,
> + struct ipw_rx_packet *packet,
> + int minimum_free_space)
> +{
> +
> + if (!packet) {
> + unsigned long flags;
> +
> + /*
> + * If this is the first fragment, then we will need to fetch a
> + * packet to put it in.
> + */
> + spin_lock_irqsave(&hw->spinlock, flags);
> + /* If we have one in our pool, then pull it out. */
> + if (!list_empty(&hw->rx_pool)) {
> + packet = list_first_entry(&hw->rx_pool,
> + struct ipw_rx_packet, queue);
> + list_del(&packet->queue);
> + hw->rx_pool_size--;
> + spin_unlock_irqrestore(&hw->spinlock, flags);
> + } else {
> + /* Otherwise allocate a new one. */
> + static int min_capacity = 256;
> + int new_capacity;
> +
> + spin_unlock_irqrestore(&hw->spinlock, flags);
> + new_capacity =
> + minimum_free_space > min_capacity
> + ? minimum_free_space
> + : min_capacity;
> + packet = kmalloc(sizeof(struct ipw_rx_packet)
> + + new_capacity, GFP_ATOMIC);
These not-testing-alloc-retvals remain unresolved. Please post a -fix or patch
v2 if any other comments come.
> + packet->capacity = new_capacity;
...
thanks.
next prev parent reply other threads:[~2007-11-30 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 12:55 [PATCH] ipwireless_cs driver for 4G PC Card David Sterba
2007-11-30 13:03 ` Robert P. J. Day
2007-12-04 17:33 ` David Sterba
2007-12-07 0:28 ` Marcel Holtmann
2007-11-30 13:11 ` Jiri Slaby [this message]
2007-11-30 13:18 ` Jeff Garzik
2007-11-30 14:20 ` Jiri Kosina
2007-12-01 10:45 ` Marcel Holtmann
2007-12-04 17:23 ` David Sterba
2007-12-12 15:08 ` [PATCH V2] " David Sterba
2007-12-17 10:57 ` Jiri Kosina
2007-12-17 11:22 ` Andrew Morton
2007-12-17 12:58 ` Jiri Kosina
2007-12-17 20:44 ` Andrew Morton
2007-11-30 15:20 [PATCH] " Michael Robb
2007-11-30 15:40 ` Alan Cox
2007-11-30 23:49 Michael Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47500C1F.7080803@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=benm@symmetric.co.nz \
--cc=dsterba@suse.cz \
--cc=jeff@garzik.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=stephen@symmetric.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).