From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: David Sterba <dsterba@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org,
akpm@linux-foundation.org, jeff@garzik.org, jkosina@suse.cz,
jslaby@suse.cz, stephen@symmetric.co.nz, benm@symmetric.co.nz
Subject: Re: [PATCH] ipwireless_cs driver for 4G PC Card
Date: Fri, 30 Nov 2007 08:03:36 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.0.9999.0711300759200.29812@localhost.localdomain> (raw)
In-Reply-To: <20071130125555.GA10977@ds.suse.cz>
On Fri, 30 Nov 2007, David Sterba wrote:
...
> drivers/char/pcmcia/Kconfig | 8
> drivers/char/pcmcia/Makefile | 4
> drivers/char/pcmcia/ipwireless_cs_hardware.c | 1728 +++++++++++++++++++++
> drivers/char/pcmcia/ipwireless_cs_hardware.h | 63
> drivers/char/pcmcia/ipwireless_cs_main.c | 479 +++++
> drivers/char/pcmcia/ipwireless_cs_main.h | 70
> drivers/char/pcmcia/ipwireless_cs_network.c | 496 ++++++
> drivers/char/pcmcia/ipwireless_cs_network.h | 54
> drivers/char/pcmcia/ipwireless_cs_setup_protocol.h | 108 +
> drivers/char/pcmcia/ipwireless_cs_tty.c | 779 +++++++++
> drivers/char/pcmcia/ipwireless_cs_tty.h | 48
> 12 files changed, 3845 insertions(+)
might it not make more sense to put all of that into a new
subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's
more modular and it will keep that higher-level directory from
potentially getting cluttered with even more drivers. and it would
let you drop the pointless "ipwireless_cs_" prefix from all of those
files as well.
rday
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
next prev parent reply other threads:[~2007-11-30 13:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 12:55 [PATCH] ipwireless_cs driver for 4G PC Card David Sterba
2007-11-30 13:03 ` Robert P. J. Day [this message]
2007-12-04 17:33 ` David Sterba
2007-12-07 0:28 ` Marcel Holtmann
2007-11-30 13:11 ` Jiri Slaby
2007-11-30 13:18 ` Jeff Garzik
2007-11-30 14:20 ` Jiri Kosina
2007-12-01 10:45 ` Marcel Holtmann
2007-12-04 17:23 ` David Sterba
2007-12-12 15:08 ` [PATCH V2] " David Sterba
2007-12-17 10:57 ` Jiri Kosina
2007-12-17 11:22 ` Andrew Morton
2007-12-17 12:58 ` Jiri Kosina
2007-12-17 20:44 ` Andrew Morton
2007-11-30 15:20 [PATCH] " Michael Robb
2007-11-30 15:40 ` Alan Cox
2007-11-30 23:49 Michael Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0711300759200.29812@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=akpm@linux-foundation.org \
--cc=benm@symmetric.co.nz \
--cc=dsterba@suse.cz \
--cc=jeff@garzik.org \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=stephen@symmetric.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).