From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: David Sterba <dsterba@suse.cz>,
linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org
Subject: Re: [PATCH V2] ipwireless_cs driver for 4G PC Card
Date: Mon, 17 Dec 2007 03:22:22 -0800 [thread overview]
Message-ID: <20071217032222.af86c830.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712171155130.12449@jikos.suse.cz>
On Mon, 17 Dec 2007 11:57:46 +0100 (CET) Jiri Kosina <jkosina@suse.cz> wrote:
> [ CC list trimmed ]
often a bad idea...
> On Wed, 12 Dec 2007, David Sterba wrote:
>
> > Changelog:
> > * files moved to ipwireless/, ipwireless_cs_ stripped from filenames
> > * _cs stripped from driver name
> > * kmalloc checks
> > * sync irq during shutdown
> > * removed /proc code, converted to module params
> >
> > When merged, please drop ipwireless_cs.git tree from -mm and
> > include the patch instead.
> >
> > Regards,
> > David Sterba
> >
> > Rewieved-by: Jiri Slaby <jslaby@suse.cz>
> > Signed-off-by: Ben Martel <benm@symmetric.co.nz>
> > Signed-off-by: Stephen Blackheath <stephen@symmetric.co.nz>
> > Signed-off-by: David Sterba <dsterba@suse.cz>
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > ---
> > MAINTAINERS | 8
> > drivers/char/pcmcia/Kconfig | 9
> > drivers/char/pcmcia/Makefile | 2
> > drivers/char/pcmcia/ipwireless/Makefile | 10
> > drivers/char/pcmcia/ipwireless/hardware.c | 1784 ++++++++++++++++++++++++
> > drivers/char/pcmcia/ipwireless/hardware.h | 63
> > drivers/char/pcmcia/ipwireless/main.c | 496 ++++++
> > drivers/char/pcmcia/ipwireless/main.h | 70
> > drivers/char/pcmcia/ipwireless/network.c | 513 ++++++
> > drivers/char/pcmcia/ipwireless/network.h | 54
> > drivers/char/pcmcia/ipwireless/setup_protocol.h | 108 +
> > drivers/char/pcmcia/ipwireless/tty.c | 687 +++++++++
> > drivers/char/pcmcia/ipwireless/tty.h | 48
> > 13 files changed, 3852 insertions(+)
>
> Andrew, what is your position on merging this into your 2.6.25 queue
> please? David has fixed all the issues that came up during review, so it
> seems to be that it's time for the driver to be merged during the upcoming
> merge window.
>
> If you take it, I am perfectly fine with you dropping the
> ipwireless_cs git tree from -mm lineup.
>
I'd have thought that you'd merge it into git-ipwireless_cs.patch and that
you would then take care of merging it into mainline at an appropriate
time?
next prev parent reply other threads:[~2007-12-17 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 12:55 [PATCH] ipwireless_cs driver for 4G PC Card David Sterba
2007-11-30 13:03 ` Robert P. J. Day
2007-12-04 17:33 ` David Sterba
2007-12-07 0:28 ` Marcel Holtmann
2007-11-30 13:11 ` Jiri Slaby
2007-11-30 13:18 ` Jeff Garzik
2007-11-30 14:20 ` Jiri Kosina
2007-12-01 10:45 ` Marcel Holtmann
2007-12-04 17:23 ` David Sterba
2007-12-12 15:08 ` [PATCH V2] " David Sterba
2007-12-17 10:57 ` Jiri Kosina
2007-12-17 11:22 ` Andrew Morton [this message]
2007-12-17 12:58 ` Jiri Kosina
2007-12-17 20:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217032222.af86c830.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dsterba@suse.cz \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).