linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Waiman Long <waiman.long@hp.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arch@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michel Lespinasse <walken@google.com>,
	Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	George Spelvin <linux@horizon.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	aswin@hp.com, Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH v11 0/4] Introducing a queue read/write lock implementation
Date: Thu, 30 Jan 2014 10:50:41 -0500	[thread overview]
Message-ID: <52EA74D1.3040109@hp.com> (raw)
In-Reply-To: <52EA7309.7070605@hp.com>

On 01/30/2014 10:43 AM, Waiman Long wrote:
> On 01/30/2014 10:17 AM, Peter Zijlstra wrote:
>> On Thu, Jan 30, 2014 at 02:04:53PM +0100, Peter Zijlstra wrote:
>>> So I took out that ugly union and rewrote the code to be mostly
>>> atomic_*(), gcc generates acceptable code and its smaller too.
>>>
>>>      824       0       0     824     338 
>>> defconfig-build/kernel/locking/qrwlock.o
>>>      776       0       0     776     308 
>>> defconfig-build/kernel/locking/qrwlock.o
>>>
>>> I don't think I wrecked it, but I've not actually tried it yet.
>> I did wreck it.. :-)
>>
>> The below is still small and actually works.
>>
>> ---
>>   arch/x86/Kconfig                      |    1
>>   arch/x86/include/asm/spinlock.h       |    2
>>   arch/x86/include/asm/spinlock_types.h |    4
>>   b/arch/x86/include/asm/qrwlock.h      |   18 +++
>>   b/include/asm-generic/qrwlock.h       |  174 
>> ++++++++++++++++++++++++++++++++++
>>   b/include/asm-generic/qrwlock_types.h |   17 +++
>>   b/kernel/locking/qrwlock.c            |  157 
>> ++++++++++++++++++++++++++++++
>>   kernel/Kconfig.locks                  |    7 +
>>   kernel/locking/Makefile               |    1
>>   9 files changed, 381 insertions(+)
>>
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>>
>
> OK, I see what you are trying to do. I can apply the change to my 
> patch & send out v12. So I presume that you are now OK with it. Can I 
> add your sign-off line?
>
> -Longman
>
>

One more thing, I often see line like

#define queue_write_unlock queue_write_unlock

So exactly what effect does this macro have?

-Longman


  reply	other threads:[~2014-01-30 15:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24  4:28 [PATCH v11 0/4] Introducing a queue read/write lock implementation Waiman Long
2014-01-24  4:28 ` [PATCH v11 1/4] qrwlock: A " Waiman Long
2014-01-24  8:25   ` Peter Zijlstra
2014-01-25  4:39     ` Waiman Long
2014-01-24  4:28 ` [PATCH v11 2/4] qrwlock, x86: Enable x86 to use queue read/write lock Waiman Long
2014-01-24  4:28 ` [PATCH v11 3/4] qrwlock, x86: Add char and short as atomic data type in x86 Waiman Long
2014-01-24  4:28 ` [PATCH v11 4/4] qrwlock: Use the mcs_spinlock helper functions for MCS queuing Waiman Long
2014-01-24  8:26   ` Peter Zijlstra
2014-01-25  4:30     ` Waiman Long
2014-01-30 13:04 ` [PATCH v11 0/4] Introducing a queue read/write lock implementation Peter Zijlstra
2014-01-30 15:17   ` Peter Zijlstra
2014-01-30 15:43     ` Waiman Long
2014-01-30 15:50       ` Waiman Long [this message]
2014-01-30 15:53         ` Peter Zijlstra
2014-01-30 15:44     ` Peter Zijlstra
2014-01-30 17:52       ` Will Deacon
2014-01-30 18:05         ` Peter Zijlstra
2014-01-30 18:11           ` Will Deacon
2014-01-30 18:16             ` Peter Zijlstra
2014-01-31  9:26     ` Peter Zijlstra
2014-01-31 10:03       ` George Spelvin
2014-01-31 10:17         ` Peter Zijlstra
2014-01-31 11:30           ` Peter Zijlstra
2014-02-01 23:22           ` Paul E. McKenney
2014-01-31 18:59       ` Waiman Long
2014-01-31 19:47         ` Peter Zijlstra
2014-02-01 10:38           ` George Spelvin
2014-01-31 20:14         ` Peter Zijlstra
2014-01-31 21:09           ` Waiman Long
2014-02-01  1:29             ` Davidlohr Bueso
2014-02-02  9:03             ` Ingo Molnar
2014-02-03 11:38               ` Peter Zijlstra
2014-02-06  3:08               ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EA74D1.3040109@hp.com \
    --to=waiman.long@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arnd@arndb.de \
    --cc=aswin@hp.com \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=scott.norton@hp.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).