From: Varka Bhadram <varkabhadram@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file
Date: Tue, 22 Jul 2014 14:00:30 +0530 [thread overview]
Message-ID: <53CE2126.9000804@gmail.com> (raw)
In-Reply-To: <1406013463-19218-6-git-send-email-acourbot@nvidia.com>
On 07/22/2014 12:47 PM, Alexandre Courbot wrote:
(...)
> + if (WARN(test_and_set_bit(FLAG_REQUESTED, &desc->flags) == 0,
> + "autorequest GPIO-%d\n", desc_to_gpio(desc))) {
> + if (!try_module_get(chip->owner)) {
> + gpiod_err(desc, "%s: module can't be gotten\n",
> + __func__);
Should match open parenthesis '('
gpiod_err(desc, "%s: module can't be gotten\n",
__func__);
> + clear_bit(FLAG_REQUESTED, &desc->flags);
> + /* lose */
> + err = -EIO;
> + goto end;
> + }
> + desc->label = "[auto]";
> + /* caller must chip->request() w/o spinlock */
> + if (chip->request)
> + request = true;
> + }
> +
> +end:
> + spin_unlock_irqrestore(&gpio_lock, flags);
> +
> + if (request) {
> + might_sleep_if(chip->can_sleep);
> + err = chip->request(chip, gpio_chip_hwgpio(desc));
> +
> + if (err < 0) {
> + gpiod_dbg(desc, "%s: chip request fail, %d\n",
> + __func__, err);
Dto..
(...)
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-22 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 7:17 [PATCH 0/5] gpio: a few cleanup patches Alexandre Courbot
2014-07-22 7:17 ` [PATCH 1/5] gpio: remove export of private of_get_named_gpio_flags() Alexandre Courbot
2014-07-23 15:36 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 2/5] gpio: simplify gpiochip_export() Alexandre Courbot
2014-07-23 15:38 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private Alexandre Courbot
2014-07-22 20:17 ` Guenter Roeck
2014-07-23 3:10 ` Alexandre Courbot
2014-07-23 3:47 ` Guenter Roeck
2014-07-23 5:39 ` Alexandre Courbot
2014-07-23 6:21 ` Guenter Roeck
2014-07-23 14:48 ` Alexandre Courbot
2014-07-23 15:41 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 4/5] gpio: remove gpiod_lock/unlock_as_irq() Alexandre Courbot
2014-07-23 15:45 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file Alexandre Courbot
2014-07-22 8:30 ` Varka Bhadram [this message]
2014-07-23 15:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE2126.9000804@gmail.com \
--to=varkabhadram@gmail.com \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).