From: Linus Walleij <linus.walleij@linaro.org>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH 2/5] gpio: simplify gpiochip_export()
Date: Wed, 23 Jul 2014 17:38:15 +0200 [thread overview]
Message-ID: <CACRpkdZj4VSot1pABvo=UT7Qq7CZJ1HPhbJKc29nU8zhOLuKug@mail.gmail.com> (raw)
In-Reply-To: <1406013463-19218-3-git-send-email-acourbot@nvidia.com>
On Tue, Jul 22, 2014 at 9:17 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> For some reason gpiochip_export() would invalidate all the descriptors
> of a chip if exporting it to sysfs failed. This does not appear as
> necessary. Remove that part of the code.
>
> While we are at it, add a note about the non-safety of temporarily
> releasing a spinlock in the middle of the loop that protects its
> iterator, and explain why this is done.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Patch applied.
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-07-23 15:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 7:17 [PATCH 0/5] gpio: a few cleanup patches Alexandre Courbot
2014-07-22 7:17 ` [PATCH 1/5] gpio: remove export of private of_get_named_gpio_flags() Alexandre Courbot
2014-07-23 15:36 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 2/5] gpio: simplify gpiochip_export() Alexandre Courbot
2014-07-23 15:38 ` Linus Walleij [this message]
2014-07-22 7:17 ` [PATCH 3/5] gpio: make gpiochip_get_desc() gpiolib-private Alexandre Courbot
2014-07-22 20:17 ` Guenter Roeck
2014-07-23 3:10 ` Alexandre Courbot
2014-07-23 3:47 ` Guenter Roeck
2014-07-23 5:39 ` Alexandre Courbot
2014-07-23 6:21 ` Guenter Roeck
2014-07-23 14:48 ` Alexandre Courbot
2014-07-23 15:41 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 4/5] gpio: remove gpiod_lock/unlock_as_irq() Alexandre Courbot
2014-07-23 15:45 ` Linus Walleij
2014-07-22 7:17 ` [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file Alexandre Courbot
2014-07-22 8:30 ` Varka Bhadram
2014-07-23 15:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZj4VSot1pABvo=UT7Qq7CZJ1HPhbJKc29nU8zhOLuKug@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).