* [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume()
@ 2015-02-01 14:42 Chen Gang S
2015-02-02 7:54 ` Patrice Chotard
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang S @ 2015-02-01 14:42 UTC (permalink / raw)
To: srinivas.kandagatla, maxime.coquelin, patrice.chotard, mchehab
Cc: linux-arm-kernel, kernel, linux-kernel
st_rc_suspend() and st_rc_resume() depend on CONFIG_PM_SLEEP finally, so
they need CONFIG_PM_SLEEP instead of CONFIG_PM, or they will cause build
warning (with allmodconfig under xtensa):
CC [M] drivers/media/pci/smipcie/smipcie.o
drivers/media/rc/st_rc.c:338:12: warning: 'st_rc_suspend' defined but not used [-Wunused-function]
static int st_rc_suspend(struct device *dev)
^
drivers/media/rc/st_rc.c:359:12: warning: 'st_rc_resume' defined but not used [-Wunused-function]
static int st_rc_resume(struct device *dev)
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/media/rc/st_rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
index 0e758ae..fbfe958 100644
--- a/drivers/media/rc/st_rc.c
+++ b/drivers/media/rc/st_rc.c
@@ -334,7 +334,7 @@ err:
return ret;
}
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int st_rc_suspend(struct device *dev)
{
struct st_rc_device *rc_dev = dev_get_drvdata(dev);
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume()
2015-02-01 14:42 [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume() Chen Gang S
@ 2015-02-02 7:54 ` Patrice Chotard
2015-02-12 21:56 ` Chen Gang S
0 siblings, 1 reply; 3+ messages in thread
From: Patrice Chotard @ 2015-02-02 7:54 UTC (permalink / raw)
To: Chen Gang S, srinivas.kandagatla, maxime.coquelin, mchehab
Cc: linux-arm-kernel, kernel, linux-kernel
Hi Chen
On 02/01/2015 03:42 PM, Chen Gang S wrote:
> st_rc_suspend() and st_rc_resume() depend on CONFIG_PM_SLEEP finally, so
> they need CONFIG_PM_SLEEP instead of CONFIG_PM, or they will cause build
> warning (with allmodconfig under xtensa):
>
> CC [M] drivers/media/pci/smipcie/smipcie.o
> drivers/media/rc/st_rc.c:338:12: warning: 'st_rc_suspend' defined but not used [-Wunused-function]
> static int st_rc_suspend(struct device *dev)
> ^
> drivers/media/rc/st_rc.c:359:12: warning: 'st_rc_resume' defined but not used [-Wunused-function]
> static int st_rc_resume(struct device *dev)
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/media/rc/st_rc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
> index 0e758ae..fbfe958 100644
> --- a/drivers/media/rc/st_rc.c
> +++ b/drivers/media/rc/st_rc.c
> @@ -334,7 +334,7 @@ err:
> return ret;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int st_rc_suspend(struct device *dev)
> {
> struct st_rc_device *rc_dev = dev_get_drvdata(dev);
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume()
2015-02-02 7:54 ` Patrice Chotard
@ 2015-02-12 21:56 ` Chen Gang S
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang S @ 2015-02-12 21:56 UTC (permalink / raw)
To: Patrice Chotard, srinivas.kandagatla, maxime.coquelin, mchehab
Cc: linux-arm-kernel, kernel, linux-kernel
Hello Maintainers:
Please help to process this patch, when you have time.
Thanks.
On 2/2/15 15:54, Patrice Chotard wrote:
> Hi Chen
>
> On 02/01/2015 03:42 PM, Chen Gang S wrote:
>> st_rc_suspend() and st_rc_resume() depend on CONFIG_PM_SLEEP finally, so
>> they need CONFIG_PM_SLEEP instead of CONFIG_PM, or they will cause build
>> warning (with allmodconfig under xtensa):
>>
>> CC [M] drivers/media/pci/smipcie/smipcie.o
>> drivers/media/rc/st_rc.c:338:12: warning: 'st_rc_suspend' defined but not used [-Wunused-function]
>> static int st_rc_suspend(struct device *dev)
>> ^
>> drivers/media/rc/st_rc.c:359:12: warning: 'st_rc_resume' defined but not used [-Wunused-function]
>> static int st_rc_resume(struct device *dev)
>> ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/media/rc/st_rc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
>> index 0e758ae..fbfe958 100644
>> --- a/drivers/media/rc/st_rc.c
>> +++ b/drivers/media/rc/st_rc.c
>> @@ -334,7 +334,7 @@ err:
>> return ret;
>> }
>> -#ifdef CONFIG_PM
>> +#ifdef CONFIG_PM_SLEEP
>> static int st_rc_suspend(struct device *dev)
>> {
>> struct st_rc_device *rc_dev = dev_get_drvdata(dev);
>
> Acked-by: Patrice Chotard <patrice.chotard@st.com>
>
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-12 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-01 14:42 [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume() Chen Gang S
2015-02-02 7:54 ` Patrice Chotard
2015-02-12 21:56 ` Chen Gang S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).