* [PATCH] fs: btrfs: Add missing include file
@ 2015-03-13 8:58 Guenter Roeck
2015-03-13 9:01 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Guenter Roeck @ 2015-03-13 8:58 UTC (permalink / raw)
To: Chris Mason
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel,
Guenter Roeck, Christoph Hellwig
Building alpha:allmodconfig fails with
fs/btrfs/inode.c: In function 'check_direct_IO':
fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment'
due to a missing include file.
Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
fs/btrfs/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 37dc84c..5b6e5bd 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -42,6 +42,7 @@
#include <linux/btrfs.h>
#include <linux/blkdev.h>
#include <linux/posix_acl_xattr.h>
+#include <linux/uio.h>
#include "ctree.h"
#include "disk-io.h"
#include "transaction.h"
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fs: btrfs: Add missing include file
2015-03-13 8:58 [PATCH] fs: btrfs: Add missing include file Guenter Roeck
@ 2015-03-13 9:01 ` Guenter Roeck
2015-03-13 9:14 ` David Sterba
2015-03-30 3:24 ` Guenter Roeck
2 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2015-03-13 9:01 UTC (permalink / raw)
To: Chris Mason
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel, Christoph Hellwig
On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
> Building alpha:allmodconfig fails with
>
> fs/btrfs/inode.c: In function 'check_direct_IO':
> fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment'
>
> due to a missing include file.
>
> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
Forgot to mention: This is for -next.
Guenter
> fs/btrfs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 37dc84c..5b6e5bd 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -42,6 +42,7 @@
> #include <linux/btrfs.h>
> #include <linux/blkdev.h>
> #include <linux/posix_acl_xattr.h>
> +#include <linux/uio.h>
> #include "ctree.h"
> #include "disk-io.h"
> #include "transaction.h"
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs: btrfs: Add missing include file
2015-03-13 8:58 [PATCH] fs: btrfs: Add missing include file Guenter Roeck
2015-03-13 9:01 ` Guenter Roeck
@ 2015-03-13 9:14 ` David Sterba
2015-03-30 3:24 ` Guenter Roeck
2 siblings, 0 replies; 7+ messages in thread
From: David Sterba @ 2015-03-13 9:14 UTC (permalink / raw)
To: Guenter Roeck
Cc: Chris Mason, Josef Bacik, linux-btrfs, linux-kernel, Christoph Hellwig
On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
> Building alpha:allmodconfig fails with
>
> fs/btrfs/inode.c: In function 'check_direct_IO':
> fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment'
>
> due to a missing include file.
>
> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: David Sterba <dsterba@suse.cz>
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs: btrfs: Add missing include file
2015-03-13 8:58 [PATCH] fs: btrfs: Add missing include file Guenter Roeck
2015-03-13 9:01 ` Guenter Roeck
2015-03-13 9:14 ` David Sterba
@ 2015-03-30 3:24 ` Guenter Roeck
2015-04-01 19:28 ` Chris Mason
2 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2015-03-30 3:24 UTC (permalink / raw)
To: Chris Mason
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel, Christoph Hellwig
On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
> Building alpha:allmodconfig fails with
>
> fs/btrfs/inode.c: In function 'check_direct_IO':
> fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment'
>
> due to a missing include file.
>
> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
This problem still affects the following builds as of today.
alpha:allmodconfig
i386:allyesconfig
i386:allmodconfig
m68k:allmodconfig
mips:allmodconfig
xtensa:allmodconfig
and thus probabably many other allmodconfig builds which I don't try to build.
This is getting really annoying, and prevents us from finding and fixing
other build problems.
It has been more than two weeks since I submitted the patch. This suggests
that the patch got lost otr that the Powers That Be don't care. Which one
is it ?
Should I request to revert 3737c63e1fb0 instead ?
Guenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs: btrfs: Add missing include file
2015-03-30 3:24 ` Guenter Roeck
@ 2015-04-01 19:28 ` Chris Mason
2015-04-01 19:58 ` Guenter Roeck
0 siblings, 1 reply; 7+ messages in thread
From: Chris Mason @ 2015-04-01 19:28 UTC (permalink / raw)
To: Guenter Roeck
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel, Christoph Hellwig
On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net>
wrote:
> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
>> Building alpha:allmodconfig fails with
>>
>> fs/btrfs/inode.c: In function 'check_direct_IO':
>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function
>> 'iov_iter_alignment'
>>
>> due to a missing include file.
>>
>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
>> Cc: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>
> This problem still affects the following builds as of today.
>
> alpha:allmodconfig
> i386:allyesconfig
> i386:allmodconfig
> m68k:allmodconfig
> mips:allmodconfig
> xtensa:allmodconfig
>
> and thus probabably many other allmodconfig builds which I don't try
> to build.
>
> This is getting really annoying, and prevents us from finding and
> fixing
> other build problems.
>
> It has been more than two weeks since I submitted the patch. This
> suggests
> that the patch got lost otr that the Powers That Be don't care. Which
> one
> is it ?
>
> Should I request to revert 3737c63e1fb0 instead ?
I'll put the include into my branch for -next, thanks!
-chris
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs: btrfs: Add missing include file
2015-04-01 19:28 ` Chris Mason
@ 2015-04-01 19:58 ` Guenter Roeck
2015-04-01 20:03 ` Chris Mason
0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2015-04-01 19:58 UTC (permalink / raw)
To: Chris Mason
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel, Christoph Hellwig
On 04/01/2015 12:28 PM, Chris Mason wrote:
> On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
>>> Building alpha:allmodconfig fails with
>>>
>>> fs/btrfs/inode.c: In function 'check_direct_Excellent idea. Done,IO':
>>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment'
>>>
>>> due to a missing include file.
>>>
>>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
>>> Cc: Christoph Hellwig <hch@lst.de>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>> ---
>>
>> This problem still affects the following builds as of today.
>>
>> alpha:allmodconfig
>> i386:allyesconfig
>> i386:allmodconfig
>> m68k:allmodconfig
>> mips:allmodconfig
>> xtensa:allmodconfig
>>
>> and thus probabably many other allmodconfig builds which I don't try to build.
>>
>> This is getting really annoying, and prevents us from finding and fixing
>> other build problems.
>>
>> It has been more than two weeks since I submitted the patch. This suggests
>> that the patch got lost otr that the Powers That Be don't care. Which one
>> is it ?
>>
>> Should I request to revert 3737c63e1fb0 instead ?
>
> I'll put the include into my branch for -next, thanks!
>
I have not seen the problem in the latest -next build,
which presumably means that some other patch must have
fixed the problem or at least hides it now. No idea
which one, though.
Guenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs: btrfs: Add missing include file
2015-04-01 19:58 ` Guenter Roeck
@ 2015-04-01 20:03 ` Chris Mason
0 siblings, 0 replies; 7+ messages in thread
From: Chris Mason @ 2015-04-01 20:03 UTC (permalink / raw)
To: Guenter Roeck
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel, Christoph Hellwig
On Wed, Apr 1, 2015 at 3:58 PM, Guenter Roeck <linux@roeck-us.net>
wrote:
> On 04/01/2015 12:28 PM, Chris Mason wrote:
>> On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@roeck-us.net>
>> wrote:
>>> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
>>>> Building alpha:allmodconfig fails with
>>>>
>>>> fs/btrfs/inode.c: In function 'check_direct_Excellent idea.
>>>> Done,IO':
>>>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function
>>>> 'iov_iter_alignment'
>>>>
>>>> due to a missing include file.
>>>>
>>>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
>>>> Cc: Christoph Hellwig <hch@lst.de>
>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>> ---
>>>
>>> This problem still affects the following builds as of today.
>>>
>>> alpha:allmodconfig
>>> i386:allyesconfig
>>> i386:allmodconfig
>>> m68k:allmodconfig
>>> mips:allmodconfig
>>> xtensa:allmodconfig
>>>
>>> and thus probabably many other allmodconfig builds which I don't
>>> try to build.
>>>
>>> This is getting really annoying, and prevents us from finding and
>>> fixing
>>> other build problems.
>>>
>>> It has been more than two weeks since I submitted the patch. This
>>> suggests
>>> that the patch got lost otr that the Powers That Be don't care.
>>> Which one
>>> is it ?
>>>
>>> Should I request to revert 3737c63e1fb0 instead ?
>>
>> I'll put the include into my branch for -next, thanks!
>>
>
> I have not seen the problem in the latest -next build,
> which presumably means that some other patch must have
> fixed the problem or at least hides it now. No idea
> which one, though.
It's not immediately obvious what might have fixed it, so I'll keep
this patch in my -next for today at least ;)
-chris
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-04-01 20:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13 8:58 [PATCH] fs: btrfs: Add missing include file Guenter Roeck
2015-03-13 9:01 ` Guenter Roeck
2015-03-13 9:14 ` David Sterba
2015-03-30 3:24 ` Guenter Roeck
2015-04-01 19:28 ` Chris Mason
2015-04-01 19:58 ` Guenter Roeck
2015-04-01 20:03 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).