* Patch breaks suspend
@ 2015-05-02 20:27 Marian Marinov
2015-05-04 23:37 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Marian Marinov @ 2015-05-02 20:27 UTC (permalink / raw)
To: linux-kernel, linux-acpi; +Cc: rjw
Hi guys,
I have Lenovo T520 with one SSD and one SATA drive.
I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
Both drives have bios encryption enabled.
I did a bisect and found that the following patch causes the issue:
commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Sat Feb 22 00:48:31 2014 +0100
ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
Modify the SATA subsystem to add hotplug contexts to ACPI companions
of SATA devices and ports instead of registering special ACPI dock
operations using register_hotplug_dock_device().
That change will allow the entire code handling those special ACPI
dock operations to be dropped in the next commit.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
Unfortunately I do not understand this part of the code and have no idea what I can do.
Any pointers would be very appreciated.
Best regards,
Marian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Patch breaks suspend
2015-05-02 20:27 Patch breaks suspend Marian Marinov
@ 2015-05-04 23:37 ` Rafael J. Wysocki
2015-05-05 5:47 ` Aaron Lu
2015-05-05 8:38 ` Marian Marinov
0 siblings, 2 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2015-05-04 23:37 UTC (permalink / raw)
To: Marian Marinov; +Cc: linux-kernel, linux-acpi, Aaron Lu
On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
> Hi guys,
> I have Lenovo T520 with one SSD and one SATA drive.
>
> I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
> Both drives have bios encryption enabled.
>
> I did a bisect and found that the following patch causes the issue:
> commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date: Sat Feb 22 00:48:31 2014 +0100
>
> ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
>
> Modify the SATA subsystem to add hotplug contexts to ACPI companions
> of SATA devices and ports instead of registering special ACPI dock
> operations using register_hotplug_dock_device().
>
> That change will allow the entire code handling those special ACPI
> dock operations to be dropped in the next commit.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Unfortunately I do not understand this part of the code and have no idea what I can do.
> Any pointers would be very appreciated.
Well, not right from the top of my head, but this looks really suspicious to me.
Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
category), assign it to me and CC Aaron?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch breaks suspend
2015-05-04 23:37 ` Rafael J. Wysocki
@ 2015-05-05 5:47 ` Aaron Lu
2015-05-05 8:38 ` Marian Marinov
1 sibling, 0 replies; 5+ messages in thread
From: Aaron Lu @ 2015-05-05 5:47 UTC (permalink / raw)
To: Marian Marinov; +Cc: Rafael J. Wysocki, linux-kernel, linux-acpi
On Tue, May 05, 2015 at 01:37:33AM +0200, Rafael J. Wysocki wrote:
> On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
> > Hi guys,
> > I have Lenovo T520 with one SSD and one SATA drive.
> >
> > I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
Is it disappeared after resume?
> > Both drives have bios encryption enabled.
> >
> > I did a bisect and found that the following patch causes the issue:
> > commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Date: Sat Feb 22 00:48:31 2014 +0100
> >
> > ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
> >
> > Modify the SATA subsystem to add hotplug contexts to ACPI companions
> > of SATA devices and ports instead of registering special ACPI dock
> > operations using register_hotplug_dock_device().
> >
> > That change will allow the entire code handling those special ACPI
> > dock operations to be dropped in the next commit.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Reviewed-by: Aaron Lu <aaron.lu@intel.com>
> > Acked-by: Tejun Heo <tj@kernel.org>
> >
> > Unfortunately I do not understand this part of the code and have no idea what I can do.
> > Any pointers would be very appreciated.
>
> Well, not right from the top of my head, but this looks really suspicious to me.
>
> Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
> category), assign it to me and CC Aaron?
Please attach dmesg, lspci and acpidump there when filing the bug, thanks.
BTW, this commit has been in upstream since v3.15, is your last kernel
in use older than v3.15?
Thanks,
Aaron
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch breaks suspend
2015-05-04 23:37 ` Rafael J. Wysocki
2015-05-05 5:47 ` Aaron Lu
@ 2015-05-05 8:38 ` Marian Marinov
2015-05-05 12:14 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: Marian Marinov @ 2015-05-05 8:38 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-kernel, linux-acpi, Aaron Lu
On 05/05/2015 02:37 AM, Rafael J. Wysocki wrote:
> On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
>> Hi guys,
>> I have Lenovo T520 with one SSD and one SATA drive.
>>
>> I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
>> Both drives have bios encryption enabled.
>>
>> I did a bisect and found that the following patch causes the issue:
>> commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
>> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Date: Sat Feb 22 00:48:31 2014 +0100
>>
>> ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
>>
>> Modify the SATA subsystem to add hotplug contexts to ACPI companions
>> of SATA devices and ports instead of registering special ACPI dock
>> operations using register_hotplug_dock_device().
>>
>> That change will allow the entire code handling those special ACPI
>> dock operations to be dropped in the next commit.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
>> Acked-by: Tejun Heo <tj@kernel.org>
>>
>> Unfortunately I do not understand this part of the code and have no idea what I can do.
>> Any pointers would be very appreciated.
> Well, not right from the top of my head, but this looks really suspicious to me.
>
> Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
> category), assign it to me and CC Aaron?
BUG created: https://bugzilla.kernel.org/show_bug.cgi?id=97731
Added you and Aaron to the CC list.
What additional info can I provide you? Would you like any debug info from the kernel it self?
Dmesg output?
Marian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch breaks suspend
2015-05-05 8:38 ` Marian Marinov
@ 2015-05-05 12:14 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2015-05-05 12:14 UTC (permalink / raw)
To: Marian Marinov; +Cc: linux-kernel, linux-acpi, Aaron Lu
On Tuesday, May 05, 2015 11:38:50 AM Marian Marinov wrote:
> On 05/05/2015 02:37 AM, Rafael J. Wysocki wrote:
> > On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
> >> Hi guys,
> >> I have Lenovo T520 with one SSD and one SATA drive.
> >>
> >> I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
> >> Both drives have bios encryption enabled.
> >>
> >> I did a bisect and found that the following patch causes the issue:
> >> commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
> >> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >> Date: Sat Feb 22 00:48:31 2014 +0100
> >>
> >> ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
> >>
> >> Modify the SATA subsystem to add hotplug contexts to ACPI companions
> >> of SATA devices and ports instead of registering special ACPI dock
> >> operations using register_hotplug_dock_device().
> >>
> >> That change will allow the entire code handling those special ACPI
> >> dock operations to be dropped in the next commit.
> >>
> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
> >> Acked-by: Tejun Heo <tj@kernel.org>
> >>
> >> Unfortunately I do not understand this part of the code and have no idea what I can do.
> >> Any pointers would be very appreciated.
> > Well, not right from the top of my head, but this looks really suspicious to me.
> >
> > Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
> > category), assign it to me and CC Aaron?
> BUG created: https://bugzilla.kernel.org/show_bug.cgi?id=97731
>
> Added you and Aaron to the CC list.
>
> What additional info can I provide you? Would you like any debug info from the kernel it self?
> Dmesg output?
Let's track this one in the BZ from now on if that's not a problem.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-05 11:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-02 20:27 Patch breaks suspend Marian Marinov
2015-05-04 23:37 ` Rafael J. Wysocki
2015-05-05 5:47 ` Aaron Lu
2015-05-05 8:38 ` Marian Marinov
2015-05-05 12:14 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).