From: Thorsten Leemhuis <linux@leemhuis.info>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: workflows@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'
Date: Tue, 23 Nov 2021 09:53:33 +0100 [thread overview]
Message-ID: <56d7b2d8-1c35-0365-5e85-e40d242c15f5@leemhuis.info> (raw)
In-Reply-To: <20211122152426.7c2b3ab4@gandalf.local.home>
On 22.11.21 21:24, Steven Rostedt wrote:
> On Mon, 22 Nov 2021 19:50:35 +0100
> Thorsten Leemhuis <linux@leemhuis.info> wrote:
>
>>> That said, I would like a way to have versions show a link to the last
>>> version that was reviewed.
>>>
>>> v1: has no tags
>>>
>>> v2: has a Reviewed: tag to v1.
>>>
>>> v3: has a Reviewed: tag to v2
>>>
>>> [...]
>>>
>>> Then the final commit could have a "Link" or "Reviewed" tag to v3, even
>>> though there may not be any reviews to v3, but v3 has the link to v2, and
>>> v2 has the link to v1, etc.
>>
>> Is that really worth it? Isn't it sufficient if the commit links to the
>> last public review posting, as that already should link to all earlier
>> review postings. Sure, not everybody is doing this right now, but maybe
>> just educating people to do so is better than creating something new.
>
> Isn't "as that already should link to all earlier review postings" what I'm
> suggesting above? I haven't seen many people do that yet.
Yeah, you are right, sorry, my perception was wrong.
Any maybe I got your suggestion wrong, but what you suggested sounded to
me like "each patch should link to the previous submission of the
patch". I just wonder if it's way easier and sufficient if just the
cover letter links to the previous or all earlier submissions of the
series in its revision history (sorry, I didn't should have made this
more obvious in my earlier mail); for patches without a cover letter
this obligation obviously would shift to the patch.
IOW: I have something in mind like in this submission:
https://lore.kernel.org/lkml/cover.1637252610.git.sander@svanheule.net/
Only the cover letter links to the earlier version, not the individual
patches.
But I have no strong feeling here, I don't care much about this.
Ciao, Thorsten
next prev parent reply other threads:[~2021-11-23 8:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 7:33 [RFC PATCH v1 0/1] Create 'Reported:' and 'Reviewed:' tags for links in commit messages Thorsten Leemhuis
2021-11-22 7:33 ` [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' Thorsten Leemhuis
2021-11-22 16:29 ` Steven Rostedt
2021-11-22 18:50 ` Thorsten Leemhuis
2021-11-22 20:24 ` Steven Rostedt
2021-11-23 8:53 ` Thorsten Leemhuis [this message]
2021-11-23 18:52 ` Eric Wong
2021-11-24 1:37 ` Junio C Hamano
2021-11-24 6:12 ` Eric Wong
2021-11-26 12:49 ` Ævar Arnfjörð Bjarmason
2021-11-24 2:08 ` Ævar Arnfjörð Bjarmason
2021-11-26 7:29 ` Thorsten Leemhuis
2021-11-26 17:11 ` Eric Wong
2021-11-27 19:32 ` Thorsten Leemhuis
2021-11-27 19:52 ` Eric Wong
2021-11-27 20:20 ` Junio C Hamano
2021-11-29 12:03 ` Jani Nikula
2021-11-29 17:10 ` Steven Rostedt
2021-11-29 17:18 ` Junio C Hamano
2021-11-29 19:18 ` Jani Nikula
2021-11-29 17:26 ` Eric Wong
2021-11-29 19:20 ` Jani Nikula
2021-11-30 8:24 ` Geert Uytterhoeven
2021-12-08 13:41 ` Thorsten Leemhuis
2021-12-08 17:02 ` Eric Wong
2021-11-29 22:16 ` Jonathan Corbet
2021-11-30 13:10 ` Thorsten Leemhuis
2021-12-01 12:24 ` Geert Uytterhoeven
2021-11-22 15:12 ` [RFC PATCH v1 0/1] Create 'Reported:' and 'Reviewed:' tags for links in commit messages Konstantin Ryabitsev
2021-11-22 17:04 ` Steven Rostedt
2021-11-22 18:40 ` Thorsten Leemhuis
2021-11-22 18:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d7b2d8-1c35-0365-5e85-e40d242c15f5@leemhuis.info \
--to=linux@leemhuis.info \
--cc=corbet@lwn.net \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).