* [PATCH] fs: wipe off the compiler warn
@ 2016-07-29 14:46 zhongjiang
2016-07-29 23:02 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: zhongjiang @ 2016-07-29 14:46 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
when compile the kenrel code, I happens to the following warn.
fs/reiserfs/ibalance.c:1156:2: warning: ‘new_insert_key’ may be used
uninitialized in this function.
memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
^
The patch just fix it to avoid the warn.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/reiserfs/ibalance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c
index b751eea..512ce95 100644
--- a/fs/reiserfs/ibalance.c
+++ b/fs/reiserfs/ibalance.c
@@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb,
int order;
int insert_num, n, k;
struct buffer_head *S_new;
- struct item_head new_insert_key;
+ struct item_head uninitialized_var(new_insert_key);
struct buffer_head *new_insert_ptr = NULL;
struct item_head *new_insert_key_addr = insert_key;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: wipe off the compiler warn
2016-07-29 14:46 [PATCH] fs: wipe off the compiler warn zhongjiang
@ 2016-07-29 23:02 ` Andrew Morton
2016-07-30 2:38 ` zhong jiang
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2016-07-29 23:02 UTC (permalink / raw)
To: zhongjiang; +Cc: linux-mm, linux-kernel
On Fri, 29 Jul 2016 22:46:39 +0800 zhongjiang <zhongjiang@huawei.com> wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> when compile the kenrel code, I happens to the following warn.
> fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used
> uninitialized in this function.
> memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
> ^
> The patch just fix it to avoid the warn.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/reiserfs/ibalance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c
> index b751eea..512ce95 100644
> --- a/fs/reiserfs/ibalance.c
> +++ b/fs/reiserfs/ibalance.c
> @@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb,
> int order;
> int insert_num, n, k;
> struct buffer_head *S_new;
> - struct item_head new_insert_key;
> + struct item_head uninitialized_var(new_insert_key);
> struct buffer_head *new_insert_ptr = NULL;
> struct item_head *new_insert_key_addr = insert_key;
How do we know this isn't a real bug? It isn't obvious to me that this
warning is a false positive.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: wipe off the compiler warn
2016-07-29 23:02 ` Andrew Morton
@ 2016-07-30 2:38 ` zhong jiang
0 siblings, 0 replies; 4+ messages in thread
From: zhong jiang @ 2016-07-30 2:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel
On 2016/7/30 7:02, Andrew Morton wrote:
> On Fri, 29 Jul 2016 22:46:39 +0800 zhongjiang <zhongjiang@huawei.com> wrote:
>
>> From: zhong jiang <zhongjiang@huawei.com>
>>
>> when compile the kenrel code, I happens to the following warn.
>> fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used
>> uninitialized in this function.
>> memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
>> ^
>> The patch just fix it to avoid the warn.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> fs/reiserfs/ibalance.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c
>> index b751eea..512ce95 100644
>> --- a/fs/reiserfs/ibalance.c
>> +++ b/fs/reiserfs/ibalance.c
>> @@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb,
>> int order;
>> int insert_num, n, k;
>> struct buffer_head *S_new;
>> - struct item_head new_insert_key;
>> + struct item_head uninitialized_var(new_insert_key);
>> struct buffer_head *new_insert_ptr = NULL;
>> struct item_head *new_insert_key_addr = insert_key;
> How do we know this isn't a real bug? It isn't obvious to me that this
> warning is a false positive.
>
>
> .
>
yes ,it maybe a real bug, I will resend it in v2.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fs: wipe off the compiler warn
@ 2016-07-29 14:45 zhongjiang
0 siblings, 0 replies; 4+ messages in thread
From: zhongjiang @ 2016-07-29 14:45 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
when compile the kenrel code, I happens to the following warn.
fs/reiserfs/ibalance.c:1156:2: warning: ‘new_insert_key’ may be used
uninitialized in this function.
memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
^
The patch just fix it to avoid the warn.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/reiserfs/ibalance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c
index b751eea..512ce95 100644
--- a/fs/reiserfs/ibalance.c
+++ b/fs/reiserfs/ibalance.c
@@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb,
int order;
int insert_num, n, k;
struct buffer_head *S_new;
- struct item_head new_insert_key;
+ struct item_head uninitialized_var(new_insert_key);
struct buffer_head *new_insert_ptr = NULL;
struct item_head *new_insert_key_addr = insert_key;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-30 2:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-29 14:46 [PATCH] fs: wipe off the compiler warn zhongjiang
2016-07-29 23:02 ` Andrew Morton
2016-07-30 2:38 ` zhong jiang
-- strict thread matches above, loose matches on Subject: below --
2016-07-29 14:45 zhongjiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).