From: Jonas Bonn <jonas@southpole.se>
To: Stafford Horne <shorne@gmail.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] openrisc: fix PTRS_PER_PGD define
Date: Mon, 19 Sep 2016 16:27:06 +0200 [thread overview]
Message-ID: <57DFF5BA.6090400@southpole.se> (raw)
In-Reply-To: <1474036985-20981-3-git-send-email-shorne@gmail.com>
On 09/16/2016 04:43 PM, Stafford Horne wrote:
> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>
> On OpenRISC, with its 8k pages, PAGE_SHIFT is defined to be 13.
> That makes the expression (1UL << (PAGE_SHIFT-2)) evaluate
> to 2048.
> The correct value for PTRS_PER_PGD should be 256.
>
> Correcting the PTRS_PER_PGD define unveiled a bug in map_ram(),
> where PTRS_PER_PGD was used when the intent was to iterate
> over a set of page table entries.
> This patch corrects that issue as well.
>
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
Acked-by: Jonas Bonn <jonas@southpole.se>
> ---
> arch/openrisc/include/asm/pgtable.h | 2 +-
> arch/openrisc/mm/init.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/pgtable.h b/arch/openrisc/include/asm/pgtable.h
> index 69c7df0..3567aa7 100644
> --- a/arch/openrisc/include/asm/pgtable.h
> +++ b/arch/openrisc/include/asm/pgtable.h
> @@ -69,7 +69,7 @@ extern void paging_init(void);
> */
> #define PTRS_PER_PTE (1UL << (PAGE_SHIFT-2))
>
> -#define PTRS_PER_PGD (1UL << (PAGE_SHIFT-2))
> +#define PTRS_PER_PGD (1UL << (32-PGDIR_SHIFT))
>
> /* calculate how many PGD entries a user-level program can use
> * the first mappable virtual address is 0
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index 7f94652..b782ce9 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -110,7 +110,7 @@ static void __init map_ram(void)
> set_pmd(pme, __pmd(_KERNPG_TABLE + __pa(pte)));
>
> /* Fill the newly allocated page with PTE'S */
> - for (j = 0; p < e && j < PTRS_PER_PGD;
> + for (j = 0; p < e && j < PTRS_PER_PTE;
> v += PAGE_SIZE, p += PAGE_SIZE, j++, pte++) {
> if (v >= (u32) _e_kernel_ro ||
> v < (u32) _s_kernel_ro)
next prev parent reply other threads:[~2016-09-19 14:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 14:42 [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
2016-09-16 14:42 ` [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne
2016-09-16 15:57 ` kbuild test robot
2016-09-16 23:37 ` kbuild test robot
2016-09-17 0:06 ` Stafford Horne
2016-09-19 14:26 ` Jonas Bonn
2016-09-19 14:47 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 2/7] openrisc: fix PTRS_PER_PGD define Stafford Horne
2016-09-19 14:27 ` Jonas Bonn [this message]
2016-09-16 14:43 ` [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Stafford Horne
2016-09-19 14:28 ` Jonas Bonn
2016-09-19 14:50 ` Stafford Horne
2016-09-27 13:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 4/7] openrisc: Add thread-local storage (TLS) support Stafford Horne
2016-09-19 14:25 ` Jonas Bonn
2016-09-19 14:43 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain Stafford Horne
2016-09-18 15:26 ` Guenter Roeck
2016-09-19 6:02 ` Stafford Horne
2016-09-19 7:18 ` Guenter Roeck
2016-09-19 9:11 ` Stafford Horne
2016-09-19 13:17 ` Guenter Roeck
2016-09-19 14:04 ` Stafford Horne
2016-09-19 14:35 ` Jonas Bonn
2016-09-19 14:55 ` Guenter Roeck
2016-09-19 15:16 ` Stafford Horne
2016-09-19 14:39 ` Guenter Roeck
2016-09-20 10:01 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Stafford Horne
2016-09-19 14:31 ` Jonas Bonn
2016-09-19 14:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 7/7] openrisc: remove the redundant of_platform_populate Stafford Horne
2016-09-19 14:32 ` Jonas Bonn
2016-09-19 14:58 ` Stafford Horne
2016-09-19 16:14 ` Rob Herring
2016-09-16 14:51 ` [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DFF5BA.6090400@southpole.se \
--to=jonas@southpole.se \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).