From: Stafford Horne <shorne@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: Stafford Horne <shorne@gmail.com>,
kbuild-all@01.org, Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, openrisc@lists.librecores.org
Subject: Re: [PATCH 1/7] Apply transparent_union attribute to union semun
Date: Sat, 17 Sep 2016 09:06:44 +0900 (JST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609170902390.2354@lianli.shorne-pla.net> (raw)
In-Reply-To: <201609170716.mwj8lyk6%fengguang.wu@intel.com>
On Sat, 17 Sep 2016, kbuild test robot wrote:
> Hi Jonas,
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.8-rc6 next-20160916]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url: https://github.com/0day-ci/linux/commits/Stafford-Horne/openrisc-Misc-fixes-from-backlog/20160916-230114
> config: x86_64-randconfig-b0-09170504 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> cc1: warnings being treated as errors
> In file included from include/linux/sem.h:7,
> from include/linux/sched.h:35,
> from include/linux/kasan.h:4,
> from include/linux/slab.h:118,
> from include/linux/resource_ext.h:19,
> from include/linux/acpi.h:26,
> from drivers/gpu/drm/i915/i915_drv.c:30:
>>> include/uapi/linux/sem.h:51: error: union cannot be made transparent
Thanks for catching this. I missed that this would break non openrisc
architectures.
This issue is that "
All members of the union must have the same machine representation; this
is necessary for this argument passing to work properly.
"
Definitely int and * will not always be the same. Investingating what we
can do on in arch/openrisc side without breaking the build/backcompat for
others.
Any other idea's welcome.
-Stafford
> vim +51 include/uapi/linux/sem.h
>
> 45 union semun {
> 46 int val; /* value for SETVAL */
> 47 struct semid_ds __user *buf; /* buffer for IPC_STAT & IPC_SET */
> 48 unsigned short __user *array; /* array for GETALL & SETALL */
> 49 struct seminfo __user *__buf; /* buffer for IPC_INFO */
> 50 void __user *__pad;
> > 51 } __attribute__ ((transparent_union));
> 52
> 53 struct seminfo {
> 54 int semmap;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next prev parent reply other threads:[~2016-09-17 0:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 14:42 [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
2016-09-16 14:42 ` [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne
2016-09-16 15:57 ` kbuild test robot
2016-09-16 23:37 ` kbuild test robot
2016-09-17 0:06 ` Stafford Horne [this message]
2016-09-19 14:26 ` Jonas Bonn
2016-09-19 14:47 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 2/7] openrisc: fix PTRS_PER_PGD define Stafford Horne
2016-09-19 14:27 ` Jonas Bonn
2016-09-16 14:43 ` [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Stafford Horne
2016-09-19 14:28 ` Jonas Bonn
2016-09-19 14:50 ` Stafford Horne
2016-09-27 13:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 4/7] openrisc: Add thread-local storage (TLS) support Stafford Horne
2016-09-19 14:25 ` Jonas Bonn
2016-09-19 14:43 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain Stafford Horne
2016-09-18 15:26 ` Guenter Roeck
2016-09-19 6:02 ` Stafford Horne
2016-09-19 7:18 ` Guenter Roeck
2016-09-19 9:11 ` Stafford Horne
2016-09-19 13:17 ` Guenter Roeck
2016-09-19 14:04 ` Stafford Horne
2016-09-19 14:35 ` Jonas Bonn
2016-09-19 14:55 ` Guenter Roeck
2016-09-19 15:16 ` Stafford Horne
2016-09-19 14:39 ` Guenter Roeck
2016-09-20 10:01 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Stafford Horne
2016-09-19 14:31 ` Jonas Bonn
2016-09-19 14:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 7/7] openrisc: remove the redundant of_platform_populate Stafford Horne
2016-09-19 14:32 ` Jonas Bonn
2016-09-19 14:58 ` Stafford Horne
2016-09-19 16:14 ` Rob Herring
2016-09-16 14:51 ` [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609170902390.2354@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jonas@southpole.se \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=openrisc@lists.librecores.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).