From: Stafford Horne <shorne@gmail.com>
To: Jonas Bonn <jonas@southpole.se>
Cc: Stafford Horne <shorne@gmail.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Christian Svensson <blue@cmd.nu>
Subject: Re: [PATCH 4/7] openrisc: Add thread-local storage (TLS) support
Date: Mon, 19 Sep 2016 23:43:03 +0900 (JST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609192341030.2352@lianli.shorne-pla.net> (raw)
In-Reply-To: <57DFF544.3060709@southpole.se>
On Mon, 19 Sep 2016, Jonas Bonn wrote:
> On 09/16/2016 04:43 PM, Stafford Horne wrote:
>> From: Christian Svensson <blue@cmd.nu>
>>
>> Historically OpenRISC GCC has reserved r10 which we now use to hold
>> the thread pointer for thread-local storage (TLS).
> I know this was proposed by way of this patch, but we deferred accepting this
> until the OpenRISC spec could be updated accordingly. Has this been done
> now? If not, still NAK.
Hi Jonas,
Thanks for your review, I do not believe the spec has been updated. I will
look into seeing what I can do and update the patch if needed.
-Stafford
>>
>> Signed-off-by: Christian Svensson <blue@cmd.nu>
>> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>> ---
>> arch/openrisc/kernel/process.c | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/openrisc/kernel/process.c
>> b/arch/openrisc/kernel/process.c
>> index 7095dfe..277123b 100644
>> --- a/arch/openrisc/kernel/process.c
>> +++ b/arch/openrisc/kernel/process.c
>> @@ -173,6 +173,19 @@ copy_thread(unsigned long clone_flags, unsigned long
>> usp,
>>
>> if (usp)
>> userregs->sp = usp;
>> +
>> + /*
>> + * For CLONE_SETTLS set "tp" (r10) to the TLS pointer passed
>> to sys_clone.
>> + *
>> + * The kernel entry is:
>> + * int clone (long flags, void *child_stack, int
>> *parent_tid,
>> + * int *child_tid, struct void *tls)
>> + *
>> + * This makes the source r7 in the kernel registers.
>> + */
>> + if (clone_flags & CLONE_SETTLS)
>> + userregs->gpr[10] = userregs->gpr[7];
>> +
>> userregs->gpr[11] = 0; /* Result from fork() */
>>
>> kregs->gpr[20] = 0; /* Userspace thread */
>
>
>
next prev parent reply other threads:[~2016-09-19 14:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 14:42 [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
2016-09-16 14:42 ` [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne
2016-09-16 15:57 ` kbuild test robot
2016-09-16 23:37 ` kbuild test robot
2016-09-17 0:06 ` Stafford Horne
2016-09-19 14:26 ` Jonas Bonn
2016-09-19 14:47 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 2/7] openrisc: fix PTRS_PER_PGD define Stafford Horne
2016-09-19 14:27 ` Jonas Bonn
2016-09-16 14:43 ` [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Stafford Horne
2016-09-19 14:28 ` Jonas Bonn
2016-09-19 14:50 ` Stafford Horne
2016-09-27 13:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 4/7] openrisc: Add thread-local storage (TLS) support Stafford Horne
2016-09-19 14:25 ` Jonas Bonn
2016-09-19 14:43 ` Stafford Horne [this message]
2016-09-16 14:43 ` [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain Stafford Horne
2016-09-18 15:26 ` Guenter Roeck
2016-09-19 6:02 ` Stafford Horne
2016-09-19 7:18 ` Guenter Roeck
2016-09-19 9:11 ` Stafford Horne
2016-09-19 13:17 ` Guenter Roeck
2016-09-19 14:04 ` Stafford Horne
2016-09-19 14:35 ` Jonas Bonn
2016-09-19 14:55 ` Guenter Roeck
2016-09-19 15:16 ` Stafford Horne
2016-09-19 14:39 ` Guenter Roeck
2016-09-20 10:01 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Stafford Horne
2016-09-19 14:31 ` Jonas Bonn
2016-09-19 14:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 7/7] openrisc: remove the redundant of_platform_populate Stafford Horne
2016-09-19 14:32 ` Jonas Bonn
2016-09-19 14:58 ` Stafford Horne
2016-09-19 16:14 ` Rob Herring
2016-09-16 14:51 ` [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609192341030.2352@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=blue@cmd.nu \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).