From: Stafford Horne <shorne@gmail.com>
To: Jonas Bonn <jonas@southpole.se>
Cc: Stafford Horne <shorne@gmail.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate
Date: Mon, 19 Sep 2016 23:58:21 +0900 (JST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609192356190.2352@lianli.shorne-pla.net> (raw)
In-Reply-To: <57DFF6EC.2070806@southpole.se>
On Mon, 19 Sep 2016, Jonas Bonn wrote:
> On 09/16/2016 04:43 PM, Stafford Horne wrote:
>> From: Rob Herring <robh@kernel.org>
>>
>> The of_platform_populate call in the openrisc arch code is now redundant
>> as the DT core provides a default call. Openrisc has a NULL match table
>> which means only top level nodes with compatible strings will have
>> devices creates. The default version will also descend nodes in the
>> match table such as "simple-bus" which should be fine as openrisc
>> doesn't have any of these (though it is preferred that memory-mapped
>> peripherals be grouped under a bus node(s)).
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Jonas Bonn <jonas@southpole.se>
>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>
> Yes, this is fine, but trivial/generic stuff like this doesn't really need to
> go via the OpenRISC repo, anyway.
That's right, however I didnt see anyone pick it up so I included it here.
>> ---
>> arch/openrisc/kernel/setup.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
>> index b4ed8b3..d2f78cf 100644
>> --- a/arch/openrisc/kernel/setup.c
>> +++ b/arch/openrisc/kernel/setup.c
>> @@ -38,7 +38,6 @@
>> #include <linux/of.h>
>> #include <linux/memblock.h>
>> #include <linux/device.h>
>> -#include <linux/of_platform.h>
>>
>> #include <asm/sections.h>
>> #include <asm/segment.h>
>> @@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
>> early_init_devtree(fdt);
>> }
>>
>> -static int __init openrisc_device_probe(void)
>> -{
>> - of_platform_populate(NULL, NULL, NULL, NULL);
>> -
>> - return 0;
>> -}
>> -
>> -device_initcall(openrisc_device_probe);
>> -
>> static inline unsigned long extract_value_bits(unsigned long reg,
>> short bit_nr, short width)
>> {
>
>
next prev parent reply other threads:[~2016-09-19 14:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 14:42 [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
2016-09-16 14:42 ` [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne
2016-09-16 15:57 ` kbuild test robot
2016-09-16 23:37 ` kbuild test robot
2016-09-17 0:06 ` Stafford Horne
2016-09-19 14:26 ` Jonas Bonn
2016-09-19 14:47 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 2/7] openrisc: fix PTRS_PER_PGD define Stafford Horne
2016-09-19 14:27 ` Jonas Bonn
2016-09-16 14:43 ` [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Stafford Horne
2016-09-19 14:28 ` Jonas Bonn
2016-09-19 14:50 ` Stafford Horne
2016-09-27 13:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 4/7] openrisc: Add thread-local storage (TLS) support Stafford Horne
2016-09-19 14:25 ` Jonas Bonn
2016-09-19 14:43 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain Stafford Horne
2016-09-18 15:26 ` Guenter Roeck
2016-09-19 6:02 ` Stafford Horne
2016-09-19 7:18 ` Guenter Roeck
2016-09-19 9:11 ` Stafford Horne
2016-09-19 13:17 ` Guenter Roeck
2016-09-19 14:04 ` Stafford Horne
2016-09-19 14:35 ` Jonas Bonn
2016-09-19 14:55 ` Guenter Roeck
2016-09-19 15:16 ` Stafford Horne
2016-09-19 14:39 ` Guenter Roeck
2016-09-20 10:01 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Stafford Horne
2016-09-19 14:31 ` Jonas Bonn
2016-09-19 14:54 ` Stafford Horne
2016-09-16 14:43 ` [PATCH 7/7] openrisc: remove the redundant of_platform_populate Stafford Horne
2016-09-19 14:32 ` Jonas Bonn
2016-09-19 14:58 ` Stafford Horne [this message]
2016-09-19 16:14 ` Rob Herring
2016-09-16 14:51 ` [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609192356190.2352@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).