[PATCH] ide-iops: Use platform-dependent port I/O operations

[PATCH] ide-iops: Use platform-dependent port I/O operations

[Maciej W. Rozycki]

Hello,

 Given the contents of <asm-generic/ide_iops.h> and platform-specific
peculiarities (like address-dependent hardware byte lane swappers), I
believe ide-iops should use __ide_* for port I/O string operations,
similarly to __ide_mm_* that are already used for memory-mapped I/O ones.  

 Please consider.

  Maciej

Signed-off-by: Maciej W. Rozycki <macro@mips.com>

patch-mips-2.6.10-rc3-20041212-ide-iops-0
diff -up --recursive --new-file linux-mips-2.6.10-rc3-20041212.macro/drivers/ide/ide-iops.c linux-mips-2.6.10-rc3-20041212/drivers/ide/ide-iops.c
--- linux-mips-2.6.10-rc3-20041212.macro/drivers/ide/ide-iops.c	Tue Nov 16 05:56:44 2004
+++ linux-mips-2.6.10-rc3-20041212/drivers/ide/ide-iops.c	Mon Dec 13 01:33:39 2004
@@ -46,7 +46,7 @@ static u16 ide_inw (unsigned long port)
 
 static void ide_insw (unsigned long port, void *addr, u32 count)
 {
-	insw(port, addr, count);
+	__ide_insw(port, addr, count);
 }
 
 static u32 ide_inl (unsigned long port)
@@ -56,7 +56,7 @@ static u32 ide_inl (unsigned long port)
 
 static void ide_insl (unsigned long port, void *addr, u32 count)
 {
-	insl(port, addr, count);
+	__ide_insl(port, addr, count);
 }
 
 static void ide_outb (u8 val, unsigned long port)
@@ -76,7 +76,7 @@ static void ide_outw (u16 val, unsigned 
 
 static void ide_outsw (unsigned long port, void *addr, u32 count)
 {
-	outsw(port, addr, count);
+	__ide_outsw(port, addr, count);
 }
 
 static void ide_outl (u32 val, unsigned long port)
@@ -86,7 +86,7 @@ static void ide_outl (u32 val, unsigned 
 
 static void ide_outsl (unsigned long port, void *addr, u32 count)
 {
-	outsl(port, addr, count);
+	__ide_outsl(port, addr, count);
 }
 
 void default_hwif_iops (ide_hwif_t *hwif)

Re: [PATCH] ide-iops: Use platform-dependent port I/O operations

[Bartlomiej Zolnierkiewicz]

Hi,

On Mon, 13 Dec 2004 02:45:09 +0000 (GMT), Maciej W. Rozycki
<macro@linux-mips.org> wrote:
> Hello,
> 
>  Given the contents of <asm-generic/ide_iops.h> and platform-specific
> peculiarities (like address-dependent hardware byte lane swappers), I

Could you give some specific examples? Thanks.

> believe ide-iops should use __ide_* for port I/O string operations,
> similarly to __ide_mm_* that are already used for memory-mapped I/O ones.
> 
>  Please consider.

This patch looks quite OK but it breaks few archs which don't include
<asm-generic/ide_iops.h> and don't define __ide_[in,out]* macros.

Bartlomiej

Re: [PATCH] ide-iops: Use platform-dependent port I/O operations

[Maciej W. Rozycki]

Hi,

> >  Given the contents of <asm-generic/ide_iops.h> and platform-specific
> > peculiarities (like address-dependent hardware byte lane swappers), I
> 
> Could you give some specific examples? Thanks.

 Well, you could have a look at the few options at the top of
<asm-mips/io.h>, but on second thoughts, as long as port I/O string
operations either use an unswapping address space or revert any swapping
that might have been done by hardware (either for data or for addresses),
they should work as is.  Unlike with memory-mapped I/O that should be
feasible, because port I/O is specific to ISA/EISA/PCI which are always
little-endian.

 Anyway, I still think the patch should go in for consistency.

> > believe ide-iops should use __ide_* for port I/O string operations,
> > similarly to __ide_mm_* that are already used for memory-mapped I/O ones.
> > 
> >  Please consider.
> 
> This patch looks quite OK but it breaks few archs which don't include
> <asm-generic/ide_iops.h> and don't define __ide_[in,out]* macros.

 I can have a look at it -- that is as trivial as copying missing
definitions from <asm-generic/ide_iops.h>.  I'm afraid I won't even be
able to perform compilation tests, though.

  Maciej