From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Sebastian Ott <sebott@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
oberpar@linux.ibm.com, freude@linux.ibm.com,
pmorel@linux.ibm.com, pasic@linux.ibm.com, cohuck@redhat.com
Subject: Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command
Date: Tue, 5 Feb 2019 15:27:01 -0500 [thread overview]
Message-ID: <685a08b6-6cbb-04c1-0b73-f07e4c329246@linux.ibm.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1902041056190.1862@schleppi.aag-de.ibmmobiledemo.com>
On 2/4/19 5:01 AM, Sebastian Ott wrote:
> On Thu, 31 Jan 2019, Tony Krowiak wrote:
>> On 1/30/19 1:32 PM, Sebastian Ott wrote:
>>> On Wed, 30 Jan 2019, Tony Krowiak wrote:
>>>> +++ b/drivers/s390/cio/chsc.h
>>>> @@ -9,6 +9,7 @@
>>>> #include <asm/chsc.h>
>>>> #include <asm/schid.h>
>>>> #include <asm/qdio.h>
>>>> +#include <asm/ap.h>
>>>
>>> This should be moved to chsc.c
>>
>> I can do that, but I'm curious why.
>
> You only need to include ap.h because of the ap_bus_cfg_chg definition and
> you only use that in chsc.c . Other users of chsc.h don't call that
> function.
>
> Regards,
> Sebastian
Thanks Sebastian, I've made the change and it will be in v2 when I post
it.
>
next prev parent reply other threads:[~2019-02-05 20:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 17:48 [PATCH] zcrypt: handle AP Info notification from CHSC SEI command Tony Krowiak
2019-01-30 18:32 ` Sebastian Ott
2019-01-31 23:28 ` Tony Krowiak
2019-02-01 9:01 ` Heiko Carstens
2019-02-01 11:08 ` Martin Schwidefsky
2019-02-01 13:05 ` Heiko Carstens
2019-02-01 15:40 ` Tony Krowiak
2019-02-01 15:38 ` Tony Krowiak
2019-02-04 10:06 ` Harald Freudenberger
2019-02-05 20:26 ` Tony Krowiak
2019-02-04 10:01 ` Sebastian Ott
2019-02-05 20:27 ` Tony Krowiak [this message]
2019-02-21 10:42 ` Harald Freudenberger
2019-02-21 12:12 ` Cornelia Huck
2019-02-21 12:55 ` Heiko Carstens
2019-01-31 9:09 ` Pierre Morel
2019-01-31 23:32 ` Tony Krowiak
2019-01-31 9:23 ` Pierre Morel
2019-01-31 9:55 ` Cornelia Huck
2019-01-31 23:50 ` Tony Krowiak
2019-02-01 14:35 ` Cornelia Huck
2019-02-01 15:50 ` Tony Krowiak
2019-02-04 10:15 ` Harald Freudenberger
2019-02-04 12:07 ` Cornelia Huck
2019-02-05 20:30 ` Tony Krowiak
2019-02-03 9:25 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=685a08b6-6cbb-04c1-0b73-f07e4c329246@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).