From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
sebott@linux.ibm.com, oberpar@linux.ibm.com,
freude@linux.ibm.com, pmorel@linux.ibm.com, pasic@linux.ibm.com
Subject: Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command
Date: Fri, 1 Feb 2019 10:50:13 -0500 [thread overview]
Message-ID: <f89b4a46-3d95-6481-5cd3-1db52794153e@linux.ibm.com> (raw)
In-Reply-To: <20190201153522.4f72cf00.cohuck@redhat.com>
On 2/1/19 9:35 AM, Cornelia Huck wrote:
> On Thu, 31 Jan 2019 18:50:57 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>> On 1/31/19 4:55 AM, Cornelia Huck wrote:
>>> On Wed, 30 Jan 2019 12:48:46 -0500
>>> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>>> Two questions:
>>> - Does the event cover _any_ change to the AP configuration, or can the
>>> periodic scan detect changes that are not signaled?
>>
>> It can detect any change, such as a change to the CRYCB masks.
>
> Nice. I suppose we can not rely on those messages being generated,
> though, and therefore need to keep the periodic scan...
I don't know how the CRYCB can be changed dynamically on the host, but
hot plug for a guest changes it dynamically. Down the road, we may
send a CHSC SEI AP Configuration event to let the guest know. I don't
know if there may be other AP config changes that can occur without this
event being posted, so it is probably a good idea to keep the scan. It
certainly doesn't hurt anything to do so.
>
>>
>>> - Do we want to generate such an event in QEMU on plugging/unplugging
>>> the vfio-ap device?
>>
>> We've discussed this quite a bit internally and decided not to implement
>> that at this time. We will address it as a future enhancement.
>
> Ok, but I think it would be nice to have.
Duly noted, but that discussion is outside of scope for this patch.
>
>>>> diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c
>>>> index a0baee25134c..dccccc337078 100644
>>>> --- a/drivers/s390/cio/chsc.c
>>>> +++ b/drivers/s390/cio/chsc.c
>>>> @@ -586,6 +586,15 @@ static void chsc_process_sei_scm_avail(struct chsc_sei_nt0_area *sei_area)
>>>> " failed (rc=%d).\n", ret);
>>>> }
>>>>
>>>> +static void chsc_process_sei_ap_cfg_chg(struct chsc_sei_nt0_area *sei_area)
>>>> +{
>>>> + CIO_CRW_EVENT(3, "chsc: ap config changed\n");
>>>> + if (sei_area->rs != 5)
>>>> + return;
>>>
>>> I'm guessing that a reporting source of 5 means ap, right? (The code is
>>> silent on all those magic rs values :/)
>>
>> The 5 indicates the accessibility of one or more adjunct processors has
>> changed. The reason this gets called is because the CC sent with the
>> instruction indicates the AP configuration has changed, so the reporting
>> belongs where it is. There is only one RS associated with it.
>
> So if we'd ever get there anything but rs == 5, it would be a hardware
> or hypervisor bug? Then the code makes sense, I guess.
I have no idea if that is possible, but this follows the architecture.
>
>>
>>>
>>> If so, should the debug logging be moved after the check?
>>
>> covered in the response above.
>>
>>>
>>>> +
>>>> + ap_bus_cfg_chg();
>>>> +}
>>>> +
>
next prev parent reply other threads:[~2019-02-01 15:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 17:48 [PATCH] zcrypt: handle AP Info notification from CHSC SEI command Tony Krowiak
2019-01-30 18:32 ` Sebastian Ott
2019-01-31 23:28 ` Tony Krowiak
2019-02-01 9:01 ` Heiko Carstens
2019-02-01 11:08 ` Martin Schwidefsky
2019-02-01 13:05 ` Heiko Carstens
2019-02-01 15:40 ` Tony Krowiak
2019-02-01 15:38 ` Tony Krowiak
2019-02-04 10:06 ` Harald Freudenberger
2019-02-05 20:26 ` Tony Krowiak
2019-02-04 10:01 ` Sebastian Ott
2019-02-05 20:27 ` Tony Krowiak
2019-02-21 10:42 ` Harald Freudenberger
2019-02-21 12:12 ` Cornelia Huck
2019-02-21 12:55 ` Heiko Carstens
2019-01-31 9:09 ` Pierre Morel
2019-01-31 23:32 ` Tony Krowiak
2019-01-31 9:23 ` Pierre Morel
2019-01-31 9:55 ` Cornelia Huck
2019-01-31 23:50 ` Tony Krowiak
2019-02-01 14:35 ` Cornelia Huck
2019-02-01 15:50 ` Tony Krowiak [this message]
2019-02-04 10:15 ` Harald Freudenberger
2019-02-04 12:07 ` Cornelia Huck
2019-02-05 20:30 ` Tony Krowiak
2019-02-03 9:25 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89b4a46-3d95-6481-5cd3-1db52794153e@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).