From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE()
Date: Fri, 18 Sep 2020 08:27:30 -0600 [thread overview]
Message-ID: <6f7b6be3-f52d-b082-6065-c75e3d89d252@codeaurora.org> (raw)
In-Reply-To: <1600381176-37604-2-git-send-email-bbhatt@codeaurora.org>
On 9/17/2020 4:19 PM, Bhaumik Bhatt wrote:
> When building MHI as a module, missing MODULE_LICENSE() warnings
> are seen. Avoid them by adding the license and description
> information for the files where the warnings are seen.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
> drivers/bus/mhi/core/boot.c | 3 +++
> drivers/bus/mhi/core/main.c | 3 +++
> drivers/bus/mhi/core/pm.c | 3 +++
> 3 files changed, 9 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
> index 24422f5..78140cc 100644
> --- a/drivers/bus/mhi/core/boot.c
> +++ b/drivers/bus/mhi/core/boot.c
> @@ -523,3 +523,6 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl)
> error_alloc_fw_table:
> release_firmware(firmware);
> }
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("MHI Host Interface");
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index 2cff5dd..172026f 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1533,3 +1533,6 @@ int mhi_poll(struct mhi_device *mhi_dev, u32 budget)
> return ret;
> }
> EXPORT_SYMBOL_GPL(mhi_poll);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("MHI Host Interface");
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index ce4d969..72c3dbc 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -1150,3 +1150,6 @@ void mhi_device_put(struct mhi_device *mhi_dev)
> read_unlock_bh(&mhi_cntrl->pm_lock);
> }
> EXPORT_SYMBOL_GPL(mhi_device_put);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("MHI Host Interface");
>
I would expect you only need to add the MODULE_* once per module, in
which case main.c is probably the only place that needs it.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-09-18 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 22:19 [PATCH v1 0/3] Debugfs and Sysfs entries for MHI Bhaumik Bhatt
2020-09-17 22:19 ` [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE() Bhaumik Bhatt
2020-09-18 14:27 ` Jeffrey Hugo [this message]
2020-09-18 16:49 ` bbhatt
2020-09-18 17:18 ` Manivannan Sadhasivam
2020-09-18 18:48 ` bbhatt
2020-09-21 14:07 ` Manivannan Sadhasivam
2020-09-17 22:19 ` [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI Bhaumik Bhatt
2020-09-17 23:36 ` Randy Dunlap
2020-09-18 17:08 ` bbhatt
2020-09-17 22:19 ` [PATCH v1 3/3] bus: mhi: core: Introduce sysfs " Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f7b6be3-f52d-b082-6065-c75e3d89d252@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).