From: bbhatt@codeaurora.org
To: Randy Dunlap <rdunlap@infradead.org>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
hemantk@codeaurora.org, jhugo@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI
Date: Fri, 18 Sep 2020 10:08:43 -0700 [thread overview]
Message-ID: <59df7b450303542c498ff845ea171be4@codeaurora.org> (raw)
In-Reply-To: <bf24b8fe-8ff3-4ff3-a1f0-c276dcc5832c@infradead.org>
On 2020-09-17 16:36, Randy Dunlap wrote:
> On 9/17/20 3:19 PM, Bhaumik Bhatt wrote:
>> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
>> index a8bd9bd..ae68347 100644
>> --- a/drivers/bus/mhi/Kconfig
>> +++ b/drivers/bus/mhi/Kconfig
>> @@ -12,3 +12,11 @@ config MHI_BUS
>> communication protocol used by the host processors to control
>> and communicate with modem devices over a high speed peripheral
>> bus or shared memory.
>> +
>> +config MHI_BUS_DEBUG
>> + bool "Debugfs support for the MHI bus"
>> + depends on MHI_BUS && DEBUG_FS
>> + help
>> + Enable debugfs support for use with the MHI transport. Allows
>> + reading and/or modifying some values within the MHI controller
>> + for debug and test purposes.
>
> from Documentation/process/coding-style.rst:
>
> """For all of the Kconfig* configuration files throughout the source
> tree,
> the indentation is somewhat different. Lines under a ``config``
> definition
> are indented with one tab, while help text is indented an additional
> two
> spaces."""
>
> Several lines above use spaces instead of one tab...
Thank you for pointing out. I will fix this.
next prev parent reply other threads:[~2020-09-18 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 22:19 [PATCH v1 0/3] Debugfs and Sysfs entries for MHI Bhaumik Bhatt
2020-09-17 22:19 ` [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE() Bhaumik Bhatt
2020-09-18 14:27 ` Jeffrey Hugo
2020-09-18 16:49 ` bbhatt
2020-09-18 17:18 ` Manivannan Sadhasivam
2020-09-18 18:48 ` bbhatt
2020-09-21 14:07 ` Manivannan Sadhasivam
2020-09-17 22:19 ` [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI Bhaumik Bhatt
2020-09-17 23:36 ` Randy Dunlap
2020-09-18 17:08 ` bbhatt [this message]
2020-09-17 22:19 ` [PATCH v1 3/3] bus: mhi: core: Introduce sysfs " Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59df7b450303542c498ff845ea171be4@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).