From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI
Date: Thu, 17 Sep 2020 16:36:47 -0700 [thread overview]
Message-ID: <bf24b8fe-8ff3-4ff3-a1f0-c276dcc5832c@infradead.org> (raw)
In-Reply-To: <1600381176-37604-3-git-send-email-bbhatt@codeaurora.org>
On 9/17/20 3:19 PM, Bhaumik Bhatt wrote:
> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
> index a8bd9bd..ae68347 100644
> --- a/drivers/bus/mhi/Kconfig
> +++ b/drivers/bus/mhi/Kconfig
> @@ -12,3 +12,11 @@ config MHI_BUS
> communication protocol used by the host processors to control
> and communicate with modem devices over a high speed peripheral
> bus or shared memory.
> +
> +config MHI_BUS_DEBUG
> + bool "Debugfs support for the MHI bus"
> + depends on MHI_BUS && DEBUG_FS
> + help
> + Enable debugfs support for use with the MHI transport. Allows
> + reading and/or modifying some values within the MHI controller
> + for debug and test purposes.
from Documentation/process/coding-style.rst:
"""For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different. Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces."""
Several lines above use spaces instead of one tab...
--
~Randy
next prev parent reply other threads:[~2020-09-17 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 22:19 [PATCH v1 0/3] Debugfs and Sysfs entries for MHI Bhaumik Bhatt
2020-09-17 22:19 ` [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE() Bhaumik Bhatt
2020-09-18 14:27 ` Jeffrey Hugo
2020-09-18 16:49 ` bbhatt
2020-09-18 17:18 ` Manivannan Sadhasivam
2020-09-18 18:48 ` bbhatt
2020-09-21 14:07 ` Manivannan Sadhasivam
2020-09-17 22:19 ` [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI Bhaumik Bhatt
2020-09-17 23:36 ` Randy Dunlap [this message]
2020-09-18 17:08 ` bbhatt
2020-09-17 22:19 ` [PATCH v1 3/3] bus: mhi: core: Introduce sysfs " Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf24b8fe-8ff3-4ff3-a1f0-c276dcc5832c@infradead.org \
--to=rdunlap@infradead.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).