* [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
2021-06-08 5:14 [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Aswath Govindraju
@ 2021-06-08 5:14 ` Aswath Govindraju
2021-06-08 5:20 ` Jan Kiszka
2021-06-09 13:48 ` Vignesh Raghavendra
2021-06-08 5:14 ` [PATCH v2 2/2] arm64: dts: ti: k3-am642-evm: " Aswath Govindraju
2021-06-11 19:00 ` [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Nishanth Menon
2 siblings, 2 replies; 8+ messages in thread
From: Aswath Govindraju @ 2021-06-08 5:14 UTC (permalink / raw)
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Aswath Govindraju, Nishanth Menon, Tero Kristo, Rob Herring,
Jan Kiszka, linux-arm-kernel, devicetree, linux-kernel
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index f4ec9ed52939..23d51b6a9cf2 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -575,7 +575,7 @@
#address-cells = <1>;
#size-cells= <0>;
- ti,pindir-d0-out-d1-in = <1>;
+ ti,pindir-d0-out-d1-in;
};
&tscadc0 {
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index eddb2ffb93ca..1b947e2c2e74 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -299,7 +299,7 @@
pinctrl-0 = <&main_spi0_pins_default>;
#address-cells = <1>;
#size-cells= <0>;
- ti,pindir-d0-out-d1-in = <1>;
+ ti,pindir-d0-out-d1-in;
flash@0{
compatible = "jedec,spi-nor";
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
2021-06-08 5:14 ` [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema Aswath Govindraju
@ 2021-06-08 5:20 ` Jan Kiszka
2021-06-08 5:24 ` Aswath Govindraju
2021-06-09 13:48 ` Vignesh Raghavendra
1 sibling, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2021-06-08 5:20 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Nishanth Menon, Tero Kristo, Rob Herring, linux-arm-kernel,
devicetree, linux-kernel
On 08.06.21 07:14, Aswath Govindraju wrote:
> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> Therefore, fix the property accordingly.
>
Is there a patch for Documentation/devicetree/bindings/spi/omap-spi.txt
on the way as well that makes this even clearer?
> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index f4ec9ed52939..23d51b6a9cf2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -575,7 +575,7 @@
>
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
> };
>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
> &tscadc0 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index eddb2ffb93ca..1b947e2c2e74 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -299,7 +299,7 @@
> pinctrl-0 = <&main_spi0_pins_default>;
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
>
> flash@0{
> compatible = "jedec,spi-nor";
>
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
2021-06-08 5:20 ` Jan Kiszka
@ 2021-06-08 5:24 ` Aswath Govindraju
0 siblings, 0 replies; 8+ messages in thread
From: Aswath Govindraju @ 2021-06-08 5:24 UTC (permalink / raw)
To: Jan Kiszka
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Nishanth Menon, Tero Kristo, Rob Herring, linux-arm-kernel,
devicetree, linux-kernel
Hi Jan,
On 08/06/21 10:50 am, Jan Kiszka wrote:
> On 08.06.21 07:14, Aswath Govindraju wrote:
>> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
>> Therefore, fix the property accordingly.
>>
>
> Is there a patch for Documentation/devicetree/bindings/spi/omap-spi.txt
> on the way as well that makes this even clearer?
>
Yes, these fixes are a part of conversion of omap-spi.txt to yaml
format. In the yaml file the type for the property is mentioned.
Link to yaml conversion patch,
https://lore.kernel.org/patchwork/project/lkml/list/?series=503240
>> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
>> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
>> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index f4ec9ed52939..23d51b6a9cf2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -575,7 +575,7 @@
>>
>> #address-cells = <1>;
>> #size-cells= <0>;
>> - ti,pindir-d0-out-d1-in = <1>;
>> + ti,pindir-d0-out-d1-in;
>> };
>>
>
> Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
>
Thanks,
Aswath
> Jan
>
>> &tscadc0 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index eddb2ffb93ca..1b947e2c2e74 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -299,7 +299,7 @@
>> pinctrl-0 = <&main_spi0_pins_default>;
>> #address-cells = <1>;
>> #size-cells= <0>;
>> - ti,pindir-d0-out-d1-in = <1>;
>> + ti,pindir-d0-out-d1-in;
>>
>> flash@0{
>> compatible = "jedec,spi-nor";
>>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
2021-06-08 5:14 ` [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema Aswath Govindraju
2021-06-08 5:20 ` Jan Kiszka
@ 2021-06-09 13:48 ` Vignesh Raghavendra
1 sibling, 0 replies; 8+ messages in thread
From: Vignesh Raghavendra @ 2021-06-09 13:48 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Lokesh Vutla, Kishon Vijay Abraham I, Nishanth Menon,
Tero Kristo, Rob Herring, Jan Kiszka, linux-arm-kernel,
devicetree, linux-kernel
On 6/8/21 10:44 AM, Aswath Govindraju wrote:
> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> Therefore, fix the property accordingly.
>
> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index f4ec9ed52939..23d51b6a9cf2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -575,7 +575,7 @@
>
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
> };
>
> &tscadc0 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index eddb2ffb93ca..1b947e2c2e74 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -299,7 +299,7 @@
> pinctrl-0 = <&main_spi0_pins_default>;
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
>
> flash@0{
> compatible = "jedec,spi-nor";
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Regards
Vignesh
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] arm64: dts: ti: k3-am642-evm: align ti,pindir-d0-out-d1-in property with dt-shema
2021-06-08 5:14 [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Aswath Govindraju
2021-06-08 5:14 ` [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema Aswath Govindraju
@ 2021-06-08 5:14 ` Aswath Govindraju
2021-06-09 13:47 ` Vignesh Raghavendra
2021-06-11 19:00 ` [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Nishanth Menon
2 siblings, 1 reply; 8+ messages in thread
From: Aswath Govindraju @ 2021-06-08 5:14 UTC (permalink / raw)
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Aswath Govindraju, Nishanth Menon, Tero Kristo, Rob Herring,
Jan Kiszka, linux-arm-kernel, devicetree, linux-kernel
ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.
Fixes: 4fb6c04683aa ("arm64: dts: ti: k3-am642-evm: Add support for SPI EEPROM")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index dad0efa961ed..2fd0de905e61 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -334,7 +334,7 @@
&main_spi0 {
pinctrl-names = "default";
pinctrl-0 = <&main_spi0_pins_default>;
- ti,pindir-d0-out-d1-in = <1>;
+ ti,pindir-d0-out-d1-in;
eeprom@0 {
compatible = "microchip,93lc46b";
reg = <0>;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: k3-am642-evm: align ti,pindir-d0-out-d1-in property with dt-shema
2021-06-08 5:14 ` [PATCH v2 2/2] arm64: dts: ti: k3-am642-evm: " Aswath Govindraju
@ 2021-06-09 13:47 ` Vignesh Raghavendra
0 siblings, 0 replies; 8+ messages in thread
From: Vignesh Raghavendra @ 2021-06-09 13:47 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Lokesh Vutla, Kishon Vijay Abraham I, Nishanth Menon,
Tero Kristo, Rob Herring, Jan Kiszka, linux-arm-kernel,
devicetree, linux-kernel
On 6/8/21 10:44 AM, Aswath Govindraju wrote:
> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> Therefore, fix the property accordingly.
>
> Fixes: 4fb6c04683aa ("arm64: dts: ti: k3-am642-evm: Add support for SPI EEPROM")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index dad0efa961ed..2fd0de905e61 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -334,7 +334,7 @@
> &main_spi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&main_spi0_pins_default>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
> eeprom@0 {
> compatible = "microchip,93lc46b";
> reg = <0>;
>
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean
2021-06-08 5:14 [PATCH v2 0/2] arm64: am65/am64: Fix ti,pindir-d0-out-d1-in property to boolean Aswath Govindraju
2021-06-08 5:14 ` [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema Aswath Govindraju
2021-06-08 5:14 ` [PATCH v2 2/2] arm64: dts: ti: k3-am642-evm: " Aswath Govindraju
@ 2021-06-11 19:00 ` Nishanth Menon
2 siblings, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2021-06-11 19:00 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Nishanth Menon, linux-arm-kernel, Kishon Vijay Abraham I,
devicetree, Rob Herring, Vignesh Raghavendra, Lokesh Vutla,
Tero Kristo, Jan Kiszka, linux-kernel
On Tue, 8 Jun 2021 10:44:12 +0530, Aswath Govindraju wrote:
> The following series of patches fix "ti,pindir-d0-out-d1-in" property to
> boolean.
>
> changes since v1:
> - added fixes tags
> - split the series according to their respective trees
>
> [...]
Hi Aswath Govindraju,
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema
commit: 5c5217c76a26d04e44e7c359cd5f044adb648d31
[2/2] arm64: dts: ti: k3-am642-evm: align ti,pindir-d0-out-d1-in property with dt-shema
commit: 7c5b7c6071396c9de09048b8ffa21e0b29b99f7b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 8+ messages in thread