* [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
@ 2022-07-20 2:51 Yunlong Jia
2022-07-20 6:10 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Yunlong Jia @ 2022-07-20 2:51 UTC (permalink / raw)
To: LKML
Cc: Henry Sun, Douglas Anderson, Bob Moragues, Yunlong Jia,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm
SKU6 is LTE(w/o eSIM)+WIFI+Parade
Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
index 764c451c1a857..4649eaec6318d 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
@@ -14,7 +14,7 @@
/ {
model = "Google Pazquel (Parade,LTE)";
- compatible = "google,pazquel-sku4", "qcom,sc7180";
+ compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
};
&ap_sar_sensor_i2c {
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 2:51 [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade Yunlong Jia
@ 2022-07-20 6:10 ` Krzysztof Kozlowski
2022-07-20 15:13 ` Doug Anderson
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-20 6:10 UTC (permalink / raw)
To: Yunlong Jia, LKML
Cc: Henry Sun, Douglas Anderson, Bob Moragues, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-msm
On 20/07/2022 04:51, Yunlong Jia wrote:
> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> index 764c451c1a857..4649eaec6318d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> @@ -14,7 +14,7 @@
>
> / {
> model = "Google Pazquel (Parade,LTE)";
> - compatible = "google,pazquel-sku4", "qcom,sc7180";
> + compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
You miss binding change and sku6 should be rather added before sku4 as
it is more specific, isn't it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 6:10 ` Krzysztof Kozlowski
@ 2022-07-20 15:13 ` Doug Anderson
2022-07-20 16:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2022-07-20 15:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Yunlong Jia, LKML, Henry Sun, Bob Moragues, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm
Hi,
On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/07/2022 04:51, Yunlong Jia wrote:
> > SKU6 is LTE(w/o eSIM)+WIFI+Parade
> >
> > Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> > ---
> >
> > arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> > index 764c451c1a857..4649eaec6318d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> > @@ -14,7 +14,7 @@
> >
> > / {
> > model = "Google Pazquel (Parade,LTE)";
> > - compatible = "google,pazquel-sku4", "qcom,sc7180";
> > + compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
>
> You miss binding change and sku6 should be rather added before sku4 as
> it is more specific, isn't it?
Just to close the loop: the order doesn't matter at all. Neither sku4
nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
I don't personally care about what order these are listed in, though,
so if Krzysztof is happier with "sku6" being first then I'm OK w/ it
as long as it matches the bindings.
-Doug
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 15:13 ` Doug Anderson
@ 2022-07-20 16:55 ` Krzysztof Kozlowski
2022-07-20 17:53 ` Doug Anderson
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-20 16:55 UTC (permalink / raw)
To: Doug Anderson
Cc: Yunlong Jia, LKML, Henry Sun, Bob Moragues, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm
On 20/07/2022 17:13, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 20/07/2022 04:51, Yunlong Jia wrote:
>>> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>>>
>>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
>>> ---
>>>
>>> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> index 764c451c1a857..4649eaec6318d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
>>> @@ -14,7 +14,7 @@
>>>
>>> / {
>>> model = "Google Pazquel (Parade,LTE)";
>>> - compatible = "google,pazquel-sku4", "qcom,sc7180";
>>> + compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
>>
>> You miss binding change and sku6 should be rather added before sku4 as
>> it is more specific, isn't it?
>
> Just to close the loop: the order doesn't matter at all. Neither sku4
> nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
Thanks Doug. Then the commit description could be improved, so reviewer
does not have to ask such questions. Otherwise it is confusing to see a
board which says it is for LTE version but it is actually not for LTE
version (or whatever combination you have).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 16:55 ` Krzysztof Kozlowski
@ 2022-07-20 17:53 ` Doug Anderson
2022-07-20 17:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2022-07-20 17:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Yunlong Jia, LKML, Henry Sun, Bob Moragues, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm
Hi,
On Wed, Jul 20, 2022 at 9:55 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/07/2022 17:13, Doug Anderson wrote:
> > Hi,
> >
> > On Tue, Jul 19, 2022 at 11:10 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 20/07/2022 04:51, Yunlong Jia wrote:
> >>> SKU6 is LTE(w/o eSIM)+WIFI+Parade
> >>>
> >>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> >>> ---
> >>>
> >>> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> index 764c451c1a857..4649eaec6318d 100644
> >>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> >>> @@ -14,7 +14,7 @@
> >>>
> >>> / {
> >>> model = "Google Pazquel (Parade,LTE)";
> >>> - compatible = "google,pazquel-sku4", "qcom,sc7180";
> >>> + compatible = "google,pazquel-sku4", "google,pazquel-sku6", "qcom,sc7180";
> >>
> >> You miss binding change and sku6 should be rather added before sku4 as
> >> it is more specific, isn't it?
> >
> > Just to close the loop: the order doesn't matter at all. Neither sku4
> > nor sku6 is "more specific". One has the eSIM stuffed and one doesn't.
>
> Thanks Doug. Then the commit description could be improved, so reviewer
> does not have to ask such questions. Otherwise it is confusing to see a
> board which says it is for LTE version but it is actually not for LTE
> version (or whatever combination you have).
Yeah. I guess it makes more sense with the background knowledge that
the different SKUs are:
LTE with physical SIM _and_ eSIM
LTE with only a physical SIM
WiFi only
...so both sku4 and sku6 are LTE SKUs. One has the eSIM stuffed and
one doesn't. There is a single shared device tree for the two.
-Doug
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 17:53 ` Doug Anderson
@ 2022-07-20 17:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-20 17:55 UTC (permalink / raw)
To: Doug Anderson
Cc: Yunlong Jia, LKML, Henry Sun, Bob Moragues, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm
On 20/07/2022 19:53, Doug Anderson wrote:
>
> Yeah. I guess it makes more sense with the background knowledge that
> the different SKUs are:
>
> LTE with physical SIM _and_ eSIM
> LTE with only a physical SIM
> WiFi only
>
> ...so both sku4 and sku6 are LTE SKUs. One has the eSIM stuffed and
> one doesn't. There is a single shared device tree for the two.
Above in commit msg would solve all my questions, I guess. :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
@ 2022-07-20 7:37 Yunlong Jia
2022-07-20 7:45 ` Krzysztof Kozlowski
2022-07-20 15:11 ` Doug Anderson
0 siblings, 2 replies; 9+ messages in thread
From: Yunlong Jia @ 2022-07-20 7:37 UTC (permalink / raw)
To: LKML
Cc: Douglas Anderson, Henry Sun, Bob Moragues, Yunlong Jia,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm
SKU6 is LTE(w/o eSIM)+WIFI+Parade
Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
index 764c451c1a857..767cb7450c0d8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
@@ -14,7 +14,7 @@
/ {
model = "Google Pazquel (Parade,LTE)";
- compatible = "google,pazquel-sku4", "qcom,sc7180";
+ compatible = "google,pazquel-sku6", "google,pazquel-sku4", "qcom,sc7180";
};
&ap_sar_sensor_i2c {
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 7:37 Yunlong Jia
@ 2022-07-20 7:45 ` Krzysztof Kozlowski
2022-07-20 15:11 ` Doug Anderson
1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-20 7:45 UTC (permalink / raw)
To: Yunlong Jia, LKML
Cc: Douglas Anderson, Henry Sun, Bob Moragues, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-msm
On 20/07/2022 09:37, Yunlong Jia wrote:
> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> ---
Didn't you send a v1 already to which I responded? You need to properly
version your patches and address all comments, not just some.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade
2022-07-20 7:37 Yunlong Jia
2022-07-20 7:45 ` Krzysztof Kozlowski
@ 2022-07-20 15:11 ` Doug Anderson
1 sibling, 0 replies; 9+ messages in thread
From: Doug Anderson @ 2022-07-20 15:11 UTC (permalink / raw)
To: Yunlong Jia
Cc: LKML, Henry Sun, Bob Moragues, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm
Hi,
On Wed, Jul 20, 2022 at 12:37 AM Yunlong Jia
<yunlong.jia@ecs.corp-partner.google.com> wrote:
>
> SKU6 is LTE(w/o eSIM)+WIFI+Parade
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> index 764c451c1a857..767cb7450c0d8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dts
> @@ -14,7 +14,7 @@
>
> / {
> model = "Google Pazquel (Parade,LTE)";
> - compatible = "google,pazquel-sku4", "qcom,sc7180";
> + compatible = "google,pazquel-sku6", "google,pazquel-sku4", "qcom,sc7180";
Now this doesn't match the bindings. The bindings list 4 first and
then 6. You are listing 6 first then 4. The order doesn't really
matter, but the two places need to match.
As Krzysztof says, you should be incrementing the version of your
patches, adding some history, and you should also put the two patches
in one series.
I believe you're using patman, so something like this and have _both_
changes applied and send them out.
In patch #1 (the bindings):
Series-changes: 3
- Bindings and dts in the same series.
In patch #2 (the dts):
Series-version: 3
Series-changes: 2
- Put sku6 before sku4
Series-changes: 3
- Bindings and dts in the same series.
-Doug
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-07-20 17:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 2:51 [PATCH] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade Yunlong Jia
2022-07-20 6:10 ` Krzysztof Kozlowski
2022-07-20 15:13 ` Doug Anderson
2022-07-20 16:55 ` Krzysztof Kozlowski
2022-07-20 17:53 ` Doug Anderson
2022-07-20 17:55 ` Krzysztof Kozlowski
2022-07-20 7:37 Yunlong Jia
2022-07-20 7:45 ` Krzysztof Kozlowski
2022-07-20 15:11 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).