[PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function

[PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function

[Masami Hiramatsu]

Instead using arch-dependent do_IRQ, use do_softirq as a
target function.

Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
other architectures which don't define do_IRQ. So, instead of using
that, use do_softirq which is defined in kernel/softirq.c.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
index 113b4d9bc733..20f15c858af6 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
@@ -32,7 +32,7 @@ do_reset
 
 FILTER=set_ftrace_filter
 FUNC1="schedule"
-FUNC2="do_IRQ"
+FUNC2="do_softirq"
 
 ALL_FUNCS="#### all functions enabled ####"
 

Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function

[Steven Rostedt]

On Fri, 27 Oct 2017 15:10:30 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
> 
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Shuah,

Can you take this in your tree?

Thanks!

-- Steve

> ---
>  .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>  
>  ALL_FUNCS="#### all functions enabled ####"
>  

Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function

[Shuah Khan]

On 10/31/2017 01:37 PM, Steven Rostedt wrote:
> On Fri, 27 Oct 2017 15:10:30 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
>> Instead using arch-dependent do_IRQ, use do_softirq as a
>> target function.
>>
>> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
>> other architectures which don't define do_IRQ. So, instead of using
>> that, use do_softirq which is defined in kernel/softirq.c.
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Shuah,
> 
> Can you take this in your tree?
> 
> Thanks!
> 
> -- Steve

Yes. I will get this in.

thanks,
-- Shuah

Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function

[Shuah Khan]

On 10/27/2017 12:10 AM, Masami Hiramatsu wrote:
> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
> 
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
>  .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>  
>  ALL_FUNCS="#### all functions enabled ####"
>  
> 
> 
> 

Looks good to me. I will queue this for 4.15-rc1

thanks,
-- Shuah