* [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function
@ 2017-10-27 6:10 Masami Hiramatsu
2017-10-31 19:37 ` Steven Rostedt
2017-11-01 21:15 ` Shuah Khan
0 siblings, 2 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2017-10-27 6:10 UTC (permalink / raw)
To: linux-kselftest, shuah, Steven Rostedt
Cc: mhiramat, linux-kernel, sumit.semwal, naresh.kamboju
Instead using arch-dependent do_IRQ, use do_softirq as a
target function.
Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
other architectures which don't define do_IRQ. So, instead of using
that, use do_softirq which is defined in kernel/softirq.c.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
.../ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
index 113b4d9bc733..20f15c858af6 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
@@ -32,7 +32,7 @@ do_reset
FILTER=set_ftrace_filter
FUNC1="schedule"
-FUNC2="do_IRQ"
+FUNC2="do_softirq"
ALL_FUNCS="#### all functions enabled ####"
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function
2017-10-27 6:10 [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function Masami Hiramatsu
@ 2017-10-31 19:37 ` Steven Rostedt
2017-10-31 19:51 ` Shuah Khan
2017-11-01 21:15 ` Shuah Khan
1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2017-10-31 19:37 UTC (permalink / raw)
To: Masami Hiramatsu, shuah
Cc: linux-kselftest, linux-kernel, sumit.semwal, naresh.kamboju
On Fri, 27 Oct 2017 15:10:30 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
>
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Shuah,
Can you take this in your tree?
Thanks!
-- Steve
> ---
> .../ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>
> FILTER=set_ftrace_filter
> FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>
> ALL_FUNCS="#### all functions enabled ####"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function
2017-10-31 19:37 ` Steven Rostedt
@ 2017-10-31 19:51 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-10-31 19:51 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu
Cc: linux-kselftest, linux-kernel, sumit.semwal, naresh.kamboju,
Shuah Khan, shuah Khan
On 10/31/2017 01:37 PM, Steven Rostedt wrote:
> On Fri, 27 Oct 2017 15:10:30 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
>> Instead using arch-dependent do_IRQ, use do_softirq as a
>> target function.
>>
>> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
>> other architectures which don't define do_IRQ. So, instead of using
>> that, use do_softirq which is defined in kernel/softirq.c.
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Shuah,
>
> Can you take this in your tree?
>
> Thanks!
>
> -- Steve
Yes. I will get this in.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function
2017-10-27 6:10 [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function Masami Hiramatsu
2017-10-31 19:37 ` Steven Rostedt
@ 2017-11-01 21:15 ` Shuah Khan
1 sibling, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-11-01 21:15 UTC (permalink / raw)
To: Masami Hiramatsu, linux-kselftest, Steven Rostedt
Cc: linux-kernel, sumit.semwal, naresh.kamboju, Shuah Khan, Shuah Khan
On 10/27/2017 12:10 AM, Masami Hiramatsu wrote:
> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
>
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> .../ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>
> FILTER=set_ftrace_filter
> FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>
> ALL_FUNCS="#### all functions enabled ####"
>
>
>
>
Looks good to me. I will queue this for 4.15-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-01 21:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 6:10 [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function Masami Hiramatsu
2017-10-31 19:37 ` Steven Rostedt
2017-10-31 19:51 ` Shuah Khan
2017-11-01 21:15 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).