From: "Andreas Färber" <afaerber@suse.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org,
daniel.thompson@linaro.org, amit.kucheria@linaro.org,
liuwei@actions-semi.com
Subject: Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC
Date: Sat, 4 Nov 2017 16:36:30 +0800 [thread overview]
Message-ID: <7c87aee4-dde4-ab3d-06b0-75f3686ab5dd@suse.de> (raw)
In-Reply-To: <1509479663-8985-3-git-send-email-manivannan.sadhasivam@linaro.org>
Hi Mani,
Still on travels, but some quick comments:
Please compare the CC list from my patch series - you seem to be missing
some Actions Semi people.
Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam:
> This patch adds clock driver for Actions Semi OWL
> series S900 SoC.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> MAINTAINERS | 5 +
> drivers/clk/Makefile | 1 +
> drivers/clk/owl/Makefile | 2 +
> drivers/clk/owl/clk-factor.c | 270 ++++++++++++
> drivers/clk/owl/clk-pll.c | 346 +++++++++++++++
> drivers/clk/owl/clk-s900.c | 587 +++++++++++++++++++++++++
> drivers/clk/owl/clk.c | 318 ++++++++++++++
> drivers/clk/owl/clk.h | 301 +++++++++++++
Taking into account previous arm/DT side comments I received, we should
use clk/actions/ rather than clk/owl/. We can still use owl- or -owl
inside actions/ if necessary.
> include/dt-bindings/clock/actions,s900-clock.h | 141 ++++++
> 9 files changed, 1971 insertions(+)
> create mode 100644 drivers/clk/owl/Makefile
> create mode 100644 drivers/clk/owl/clk-factor.c
> create mode 100644 drivers/clk/owl/clk-pll.c
> create mode 100644 drivers/clk/owl/clk-s900.c
> create mode 100644 drivers/clk/owl/clk.c
> create mode 100644 drivers/clk/owl/clk.h
> create mode 100644 include/dt-bindings/clock/actions,s900-clock.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2d3d750..beae8aa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1098,6 +1098,11 @@ F: arch/arm/mach-*/
> F: arch/arm/plat-*/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git
>
> +ARM/ACTIONS SEMI SoC CLOCK SUPPORT
> +L: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
You're not a mailing list. If you want to be the maintainer (M:), fine
with me, but I'd like to be CC'ed please - either via R: here or by
extending the section below.
> +S: Maintained
> +F: drivers/clk/owl/
This is lacking the binding.
> +
> ARM/ACTIONS SEMI ARCHITECTURE
> M: Andreas Färber <afaerber@suse.de>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index c99f363..821c1e1 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -75,6 +75,7 @@ endif
> obj-y += mvebu/
> obj-$(CONFIG_ARCH_MXS) += mxs/
> obj-$(CONFIG_COMMON_CLK_NXP) += nxp/
> +obj-$(CONFIG_ARCH_ACTIONS) += owl/
> obj-$(CONFIG_MACH_PISTACHIO) += pistachio/
> obj-$(CONFIG_COMMON_CLK_PXA) += pxa/
> obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/
> diff --git a/drivers/clk/owl/Makefile b/drivers/clk/owl/Makefile
> new file mode 100644
> index 0000000..dbba0af
> --- /dev/null
> +++ b/drivers/clk/owl/Makefile
> @@ -0,0 +1,2 @@
> +obj-y += clk.o clk-pll.o clk-factor.o
> +obj-$(CONFIG_ARCH_ACTIONS) += clk-s900.o
$(CONFIG_ARCH_ACTIONS) is superfluous here.
> diff --git a/drivers/clk/owl/clk-factor.c b/drivers/clk/owl/clk-factor.c
> new file mode 100644
> index 0000000..6429acd
> --- /dev/null
> +++ b/drivers/clk/owl/clk-factor.c
> @@ -0,0 +1,270 @@
> +/*
> + * Copyright (c) 2014 Actions Semi Inc.
> + * David Liu <liuwei@actions-semi.com>
> + *
> + * Copyright (c) 2017 Linaro Ltd.
> + * Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License v2 as published by
> + * the Free Software Foundation.
I had found that S500 code was licensed under GPLv2+ but some S900 parts
were GPLv2 only. I personally have a bias towards GPLv2+ - any chance we
can use that here?
Implementation not yet reviewed.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-11-04 8:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:54 [PATCH 0/3] Add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes Manivannan Sadhasivam
2017-11-02 0:06 ` Rob Herring
2017-11-02 17:55 ` Manivannan Sadhasivam
2017-11-04 9:02 ` Manivannan Sadhasivam
2017-11-04 8:43 ` Andreas Färber
2017-11-04 9:50 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-11-02 0:02 ` Rob Herring
2017-11-02 18:41 ` Manivannan Sadhasivam
2017-11-04 8:36 ` Andreas Färber [this message]
2017-11-04 9:19 ` Manivannan Sadhasivam
2017-11-04 9:30 ` Andreas Färber
2017-11-04 9:54 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 3/3] Documentation: add Actions S900 clock bindings Manivannan Sadhasivam
2017-11-02 0:04 ` Rob Herring
2017-11-02 18:47 ` Manivannan Sadhasivam
2017-11-04 9:28 ` Manivannan Sadhasivam
2017-11-04 8:55 ` Andreas Färber
2017-11-04 9:41 ` Manivannan Sadhasivam
2017-11-04 9:05 ` [PATCH 0/3] Add clock driver for Actions S900 SoC Andreas Färber
2017-11-04 10:04 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c87aee4-dde4-ab3d-06b0-75f3686ab5dd@suse.de \
--to=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).