From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
sboyd@codeaurora.org, "Andreas Färber" <afaerber@suse.de>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
mchehab@kernel.org, rdunlap@infradead.org,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Amit Kucheria" <amit.kucheria@linaro.org>,
liuwei@actions-semi.com
Subject: Re: [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes
Date: Thu, 2 Nov 2017 23:25:43 +0530 [thread overview]
Message-ID: <CAOZjjh=zCEEcKVN9Lop2Mhkcw79GP=XcN=J1f2wevnq8OHv0Uw@mail.gmail.com> (raw)
In-Reply-To: <20171102000616.ug7s7s6fmnubq7y5@rob-hp-laptop>
Hi Rob,
On 2 November 2017 at 05:36, Rob Herring <robh@kernel.org> wrote:
> On Wed, Nov 01, 2017 at 01:24:21AM +0530, Manivannan Sadhasivam wrote:
>> This patch adds clock controller nodes for Actions Semi s900 SoC
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> ---
>> arch/arm64/boot/dts/actions/s900.dtsi | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi
>> index 11406f6..c099ef1 100644
>> --- a/arch/arm64/boot/dts/actions/s900.dtsi
>> +++ b/arch/arm64/boot/dts/actions/s900.dtsi
>> @@ -5,6 +5,7 @@
>> */
>>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/clock/actions,s900-clock.h>
>>
>> / {
>> compatible = "actions,s900";
>> @@ -88,6 +89,24 @@
>> #clock-cells = <0>;
>> };
>>
>> + losc: losc {
>> + compatible = "fixed-clock";
>> + clock-frequency = <32768>;
>> + #clock-cells = <0>;
>> + };
>> +
>> + diff_24M: diff_24M {
>> + compatible = "fixed-clock";
>> + clock-frequency = <24000000>;
>> + #clock-cells = <0>;
>> + };
>
> These 2 are inputs to the clock ctrlr? The clock controller should have
> a clocks property then.
>
Actually losc and hosc (already defined) are the sources to the clock
controller.
There isn't much documentation about diff_24M clock which seems to be only
sourcing eDP. Since, the vendor driver defined these 3 clocks (losc,
hosc, diff_24M)
as fixed rate clocks I have added them in the device tree as
"fixed-clock" nodes.
So, as per your suggestion I will add hosc and losc as clock providers for the
clock controller like below in next revision:
clocks = <&hosc>, <&losc>;
Thanks,
Mani
>> +
>> + clock: clock-controller@e0160000 {
>> + compatible = "actions,s900-clock";
>> + reg = <0 0xe0160000 0 0x1000>;
>> + #clock-cells = <1>;
>> + };
>> +
>> soc {
>> compatible = "simple-bus";
>> #address-cells = <2>;
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2017-11-02 17:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:54 [PATCH 0/3] Add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes Manivannan Sadhasivam
2017-11-02 0:06 ` Rob Herring
2017-11-02 17:55 ` Manivannan Sadhasivam [this message]
2017-11-04 9:02 ` Manivannan Sadhasivam
2017-11-04 8:43 ` Andreas Färber
2017-11-04 9:50 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-11-02 0:02 ` Rob Herring
2017-11-02 18:41 ` Manivannan Sadhasivam
2017-11-04 8:36 ` Andreas Färber
2017-11-04 9:19 ` Manivannan Sadhasivam
2017-11-04 9:30 ` Andreas Färber
2017-11-04 9:54 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 3/3] Documentation: add Actions S900 clock bindings Manivannan Sadhasivam
2017-11-02 0:04 ` Rob Herring
2017-11-02 18:47 ` Manivannan Sadhasivam
2017-11-04 9:28 ` Manivannan Sadhasivam
2017-11-04 8:55 ` Andreas Färber
2017-11-04 9:41 ` Manivannan Sadhasivam
2017-11-04 9:05 ` [PATCH 0/3] Add clock driver for Actions S900 SoC Andreas Färber
2017-11-04 10:04 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOZjjh=zCEEcKVN9Lop2Mhkcw79GP=XcN=J1f2wevnq8OHv0Uw@mail.gmail.com' \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).