From: "Andreas Färber" <afaerber@suse.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org,
daniel.thompson@linaro.org, amit.kucheria@linaro.org,
liuwei@actions-semi.com
Subject: Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC
Date: Sat, 4 Nov 2017 17:30:36 +0800 [thread overview]
Message-ID: <25a2e233-f565-8baa-17e2-9c867bbbe9d0@suse.de> (raw)
In-Reply-To: <20171104091949.GB14705@linaro.org>
Hi,
Am 04.11.2017 um 17:19 schrieb Manivannan Sadhasivam:
>>> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
>>> index c99f363..821c1e1 100644
>>> --- a/drivers/clk/Makefile
>>> +++ b/drivers/clk/Makefile
>>> @@ -75,6 +75,7 @@ endif
>>> obj-y += mvebu/
>>> obj-$(CONFIG_ARCH_MXS) += mxs/
>>> obj-$(CONFIG_COMMON_CLK_NXP) += nxp/
>>> +obj-$(CONFIG_ARCH_ACTIONS) += owl/
>>> obj-$(CONFIG_MACH_PISTACHIO) += pistachio/
>>> obj-$(CONFIG_COMMON_CLK_PXA) += pxa/
>>> obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/
>>> diff --git a/drivers/clk/owl/Makefile b/drivers/clk/owl/Makefile
>>> new file mode 100644
>>> index 0000000..dbba0af
>>> --- /dev/null
>>> +++ b/drivers/clk/owl/Makefile
>>> @@ -0,0 +1,2 @@
>>> +obj-y += clk.o clk-pll.o clk-factor.o
>>> +obj-$(CONFIG_ARCH_ACTIONS) += clk-s900.o
>>
>> $(CONFIG_ARCH_ACTIONS) is superfluous here.
>>
> Okay. Since, we haven't added ARCH_ACTIONS to defconfig yet I intentionally
> made this conditional compilation.
>
> Would like a suggestion from you on this!
My point was that the ../Makefile already uses $(CONFIG_ARCH_ACTIONS),
so $(CONFIG_ARCH_ACTIONS) can never be n here.
Instead you should probably either use $(CONFIG_ARM64) or better some
new Kconfig option (CONFIG_CLK_OWL_S900?), so that we don't
unnecessarily compile S900 on 32-bit arm and S500 on arm64.
Another point: What about S700? Does it need to duplicate clk-s900.c or
can we share any code between the two?
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-11-04 9:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:54 [PATCH 0/3] Add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes Manivannan Sadhasivam
2017-11-02 0:06 ` Rob Herring
2017-11-02 17:55 ` Manivannan Sadhasivam
2017-11-04 9:02 ` Manivannan Sadhasivam
2017-11-04 8:43 ` Andreas Färber
2017-11-04 9:50 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-11-02 0:02 ` Rob Herring
2017-11-02 18:41 ` Manivannan Sadhasivam
2017-11-04 8:36 ` Andreas Färber
2017-11-04 9:19 ` Manivannan Sadhasivam
2017-11-04 9:30 ` Andreas Färber [this message]
2017-11-04 9:54 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 3/3] Documentation: add Actions S900 clock bindings Manivannan Sadhasivam
2017-11-02 0:04 ` Rob Herring
2017-11-02 18:47 ` Manivannan Sadhasivam
2017-11-04 9:28 ` Manivannan Sadhasivam
2017-11-04 8:55 ` Andreas Färber
2017-11-04 9:41 ` Manivannan Sadhasivam
2017-11-04 9:05 ` [PATCH 0/3] Add clock driver for Actions S900 SoC Andreas Färber
2017-11-04 10:04 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25a2e233-f565-8baa-17e2-9c867bbbe9d0@suse.de \
--to=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).