From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"shawn.sung@mediatek.corp-partner.google.com"
<shawn.sung@mediatek.corp-partner.google.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 02/11] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"
Date: Thu, 14 Mar 2024 05:14:05 +0000 [thread overview]
Message-ID: <8139deaaaa15ce35e453ca5936abd710f0756fc2.camel@mediatek.com> (raw)
In-Reply-To: <20240226085059.26850-3-shawn.sung@mediatek.com>
Hi, Shawn:
On Mon, 2024-02-26 at 16:50 +0800, Shawn Sung wrote:
> From: Hsiao Chien Sung <shawn.sung@mediatek.corp-partner.google.com>
>
> Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp":
> - To align the naming rule
> - To reduce the code size
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: Hsiao Chien Sung <
> shawn.sung@mediatek.corp-partner.google.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +++++++---------
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 6 +++---
> 2 files changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index fe965ad7d282..d8b591aff3c2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -276,9 +276,9 @@ static void mtk_crtc_ddp_clk_disable(struct
> mtk_crtc *mtk_crtc)
> }
>
> static
> -struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc
> *crtc,
> - struct drm_plane
> *plane,
> - unsigned int
> *local_layer)
> +struct mtk_ddp_comp *mtk_ddp_comp_for_plane(struct drm_crtc *crtc,
> + struct drm_plane *plane,
> + unsigned int *local_layer)
> {
> struct mtk_crtc *mtk_crtc = to_mtk_crtc(crtc);
> struct mtk_ddp_comp *comp;
> @@ -428,7 +428,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_crtc
> *mtk_crtc)
>
> /* should not enable layer before crtc enabled */
> plane_state->pending.enable = false;
> - comp = mtk_drm_ddp_comp_for_plane(crtc, plane,
> &local_layer);
> + comp = mtk_ddp_comp_for_plane(crtc, plane,
> &local_layer);
> if (comp)
> mtk_ddp_comp_layer_config(comp, local_layer,
> plane_state, NULL);
> @@ -519,8 +519,7 @@ static void mtk_crtc_ddp_config(struct drm_crtc
> *crtc,
> if (!plane_state->pending.config)
> continue;
>
> - comp = mtk_drm_ddp_comp_for_plane(crtc, plane,
> - &local_layer)
> ;
> + comp = mtk_ddp_comp_for_plane(crtc, plane,
> &local_layer);
>
> if (comp)
> mtk_ddp_comp_layer_config(comp,
> local_layer,
> @@ -544,8 +543,7 @@ static void mtk_crtc_ddp_config(struct drm_crtc
> *crtc,
> if (!plane_state->pending.async_config)
> continue;
>
> - comp = mtk_drm_ddp_comp_for_plane(crtc, plane,
> - &local_layer)
> ;
> + comp = mtk_ddp_comp_for_plane(crtc, plane,
> &local_layer);
>
> if (comp)
> mtk_ddp_comp_layer_config(comp,
> local_layer,
> @@ -709,7 +707,7 @@ int mtk_crtc_plane_check(struct drm_crtc *crtc,
> struct drm_plane *plane,
> unsigned int local_layer;
> struct mtk_ddp_comp *comp;
>
> - comp = mtk_drm_ddp_comp_for_plane(crtc, plane, &local_layer);
> + comp = mtk_ddp_comp_for_plane(crtc, plane, &local_layer);
> if (comp)
> return mtk_ddp_comp_layer_check(comp, local_layer,
> state);
> return 0;
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> index 93d79a1366e9..ba985206fdd2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> @@ -3,8 +3,8 @@
> * Copyright (c) 2015 MediaTek Inc.
> */
>
> -#ifndef MTK_DRM_DDP_COMP_H
> -#define MTK_DRM_DDP_COMP_H
> +#ifndef MTK_DDP_COMP_H
> +#define MTK_DDP_COMP_H
>
> #include <linux/io.h>
> #include <linux/pm_runtime.h>
> @@ -340,4 +340,4 @@ void mtk_ddp_write_relaxed(struct cmdq_pkt
> *cmdq_pkt, unsigned int value,
> void mtk_ddp_write_mask(struct cmdq_pkt *cmdq_pkt, unsigned int
> value,
> struct cmdq_client_reg *cmdq_reg, void __iomem
> *regs,
> unsigned int offset, unsigned int mask);
> -#endif /* MTK_DRM_DDP_COMP_H */
> +#endif /* MTK_DDP_COMP_H */
next prev parent reply other threads:[~2024-03-14 5:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 8:50 [PATCH 00/11] Rename mtk_drm_* to mtk_* Shawn Sung
2024-02-26 8:50 ` [PATCH 01/11] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 3:26 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 02/11] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 5:14 ` CK Hu (胡俊光) [this message]
2024-02-26 8:50 ` [PATCH 03/11] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 5:20 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 04/11] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 5:49 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 05/11] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:24 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 06/11] drm/mediatek: Rename files "mtk_drm_crtc.*" to "mtk_crtc.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:40 ` CK Hu (胡俊光)
2024-03-14 6:50 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 07/11] drm/mediatek: Rename files "mtk_drm_ddp_comp.*" to "mtk_ddp_comp.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:54 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 08/11] drm/mediatek: Rename files "mtk_drm_plane.*" to "mtk_plane.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:57 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 09/11] drm/mediatek: Rename files "mtk_drm_gem.*" to "mtk_gem.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 7:03 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 10/11] drm/mediatek: Rename mtk_ddp_comp functions Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 7:09 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 11/11] drm/mediatek: Rename "pending_needs_vblank" to "needs_vblank" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-02-29 2:35 ` Shawn Sung (宋孝謙)
2024-03-14 7:26 ` CK Hu (胡俊光)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8139deaaaa15ce35e453ca5936abd710f0756fc2.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=christian.koenig@amd.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=shawn.sung@mediatek.corp-partner.google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).