From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"shawn.sung@mediatek.corp-partner.google.com"
<shawn.sung@mediatek.corp-partner.google.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 11/11] drm/mediatek: Rename "pending_needs_vblank" to "needs_vblank"
Date: Thu, 14 Mar 2024 07:26:20 +0000 [thread overview]
Message-ID: <db993e44824b69dc36cbb36ff9558e10a3cf0c8e.camel@mediatek.com> (raw)
In-Reply-To: <20240226085059.26850-12-shawn.sung@mediatek.com>
Hi, Shawn:
On Mon, 2024-02-26 at 16:50 +0800, Shawn Sung wrote:
> From: Hsiao Chien Sung <shawn.sung@mediatek.corp-partner.google.com>
>
> Rename "pending_needs_vblank" to "needs_vblank" to reduce the code
> size.
In mtk crtc, many variable has prefix 'pending' to indicate something
has not been done yet. To align this naming, I think it's better to
keep this prefix.
Regards,
CK
>
> Signed-off-by: Hsiao Chien Sung <
> shawn.sung@mediatek.corp-partner.google.com>
> ---
> drivers/gpu/drm/mediatek/mtk_crtc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_crtc.c
> b/drivers/gpu/drm/mediatek/mtk_crtc.c
> index 7fe234de83a3..a1fb6c67681d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_crtc.c
> @@ -42,7 +42,7 @@ struct mtk_crtc {
> struct drm_crtc base;
> bool enabled;
>
> - bool pending_needs_vblank;
> + bool needs_vblank;
> struct drm_pending_vblank_event *event;
>
> struct drm_plane *planes;
> @@ -105,9 +105,9 @@ static void mtk_crtc_finish_page_flip(struct
> mtk_crtc *mtk_crtc)
> static void mtk_drm_finish_page_flip(struct mtk_crtc *mtk_crtc)
> {
> drm_crtc_handle_vblank(&mtk_crtc->base);
> - if (!mtk_crtc->config_updating && mtk_crtc-
> >pending_needs_vblank) {
> + if (!mtk_crtc->config_updating && mtk_crtc->needs_vblank) {
> mtk_crtc_finish_page_flip(mtk_crtc);
> - mtk_crtc->pending_needs_vblank = false;
> + mtk_crtc->needs_vblank = false;
> }
> }
>
> @@ -571,7 +571,7 @@ static void mtk_crtc_update_config(struct
> mtk_crtc *mtk_crtc, bool needs_vblank)
> mutex_lock(&mtk_crtc->hw_lock);
> mtk_crtc->config_updating = true;
> if (needs_vblank)
> - mtk_crtc->pending_needs_vblank = true;
> + mtk_crtc->needs_vblank = true;
>
> for (i = 0; i < mtk_crtc->layer_nr; i++) {
> struct drm_plane *plane = &mtk_crtc->planes[i];
prev parent reply other threads:[~2024-03-14 7:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 8:50 [PATCH 00/11] Rename mtk_drm_* to mtk_* Shawn Sung
2024-02-26 8:50 ` [PATCH 01/11] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 3:26 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 02/11] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 5:14 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 03/11] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 5:20 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 04/11] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 5:49 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 05/11] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:24 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 06/11] drm/mediatek: Rename files "mtk_drm_crtc.*" to "mtk_crtc.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:40 ` CK Hu (胡俊光)
2024-03-14 6:50 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 07/11] drm/mediatek: Rename files "mtk_drm_ddp_comp.*" to "mtk_ddp_comp.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:54 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 08/11] drm/mediatek: Rename files "mtk_drm_plane.*" to "mtk_plane.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 6:57 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 09/11] drm/mediatek: Rename files "mtk_drm_gem.*" to "mtk_gem.*" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 7:03 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 10/11] drm/mediatek: Rename mtk_ddp_comp functions Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-03-14 7:09 ` CK Hu (胡俊光)
2024-02-26 8:50 ` [PATCH 11/11] drm/mediatek: Rename "pending_needs_vblank" to "needs_vblank" Shawn Sung
2024-02-26 12:39 ` AngeloGioacchino Del Regno
2024-02-29 2:35 ` Shawn Sung (宋孝謙)
2024-03-14 7:26 ` CK Hu (胡俊光) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db993e44824b69dc36cbb36ff9558e10a3cf0c8e.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=christian.koenig@amd.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=shawn.sung@mediatek.corp-partner.google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).