From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Frank Lee <tiny.windzz@gmail.com>
Cc: "Frank Lee" <frank@allwinnertech.com>,
"Vasily Khoruzhick" <anarsoul@gmail.com>,
"Zhang Rui" <rui.zhang@intel.com>,
"Amit Kucheria" <amit.kucheria@verdurent.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Linux PM" <linux-pm@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
黄烁生 <huangshuosheng@allwinnertech.com>,
liyong@allwinnertech.com
Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate
Date: Fri, 17 Jul 2020 09:56:18 +0200 [thread overview]
Message-ID: <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org> (raw)
In-Reply-To: <CAEExFWv9_1kec_b+t+nnvT3cziXzmVa8GzJT3pQAZiCf4KA0ig@mail.gmail.com>
On 17/07/2020 09:35, Frank Lee wrote:
> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> On 14/07/2020 09:13, Frank Lee wrote:
>>> From: Yangtao Li <frank@allwinnertech.com>
>>>
>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
>>> calculation. On the other hand, the newer SOC may store other data in
>>> the space other than 12bit sensor data. Add mask operation to read data
>>> to avoid conversion error.
>>>
>>> Signed-off-by: Yangtao Li <frank@allwinnertech.com>
>>> Reviewed-by: Yangtao Li <tiny.windzz@gmail.com>
>>
>> Can you clarify these SoB ?
>
> Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>',
> maybe this should be removed directly?
>
>>
>> Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ?
>>
>
> Yeah.
You are not supposed to add reviewed-by yourself. Please remove it.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-07-17 7:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:55 [PATCH v4 00/16] Allwinner A100 Initial support Frank Lee
2020-07-14 6:59 ` [PATCH v4 01/16] dt-bindings: clk: sunxi-ccu: add compatible string for A100 CCU and R-CCU Frank Lee
2020-07-14 7:02 ` [PATCH v4 02/16] clk: sunxi-ng: add support for the Allwinner A100 CCU Frank Lee
2020-07-14 7:03 ` [PATCH v4 03/16] dt-bindings: pinctrl: sunxi: Get rid of continual nesting Frank Lee
2020-07-14 20:50 ` Rob Herring
2020-07-14 7:06 ` [PATCH v4 04/16] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings Frank Lee
2020-07-14 20:51 ` Rob Herring
2020-07-14 7:07 ` [PATCH v4 05/16] pinctrl: sunxi: add support for the Allwinner A100 pin controller Frank Lee
2020-07-14 7:08 ` [PATCH v4 06/16] dt-bindings: nvmem: SID: add binding for A100's SID controller Frank Lee
2020-07-14 20:51 ` Rob Herring
2020-07-20 9:23 ` Srinivas Kandagatla
2020-07-14 7:11 ` [PATCH v4 07/16] dt-bindings: thermal: sun8i: Add binding for A100's THS controller Frank Lee
2020-07-14 7:13 ` [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate Frank Lee
2020-07-17 4:26 ` Daniel Lezcano
2020-07-17 7:35 ` Frank Lee
2020-07-17 7:56 ` Daniel Lezcano [this message]
2020-07-20 9:27 ` Frank Lee
2020-07-20 10:38 ` Daniel Lezcano
2020-07-23 16:56 ` Maxime Ripard
2020-07-14 7:14 ` [PATCH v4 09/16] thermal: sun8i: Add A100's THS controller support Frank Lee
2020-07-14 7:15 ` [PATCH v4 10/16] mfd: axp20x: Allow the AXP803 to be probed by I2C Frank Lee
2020-07-14 11:54 ` Chen-Yu Tsai
2020-07-14 7:16 ` [PATCH v4 11/16] dt-bindings: irq: sun7i-nmi: fix dt-binding for a80 nmi Frank Lee
2020-07-14 7:17 ` [PATCH v4 12/16] dt-bindings: irq: sun7i-nmi: Add binding for A100's NMI controller Frank Lee
2020-07-14 7:18 ` [PATCH v4 13/16] dt-bindings: i2c: mv64xxx: Add compatible for the A100 i2c node Frank Lee
2020-07-22 10:55 ` Wolfram Sang
2020-07-14 7:20 ` [PATCH v4 14/16] arm64: allwinner: A100: add the basical Allwinner A100 DTSI file Frank Lee
2020-07-23 16:54 ` Maxime Ripard
2020-07-24 6:25 ` Frank Lee
2020-07-24 8:12 ` Maxime Ripard
2020-07-14 7:21 ` [PATCH v4 15/16] dt-bindings: arm: sunxi: Add Allwinner A100 Perf1 Board bindings Frank Lee
2020-07-14 7:22 ` [PATCH v4 16/16] arm64: allwinner: A100: add support for Allwinner Perf1 board Frank Lee
2020-07-17 4:28 ` [PATCH v4 00/16] Allwinner A100 Initial support Daniel Lezcano
2020-07-17 7:38 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=anarsoul@gmail.com \
--cc=frank@allwinnertech.com \
--cc=huangshuosheng@allwinnertech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liyong@allwinnertech.com \
--cc=mripard@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).