* install is no longer PHONY?
@ 2020-02-10 5:14 Michael Ellerman
2020-02-13 16:32 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2020-02-10 5:14 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Linux Kernel Mailing List, Linux Kbuild mailing list
Hi Masahiro,
I noticed that "install" seems to be no longer PHONY, or at least if I
have a file/directory called install then the build doesn't run.
eg:
$ touch install
$ make install
make: 'install' is up to date.
$ rm install
$ make install
LDS arch/powerpc/boot/zImage.lds
WRAP arch/powerpc/boot/zImage.pseries
WRAP arch/powerpc/boot/zImage.epapr
In the past the presence of an install file/directory didn't have any
affect.
It seems this changed in:
d79424137a73 ("kbuild: do not update config when running install targets")
Was that expected?
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: install is no longer PHONY?
2020-02-10 5:14 install is no longer PHONY? Michael Ellerman
@ 2020-02-13 16:32 ` Masahiro Yamada
2020-02-17 10:28 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2020-02-13 16:32 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Linux Kernel Mailing List, Linux Kbuild mailing list
Hi Michael,
On Mon, Feb 10, 2020 at 2:15 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Hi Masahiro,
>
> I noticed that "install" seems to be no longer PHONY, or at least if I
> have a file/directory called install then the build doesn't run.
>
> eg:
> $ touch install
> $ make install
> make: 'install' is up to date.
> $ rm install
> $ make install
> LDS arch/powerpc/boot/zImage.lds
> WRAP arch/powerpc/boot/zImage.pseries
> WRAP arch/powerpc/boot/zImage.epapr
I think the reason is
'install' is not specified as a phony target.
You can add 'PHONY += install' to fix it.
PHONY += install # please add this!
install:
$(Q)$(MAKE) $(build)=$(boot) install
Please do so in both arch/powerpc/Makefile and
arch/powerpc/boot/Makefile.
> In the past the presence of an install file/directory didn't have any
> affect.
>
> It seems this changed in:
> d79424137a73 ("kbuild: do not update config when running install targets")
>
> Was that expected?
>
> cheers
I do not think commit is related.
Prior to this commit, I still see the same issue.
$ git checkout d7942413^
$ touch install
$ make -s ARCH=powerpc allnoconfig
$ make ARCH=powerpc install
make: 'install' is up to date.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: install is no longer PHONY?
2020-02-13 16:32 ` Masahiro Yamada
@ 2020-02-17 10:28 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-02-17 10:28 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Linux Kernel Mailing List, Linux Kbuild mailing list
Masahiro Yamada <masahiroy@kernel.org> writes:
> Hi Michael,
>
> On Mon, Feb 10, 2020 at 2:15 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Hi Masahiro,
>>
>> I noticed that "install" seems to be no longer PHONY, or at least if I
>> have a file/directory called install then the build doesn't run.
>>
>> eg:
>> $ touch install
>> $ make install
>> make: 'install' is up to date.
>> $ rm install
>> $ make install
>> LDS arch/powerpc/boot/zImage.lds
>> WRAP arch/powerpc/boot/zImage.pseries
>> WRAP arch/powerpc/boot/zImage.epapr
>
>
> I think the reason is
> 'install' is not specified as a phony target.
>
> You can add 'PHONY += install' to fix it.
>
>
> PHONY += install # please add this!
> install:
> $(Q)$(MAKE) $(build)=$(boot) install
>
>
> Please do so in both arch/powerpc/Makefile and
> arch/powerpc/boot/Makefile.
Oh lol, sorry I didn't realise install was in the arch Makefile.
>> In the past the presence of an install file/directory didn't have any
>> affect.
>>
>> It seems this changed in:
>> d79424137a73 ("kbuild: do not update config when running install targets")
>>
>> Was that expected?
>>
>> cheers
>
>
> I do not think commit is related.
>
> Prior to this commit, I still see the same issue.
>
>
> $ git checkout d7942413^
> $ touch install
> $ make -s ARCH=powerpc allnoconfig
> $ make ARCH=powerpc install
> make: 'install' is up to date.
Hmm weird. I did bisect it:
# bad: [d79424137a7312d381d131d707a462440c0e8df9] kbuild: do not update config when running install targets
git bisect bad d79424137a7312d381d131d707a462440c0e8df9
# good: [9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0] kbuild: add .DELETE_ON_ERROR special target
git bisect good 9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0
# first bad commit: [d79424137a7312d381d131d707a462440c0e8df9] kbuild: do not update config when running install targets
But you're right. I must have messed something up while bisecting.
Sorry for the noise.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-17 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 5:14 install is no longer PHONY? Michael Ellerman
2020-02-13 16:32 ` Masahiro Yamada
2020-02-17 10:28 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).