linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sachi King <nakato@nakato.io>, Maximilian Luz <luzmaximilian@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	David Laight <David.Laight@aculab.com>,
	"x86\@kernel.org" <x86@kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sasha Levin <sashal@kernel.org>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] x86/i8259: Work around buggy legacy PIC
Date: Tue, 18 May 2021 17:45:52 +0200	[thread overview]
Message-ID: <87a6osdozz.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1952705.8WFvOeMrJb@yuki>

Sachi,

On Wed, May 19 2021 at 05:58, Sachi King wrote:
> On Tuesday, May 18, 2021 9:27:02 AM AEST Thomas Gleixner wrote:
>> On Mon, May 17 2021 at 21:25, Maximilian Luz wrote:
>> > On 5/17/21 8:40 PM, Thomas Gleixner wrote:
>> >> Can you please add "apic=verbose" to the kernel command line and provide
>> >> full dmesg output for a kernel w/o your patch and one with your patch
>> >> applied?
>
> I've linked to a dmesg with "apic=verbose" below with the irq 7 override hack 
> applied.  Would you still like a copy without either of these patches
> applied?

No, that's pretty conclusive.

> What's the convention for including a dmesg on the mailing list?  I've 
> included the copy via gist as pasting it into email seems incorrect, but 
> that's also probably not the correct convention.

That's fine.

>> Sachi, can you please try the hack below to confirm the above?
>>
>> It's not meant to be a solution, but it's the most trivial way to
>> validate this.
>
> I've applied that patch and the GPIO driver loads and functions.

It's exactly what I expected. So now for a proper solution. After
talking to Raphael it seems something like that quirk is the best option
we have. I'll try to come up with something less horrible. There is some
other minor issue I noticed, which I need to look at as well.

Thanks for digging into this and for testing!

       tglx


  reply	other threads:[~2021-05-18 15:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 21:04 [PATCH] x86/i8259: Work around buggy legacy PIC Maximilian Luz
2021-05-13  8:10 ` David Laight
2021-05-13 10:11   ` Maximilian Luz
2021-05-13 10:36     ` David Laight
2021-05-14 13:01       ` Thomas Gleixner
2021-05-14 13:13         ` David Laight
2021-05-14 16:19           ` Ingo Molnar
2021-05-14 19:41       ` Sachi King
2021-05-14 10:51         ` David Laight
2021-05-14 11:58         ` Maximilian Luz
2021-05-14 17:32           ` Thomas Gleixner
2021-05-14 17:35             ` H. Peter Anvin
2021-05-14 22:47               ` Maximilian Luz
2021-05-17 18:40                 ` Thomas Gleixner
2021-05-17 19:25                   ` Maximilian Luz
2021-05-17 23:27                     ` Thomas Gleixner
2021-05-18  8:28                       ` Andy Shevchenko
2021-05-18 19:58                       ` Sachi King
2021-05-18 15:45                         ` Thomas Gleixner [this message]
2021-05-14 13:44     ` Thomas Gleixner
2021-05-14 16:12       ` David Laight
2021-05-14 17:28         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6osdozz.ffs@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=David.Laight@aculab.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=mingo@redhat.com \
    --cc=nakato@nakato.io \
    --cc=rafael@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).