From: David Laight <David.Laight@ACULAB.COM>
To: 'Thomas Gleixner' <email@example.com>,
Maximilian Luz <firstname.lastname@example.org>,
Ingo Molnar <email@example.com>, Borislav Petkov <firstname.lastname@example.org>
Cc: "H. Peter Anvin" <email@example.com>, Sachi King <firstname.lastname@example.org>,
Subject: RE: [PATCH] x86/i8259: Work around buggy legacy PIC
Date: Fri, 14 May 2021 16:12:01 +0000 [thread overview]
Message-ID: <f0f52e319c06462ea0b5fbba827df9e0@AcuMS.aculab.com> (raw)
From: Thomas Gleixner
> Sent: 14 May 2021 14:45
> On Thu, May 13 2021 at 12:11, Maximilian Luz wrote:
> > And lastly, if that's any help at all: The PIC device is described in
> > ACPI in . The Surface Laptop 3 also has an AMD CPU (although a prior
> > generation) and has the PIC described in the exact same way (can also be
> > found in that repository), but doesn't exhibit that behavior (and
> > doesn't show the "Using NULL legacy PIC" line). I expect there's not
> > much you can change to that definition so that's probably irrelevant
> > here.
> > Again, I don't really know anything about these devices, so my guess
> > would be bad hardware revision or bad firmware revision. All I know is
> > that retrying seems to "fix" it.
> That might be a a power optimization thing.
> Except for older systems the PIC is not really required for IOAPiC to
> work. But there is some historical code which makes assumptions. We can
> change that, but that needs some careful thoughts.
A more interesting probe would be:
- Write some value to register 1 - the mask.
- Write 9 to register zero (selects interrupt in service register).
- Read register 0 - should be zero since we aren't in as ISR.
- Read register 1 - should get the mask back.
You can also write 8 to register 0, reads then return the pending interrupts.
Their might be pending interrupts - so that value can't be checked.
But if reads start returning the last written value you might only
have capacitors on the data bus.
The required initialisation registers are pretty fixed for the PC hardware.
But finding the values requires a bit of work.
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-05-14 16:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 21:04 [PATCH] x86/i8259: Work around buggy legacy PIC Maximilian Luz
2021-05-13 8:10 ` David Laight
2021-05-13 10:11 ` Maximilian Luz
2021-05-13 10:36 ` David Laight
2021-05-14 13:01 ` Thomas Gleixner
2021-05-14 13:13 ` David Laight
2021-05-14 16:19 ` Ingo Molnar
2021-05-14 19:41 ` Sachi King
2021-05-14 10:51 ` David Laight
2021-05-14 11:58 ` Maximilian Luz
2021-05-14 17:32 ` Thomas Gleixner
2021-05-14 17:35 ` H. Peter Anvin
2021-05-14 22:47 ` Maximilian Luz
2021-05-17 18:40 ` Thomas Gleixner
2021-05-17 19:25 ` Maximilian Luz
2021-05-17 23:27 ` Thomas Gleixner
2021-05-18 8:28 ` Andy Shevchenko
2021-05-18 19:58 ` Sachi King
2021-05-18 15:45 ` Thomas Gleixner
2021-05-14 13:44 ` Thomas Gleixner
2021-05-14 16:12 ` David Laight [this message]
2021-05-14 17:28 ` H. Peter Anvin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).