* [PATCH] pinctrl: bcm: pinctrl-nsp-gpio: Fix setting GPIO as output
@ 2020-11-16 23:37 Mark Tomlinson
2020-11-16 23:55 ` Ray Jui
0 siblings, 1 reply; 2+ messages in thread
From: Mark Tomlinson @ 2020-11-16 23:37 UTC (permalink / raw)
To: rjui, sbranden; +Cc: linux-gpio, linux-kernel, Mark Tomlinson
When setting a GPIO pin to an output, it is important to set the value
correctly before enabling the output so that a glitch is not seen on the
pin. This glitch may be very short, but can be important if this is a
reset signal.
Fixes: 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
---
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index a00a42a61a90..942f04ca4868 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -289,8 +289,8 @@ static int nsp_gpio_direction_output(struct gpio_chip *gc, unsigned gpio,
unsigned long flags;
raw_spin_lock_irqsave(&chip->lock, flags);
- nsp_set_bit(chip, REG, NSP_GPIO_OUT_EN, gpio, true);
nsp_set_bit(chip, REG, NSP_GPIO_DATA_OUT, gpio, !!(val));
+ nsp_set_bit(chip, REG, NSP_GPIO_OUT_EN, gpio, true);
raw_spin_unlock_irqrestore(&chip->lock, flags);
dev_dbg(chip->dev, "gpio:%u set output, value:%d\n", gpio, val);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: bcm: pinctrl-nsp-gpio: Fix setting GPIO as output
2020-11-16 23:37 [PATCH] pinctrl: bcm: pinctrl-nsp-gpio: Fix setting GPIO as output Mark Tomlinson
@ 2020-11-16 23:55 ` Ray Jui
0 siblings, 0 replies; 2+ messages in thread
From: Ray Jui @ 2020-11-16 23:55 UTC (permalink / raw)
To: Mark Tomlinson, rjui, sbranden; +Cc: linux-gpio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On 11/16/2020 3:37 PM, Mark Tomlinson wrote:
> When setting a GPIO pin to an output, it is important to set the value
> correctly before enabling the output so that a glitch is not seen on the
> pin. This glitch may be very short, but can be important if this is a
> reset signal.
>
> Fixes: 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
> Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> ---
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
> index a00a42a61a90..942f04ca4868 100644
> --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
> @@ -289,8 +289,8 @@ static int nsp_gpio_direction_output(struct gpio_chip *gc, unsigned gpio,
> unsigned long flags;
>
> raw_spin_lock_irqsave(&chip->lock, flags);
> - nsp_set_bit(chip, REG, NSP_GPIO_OUT_EN, gpio, true);
> nsp_set_bit(chip, REG, NSP_GPIO_DATA_OUT, gpio, !!(val));
> + nsp_set_bit(chip, REG, NSP_GPIO_OUT_EN, gpio, true);
> raw_spin_unlock_irqrestore(&chip->lock, flags);
>
> dev_dbg(chip->dev, "gpio:%u set output, value:%d\n", gpio, val);
>
The fix looks good to me. Thanks!
Acked-by: Ray Jui <ray.jui@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4151 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 23:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 23:37 [PATCH] pinctrl: bcm: pinctrl-nsp-gpio: Fix setting GPIO as output Mark Tomlinson
2020-11-16 23:55 ` Ray Jui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).