* [PATCH] :ssb sprom.c: Fixed block comments coding style issues
@ 2020-04-24 17:50 John Oldman
2020-04-24 23:05 ` Michael Büsch
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: John Oldman @ 2020-04-24 17:50 UTC (permalink / raw)
To: m; +Cc: linux-wireless, linux-kernel, John Oldman
Fixed coding style issues
Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
---
drivers/ssb/sprom.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
index 52d2e0f33be7..42d620cee8a9 100644
--- a/drivers/ssb/sprom.c
+++ b/drivers/ssb/sprom.c
@@ -78,7 +78,8 @@ ssize_t ssb_attr_sprom_show(struct ssb_bus *bus, char *buf,
/* Use interruptible locking, as the SPROM write might
* be holding the lock for several seconds. So allow userspace
- * to cancel operation. */
+ * to cancel operation.
+ */
err = -ERESTARTSYS;
if (mutex_lock_interruptible(&bus->sprom_mutex))
goto out_kfree;
@@ -121,7 +122,8 @@ ssize_t ssb_attr_sprom_store(struct ssb_bus *bus,
/* Use interruptible locking, as the SPROM write might
* be holding the lock for several seconds. So allow userspace
- * to cancel operation. */
+ * to cancel operation.
+ */
err = -ERESTARTSYS;
if (mutex_lock_interruptible(&bus->sprom_mutex))
goto out_kfree;
@@ -188,9 +190,11 @@ int ssb_fill_sprom_with_fallback(struct ssb_bus *bus, struct ssb_sprom *out)
bool ssb_is_sprom_available(struct ssb_bus *bus)
{
/* status register only exists on chipcomon rev >= 11 and we need check
- for >= 31 only */
+ * for >= 31 only
+ */
/* this routine differs from specs as we do not access SPROM directly
- on PCMCIA */
+ * on PCMCIA
+ */
if (bus->bustype == SSB_BUSTYPE_PCI &&
bus->chipco.dev && /* can be unavailable! */
bus->chipco.dev->id.revision >= 31)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] :ssb sprom.c: Fixed block comments coding style issues
2020-04-24 17:50 [PATCH] :ssb sprom.c: Fixed block comments coding style issues John Oldman
@ 2020-04-24 23:05 ` Michael Büsch
2020-04-27 5:26 ` Kalle Valo
2020-04-28 9:01 ` [PATCH] ssb: sprom: fix " Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Michael Büsch @ 2020-04-24 23:05 UTC (permalink / raw)
To: John Oldman; +Cc: linux-wireless, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
On Fri, 24 Apr 2020 18:50:43 +0100
John Oldman <john.oldman@polehill.co.uk> wrote:
> Fixed coding style issues
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> drivers/ssb/sprom.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index 52d2e0f33be7..42d620cee8a9 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -78,7 +78,8 @@ ssize_t ssb_attr_sprom_show(struct ssb_bus *bus, char *buf,
>
> /* Use interruptible locking, as the SPROM write might
> * be holding the lock for several seconds. So allow userspace
> - * to cancel operation. */
> + * to cancel operation.
> + */
> err = -ERESTARTSYS;
> if (mutex_lock_interruptible(&bus->sprom_mutex))
> goto out_kfree;
> @@ -121,7 +122,8 @@ ssize_t ssb_attr_sprom_store(struct ssb_bus *bus,
>
> /* Use interruptible locking, as the SPROM write might
> * be holding the lock for several seconds. So allow userspace
> - * to cancel operation. */
> + * to cancel operation.
> + */
> err = -ERESTARTSYS;
> if (mutex_lock_interruptible(&bus->sprom_mutex))
> goto out_kfree;
> @@ -188,9 +190,11 @@ int ssb_fill_sprom_with_fallback(struct ssb_bus *bus, struct ssb_sprom *out)
> bool ssb_is_sprom_available(struct ssb_bus *bus)
> {
> /* status register only exists on chipcomon rev >= 11 and we need check
> - for >= 31 only */
> + * for >= 31 only
> + */
> /* this routine differs from specs as we do not access SPROM directly
> - on PCMCIA */
> + * on PCMCIA
> + */
> if (bus->bustype == SSB_BUSTYPE_PCI &&
> bus->chipco.dev && /* can be unavailable! */
> bus->chipco.dev->id.revision >= 31)
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] :ssb sprom.c: Fixed block comments coding style issues
2020-04-24 17:50 [PATCH] :ssb sprom.c: Fixed block comments coding style issues John Oldman
2020-04-24 23:05 ` Michael Büsch
@ 2020-04-27 5:26 ` Kalle Valo
2020-04-28 9:01 ` [PATCH] ssb: sprom: fix " Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-04-27 5:26 UTC (permalink / raw)
To: John Oldman; +Cc: m, linux-wireless, linux-kernel
John Oldman <john.oldman@polehill.co.uk> writes:
> Fixed coding style issues
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> drivers/ssb/sprom.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
The title prefix should be "ssb: ", I'll fix it during commit.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ssb: sprom: fix block comments coding style issues
2020-04-24 17:50 [PATCH] :ssb sprom.c: Fixed block comments coding style issues John Oldman
2020-04-24 23:05 ` Michael Büsch
2020-04-27 5:26 ` Kalle Valo
@ 2020-04-28 9:01 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-04-28 9:01 UTC (permalink / raw)
To: John Oldman; +Cc: m, linux-wireless, linux-kernel, John Oldman
John Oldman <john.oldman@polehill.co.uk> wrote:
> Fixed coding style issues
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
Patch applied to wireless-drivers-next.git, thanks.
2aad9f81d34c ssb: sprom: fix block comments coding style issues
--
https://patchwork.kernel.org/patch/11509841/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-28 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 17:50 [PATCH] :ssb sprom.c: Fixed block comments coding style issues John Oldman
2020-04-24 23:05 ` Michael Büsch
2020-04-27 5:26 ` Kalle Valo
2020-04-28 9:01 ` [PATCH] ssb: sprom: fix " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).