[PATCH 0/5] Fix Cygnus, NS2, Stingray interrupt type

[PATCH 0/5] Fix Cygnus, NS2, Stingray interrupt type

[Ray Jui]

This patch series fixes incorrect interrupt types for I2C and PCIe in DT
for Broadcom Cygnus, NS2, and Stingray SoCs

This patch series is based off v4.17 and is available on GIHUB:
repo: https://github.com/Broadcom/arm64-linux.git
branch: cygnus-ns2-dt-irq-type-fix-v1

Ray Jui (5):
  ARM: dts: cygnus: Fix I2C controller interrupt type
  ARM: dts: cygnus: Fix PCIe controller interrupt type
  ARM64: dts: ns2: Fix I2C controller interrupt type
  ARM64: dts: ns2: Fix PCIe controller interrupt type
  ARM64: dts: Stingray: Fix I2C controller interrupt type

 arch/arm/boot/dts/bcm-cygnus.dtsi                  | 24 +++++++++++-----------
 arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi   |  8 ++++----
 .../arm64/boot/dts/broadcom/stingray/stingray.dtsi |  4 ++--
 3 files changed, 18 insertions(+), 18 deletions(-)

-- 
2.1.4

[PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type

[Ray Jui]

Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
Cygnus SoC

Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom Cygnus")
Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi bus")
Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 9fe4f5a..835a6f7 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -216,7 +216,7 @@
 			reg = <0x18008000 0x100>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <100000>;
 			status = "disabled";
 		};
@@ -245,7 +245,7 @@
 			reg = <0x1800b000 0x100>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			interrupts = <GIC_SPI 86 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <100000>;
 			status = "disabled";
 		};
-- 
2.1.4

Re: [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type

[Florian Fainelli]

On 06/12/2018 01:21 PM, Ray Jui wrote:
> Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
> Cygnus SoC
> 
> Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom Cygnus")

This appears to be the only one that is truly needed here, the two
others below probably just moved things around but the offending commit
was already introduced in the above commit.

> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi bus")
> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
> 

There is no need for an extra line between the last Fixes: tag and your
Signed-off-by tag.

> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 9fe4f5a..835a6f7 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -216,7 +216,7 @@
>  			reg = <0x18008000 0x100>;
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -			interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>;
> +			interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-frequency = <100000>;
>  			status = "disabled";
>  		};
> @@ -245,7 +245,7 @@
>  			reg = <0x1800b000 0x100>;
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -			interrupts = <GIC_SPI 86 IRQ_TYPE_NONE>;
> +			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-frequency = <100000>;
>  			status = "disabled";
>  		};
> 


-- 
Florian

Re: [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type

[Ray Jui]

On 6/13/2018 12:49 PM, Florian Fainelli wrote:
> On 06/12/2018 01:21 PM, Ray Jui wrote:
>> Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
>> Cygnus SoC
>>
>> Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom Cygnus")
> 
> This appears to be the only one that is truly needed here, the two
> others below probably just moved things around but the offending commit
> was already introduced in the above commit.
> 

Okay thanks. Will remove the other two "Fixes" below.

>> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi bus")
>> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
>>
> 
> There is no need for an extra line between the last Fixes: tag and your
> Signed-off-by tag.
> 

Got it, thanks!

Ray

Re: [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type

[Florian Fainelli]

On 06/13/2018 04:32 PM, Ray Jui wrote:
> 
> 
> On 6/13/2018 12:49 PM, Florian Fainelli wrote:
>> On 06/12/2018 01:21 PM, Ray Jui wrote:
>>> Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
>>> Cygnus SoC
>>>
>>> Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom
>>> Cygnus")
>>
>> This appears to be the only one that is truly needed here, the two
>> others below probably just moved things around but the offending commit
>> was already introduced in the above commit.
>>
> 
> Okay thanks. Will remove the other two "Fixes" below.

I can take care of that while applying the patches, no need for you to
resubmit, for the whole series I mean.

> 
>>> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi
>>> bus")
>>> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
>>>
>>
>> There is no need for an extra line between the last Fixes: tag and your
>> Signed-off-by tag.
>>
> 
> Got it, thanks!

And that as well.
-- 
Florian

Re: [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type

[Ray Jui]

On 6/13/2018 4:33 PM, Florian Fainelli wrote:
> On 06/13/2018 04:32 PM, Ray Jui wrote:
>>
>>
>> On 6/13/2018 12:49 PM, Florian Fainelli wrote:
>>> On 06/12/2018 01:21 PM, Ray Jui wrote:
>>>> Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
>>>> Cygnus SoC
>>>>
>>>> Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom
>>>> Cygnus")
>>>
>>> This appears to be the only one that is truly needed here, the two
>>> others below probably just moved things around but the offending commit
>>> was already introduced in the above commit.
>>>
>>
>> Okay thanks. Will remove the other two "Fixes" below.
> 
> I can take care of that while applying the patches, no need for you to
> resubmit, for the whole series I mean.
> 

Excellent! Much appreciated!

>>
>>>> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi
>>>> bus")
>>>> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
>>>>
>>>
>>> There is no need for an extra line between the last Fixes: tag and your
>>> Signed-off-by tag.
>>>
>>
>> Got it, thanks!
> 
> And that as well.
> 

Thanks again!

Ray

[PATCH 2/5] ARM: dts: cygnus: Fix PCIe controller interrupt type

[Ray Jui]

Fix PCIe controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
Cygnus SoC

Fixes: cd590b50a936 ("ARM: dts: enable PCIe support for Cygnus")
Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi
bus")
Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
Fixes: f6b889358a82 ("ARM: dts: Enable MSI support for Broadcom Cygnus")

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 835a6f7..2c4df2d 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -256,7 +256,7 @@
 
 			#interrupt-cells = <1>;
 			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>;
+			interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
 
 			linux,pci-domain = <0>;
 
@@ -278,10 +278,10 @@
 				compatible = "brcm,iproc-msi";
 				msi-controller;
 				interrupt-parent = <&gic>;
-				interrupts = <GIC_SPI 96 IRQ_TYPE_NONE>,
-					     <GIC_SPI 97 IRQ_TYPE_NONE>,
-					     <GIC_SPI 98 IRQ_TYPE_NONE>,
-					     <GIC_SPI 99 IRQ_TYPE_NONE>;
+				interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
 			};
 		};
 
@@ -291,7 +291,7 @@
 
 			#interrupt-cells = <1>;
 			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>;
+			interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
 
 			linux,pci-domain = <1>;
 
@@ -313,10 +313,10 @@
 				compatible = "brcm,iproc-msi";
 				msi-controller;
 				interrupt-parent = <&gic>;
-				interrupts = <GIC_SPI 102 IRQ_TYPE_NONE>,
-					     <GIC_SPI 103 IRQ_TYPE_NONE>,
-					     <GIC_SPI 104 IRQ_TYPE_NONE>,
-					     <GIC_SPI 105 IRQ_TYPE_NONE>;
+				interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
 			};
 		};
 
-- 
2.1.4

Re: [PATCH 2/5] ARM: dts: cygnus: Fix PCIe controller interrupt type

[Florian Fainelli]

On 06/12/2018 01:21 PM, Ray Jui wrote:
> Fix PCIe controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
> Cygnus SoC
> 
> Fixes: cd590b50a936 ("ARM: dts: enable PCIe support for Cygnus")

This one is valid

> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi
> bus")
> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
> Fixes: f6b889358a82 ("ARM: dts: Enable MSI support for Broadcom Cygnus")

And this one too, but the two others, I would probably drop them so we
can get the backports to be possibly applicable as far as when these two
commits can be resolved, does that work?

> 
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 835a6f7..2c4df2d 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -256,7 +256,7 @@
>  
>  			#interrupt-cells = <1>;
>  			interrupt-map-mask = <0 0 0 0>;
> -			interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>;
> +			interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>  
>  			linux,pci-domain = <0>;
>  
> @@ -278,10 +278,10 @@
>  				compatible = "brcm,iproc-msi";
>  				msi-controller;
>  				interrupt-parent = <&gic>;
> -				interrupts = <GIC_SPI 96 IRQ_TYPE_NONE>,
> -					     <GIC_SPI 97 IRQ_TYPE_NONE>,
> -					     <GIC_SPI 98 IRQ_TYPE_NONE>,
> -					     <GIC_SPI 99 IRQ_TYPE_NONE>;
> +				interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
>  			};
>  		};
>  
> @@ -291,7 +291,7 @@
>  
>  			#interrupt-cells = <1>;
>  			interrupt-map-mask = <0 0 0 0>;
> -			interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>;
> +			interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>  
>  			linux,pci-domain = <1>;
>  
> @@ -313,10 +313,10 @@
>  				compatible = "brcm,iproc-msi";
>  				msi-controller;
>  				interrupt-parent = <&gic>;
> -				interrupts = <GIC_SPI 102 IRQ_TYPE_NONE>,
> -					     <GIC_SPI 103 IRQ_TYPE_NONE>,
> -					     <GIC_SPI 104 IRQ_TYPE_NONE>,
> -					     <GIC_SPI 105 IRQ_TYPE_NONE>;
> +				interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
> +					     <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
>  			};
>  		};
>  
> 


-- 
Florian

Re: [PATCH 2/5] ARM: dts: cygnus: Fix PCIe controller interrupt type

[Ray Jui]

On 6/13/2018 12:50 PM, Florian Fainelli wrote:
> On 06/12/2018 01:21 PM, Ray Jui wrote:
>> Fix PCIe controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
>> Cygnus SoC
>>
>> Fixes: cd590b50a936 ("ARM: dts: enable PCIe support for Cygnus")
> 
> This one is valid
> 
>> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi
>> bus")
>> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
>> Fixes: f6b889358a82 ("ARM: dts: Enable MSI support for Broadcom Cygnus")
> 
> And this one too, but the two others, I would probably drop them so we
> can get the backports to be possibly applicable as far as when these two
> commits can be resolved, does that work?
> 

Yah that will work. Will make the change. Thanks.

[PATCH 3/5] ARM64: dts: ns2: Fix I2C controller interrupt type

[Ray Jui]

Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for
Broadcom NS2 SoC

Fixes: 7ac674e8df7a ("arm64: dts: Add I2C nodes for NS2")
Fixes: 63a913c157f5 ("arm64: dts: move ns2 into northstar2 directory")

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
 arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
index 4a2a6af..c0e4896 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
@@ -566,7 +566,7 @@
 			reg = <0x66080000 0x100>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			interrupts = <GIC_SPI 394 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 394 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <100000>;
 			status = "disabled";
 		};
@@ -594,7 +594,7 @@
 			reg = <0x660b0000 0x100>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			interrupts = <GIC_SPI 395 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <100000>;
 			status = "disabled";
 		};
-- 
2.1.4

[PATCH 4/5] ARM64: dts: ns2: Fix PCIe controller interrupt type

[Ray Jui]

Fix PCIe controller interrupt to use IRQ_TYPE_LEVEL_HIGH for
Broadcom NS2 SoC

Fixes: fd5e5dd56a2f ("arm64: dts: Add PCIe0 and PCIe4 DT nodes for NS2")
Fixes: 63a913c157f5 ("arm64: dts: move ns2 into northstar2 directory")

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
 arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
index c0e4896..4057197 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
@@ -118,7 +118,7 @@
 
 		#interrupt-cells = <1>;
 		interrupt-map-mask = <0 0 0 0>;
-		interrupt-map = <0 0 0 0 &gic 0 GIC_SPI 281 IRQ_TYPE_NONE>;
+		interrupt-map = <0 0 0 0 &gic 0 GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>;
 
 		linux,pci-domain = <0>;
 
@@ -149,7 +149,7 @@
 
 		#interrupt-cells = <1>;
 		interrupt-map-mask = <0 0 0 0>;
-		interrupt-map = <0 0 0 0 &gic 0 GIC_SPI 305 IRQ_TYPE_NONE>;
+		interrupt-map = <0 0 0 0 &gic 0 GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
 
 		linux,pci-domain = <4>;
 
-- 
2.1.4

[PATCH 5/5] ARM64: dts: Stingray: Fix I2C controller interrupt type

[Ray Jui]

Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for
Broadcom Stingray SoC

Fixes: 1256ea18875d ("arm64: dts: Add I2C DT nodes for Stingray SoC")

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
index 99aaff0..b203152 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
@@ -409,7 +409,7 @@
 			reg = <0x000b0000 0x100>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			interrupts = <GIC_SPI 177 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <100000>;
 			status = "disabled";
 		};
@@ -453,7 +453,7 @@
 			reg = <0x000e0000 0x100>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-			interrupts = <GIC_SPI 178 IRQ_TYPE_NONE>;
+			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <100000>;
 			status = "disabled";
 		};
-- 
2.1.4

Re: [PATCH 0/5] Fix Cygnus, NS2, Stingray interrupt type

[Florian Fainelli]

On 06/12/2018 01:21 PM, Ray Jui wrote:
> This patch series fixes incorrect interrupt types for I2C and PCIe in DT
> for Broadcom Cygnus, NS2, and Stingray SoCs
> 
> This patch series is based off v4.17 and is available on GIHUB:
> repo: https://github.com/Broadcom/arm64-linux.git
> branch: cygnus-ns2-dt-irq-type-fix-v1

Series applied to:

- 1&2: devicetree/fixes
- 3-5: devicetree-arm64/fixes

Thanks Ray.
-- 
Florian