* [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c
@ 2017-12-21 18:46 David Lechner
2017-12-22 11:50 ` Hans de Goede
2017-12-23 19:11 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: David Lechner @ 2017-12-21 18:46 UTC (permalink / raw)
To: dri-devel
Cc: David Lechner, Hans de Goede, Daniel Vetter, Gustavo Padovan,
Sean Paul, David Airlie, linux-kernel
drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
Add panel orientation quirks, v6.") taints the kernel when compiled as a
module. Fix this by adding MODULE_LICENSE().
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 901a4e9..1f2af70 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -9,6 +9,7 @@
*/
#include <linux/dmi.h>
+#include <linux/module.h>
#include <drm/drm_connector.h>
#ifdef CONFIG_DMI
@@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
#endif
+
+MODULE_LICENSE("Dual MIT/GPL");
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c
2017-12-21 18:46 [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c David Lechner
@ 2017-12-22 11:50 ` Hans de Goede
2017-12-23 19:11 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2017-12-22 11:50 UTC (permalink / raw)
To: David Lechner, dri-devel
Cc: Daniel Vetter, Gustavo Padovan, Sean Paul, David Airlie, linux-kernel
Hi,
On 21-12-17 19:46, David Lechner wrote:
> drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
> Add panel orientation quirks, v6.") taints the kernel when compiled as a
> module. Fix this by adding MODULE_LICENSE().
>
> Signed-off-by: David Lechner <david@lechnology.com>
Thank you for taking care of this, looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 901a4e9..1f2af70 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -9,6 +9,7 @@
> */
>
> #include <linux/dmi.h>
> +#include <linux/module.h>
> #include <drm/drm_connector.h>
>
> #ifdef CONFIG_DMI
> @@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
> EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
>
> #endif
> +
> +MODULE_LICENSE("Dual MIT/GPL");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c
2017-12-21 18:46 [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c David Lechner
2017-12-22 11:50 ` Hans de Goede
@ 2017-12-23 19:11 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2017-12-23 19:11 UTC (permalink / raw)
To: David Lechner, dri-devel
Cc: Hans de Goede, Daniel Vetter, Gustavo Padovan, Sean Paul,
David Airlie, linux-kernel
Hi,
On 21-12-17 19:46, David Lechner wrote:
> drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
> Add panel orientation quirks, v6.") taints the kernel when compiled as a
> module. Fix this by adding MODULE_LICENSE().
>
> Signed-off-by: David Lechner <david@lechnology.com>
Thank you, I've pushed this patch to drm-misc-next.
Regards,
Hans
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 901a4e9..1f2af70 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -9,6 +9,7 @@
> */
>
> #include <linux/dmi.h>
> +#include <linux/module.h>
> #include <drm/drm_connector.h>
>
> #ifdef CONFIG_DMI
> @@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
> EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
>
> #endif
> +
> +MODULE_LICENSE("Dual MIT/GPL");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-23 19:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-21 18:46 [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c David Lechner
2017-12-22 11:50 ` Hans de Goede
2017-12-23 19:11 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).