[PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

[PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

[David Lechner]

drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
Add panel orientation quirks, v6.") taints the kernel when compiled as a
module. Fix this by adding MODULE_LICENSE().

Signed-off-by: David Lechner <david@lechnology.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 901a4e9..1f2af70 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -9,6 +9,7 @@
  */
 
 #include <linux/dmi.h>
+#include <linux/module.h>
 #include <drm/drm_connector.h>
 
 #ifdef CONFIG_DMI
@@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
 EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
 
 #endif
+
+MODULE_LICENSE("Dual MIT/GPL");
-- 
2.7.4

Re: [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

[Hans de Goede]

Hi,

On 21-12-17 19:46, David Lechner wrote:
> drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
> Add panel orientation quirks, v6.") taints the kernel when compiled as a
> module. Fix this by adding MODULE_LICENSE().
> 
> Signed-off-by: David Lechner <david@lechnology.com>

Thank you for taking care of this, looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 901a4e9..1f2af70 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -9,6 +9,7 @@
>    */
>   
>   #include <linux/dmi.h>
> +#include <linux/module.h>
>   #include <drm/drm_connector.h>
>   
>   #ifdef CONFIG_DMI
> @@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
>   EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
>   
>   #endif
> +
> +MODULE_LICENSE("Dual MIT/GPL");
> 

Re: [PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

[Hans de Goede]

Hi,

On 21-12-17 19:46, David Lechner wrote:
> drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
> Add panel orientation quirks, v6.") taints the kernel when compiled as a
> module. Fix this by adding MODULE_LICENSE().
> 
> Signed-off-by: David Lechner <david@lechnology.com>

Thank you, I've pushed this patch to drm-misc-next.

Regards,

Hans


> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 901a4e9..1f2af70 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -9,6 +9,7 @@
>    */
>   
>   #include <linux/dmi.h>
> +#include <linux/module.h>
>   #include <drm/drm_connector.h>
>   
>   #ifdef CONFIG_DMI
> @@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
>   EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
>   
>   #endif
> +
> +MODULE_LICENSE("Dual MIT/GPL");
>