* [PATCH 0/2] clk: bcm63xx-gate: add BCM6318 support
@ 2020-06-09 11:30 Álvaro Fernández Rojas
2020-06-09 11:30 ` [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-09 11:30 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, f.fainelli, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Cc: Álvaro Fernández Rojas
Add support for the gated clock controllers found on the BCM6318.
Álvaro Fernández Rojas (2):
dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
clk: bcm63xx-gate: add BCM6318 support
.../bindings/clock/brcm,bcm63xx-clocks.txt | 2 +
drivers/clk/bcm/clk-bcm63xx-gate.c | 44 +++++++++++++++++++
2 files changed, 46 insertions(+)
--
2.26.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
2020-06-09 11:30 [PATCH 0/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
@ 2020-06-09 11:30 ` Álvaro Fernández Rojas
2020-06-10 2:23 ` Florian Fainelli
2020-06-09 11:30 ` [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
2 siblings, 1 reply; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-09 11:30 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, f.fainelli, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Cc: Álvaro Fernández Rojas
Add BCM6318 to the binding documentation for the gated clock controllers found
on BCM63xx SoCs.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt b/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt
index 3041657e2f96..3e7ca5530775 100644
--- a/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt
+++ b/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt
@@ -3,6 +3,8 @@ Gated Clock Controller Bindings for MIPS based BCM63XX SoCs
Required properties:
- compatible: must be one of:
"brcm,bcm3368-clocks"
+ "brcm,bcm6318-clocks"
+ "brcm,bcm6318-ubus-clocks"
"brcm,bcm6328-clocks"
"brcm,bcm6358-clocks"
"brcm,bcm6362-clocks"
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-09 11:30 [PATCH 0/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-09 11:30 ` [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
@ 2020-06-09 11:30 ` Álvaro Fernández Rojas
2020-06-10 2:27 ` Florian Fainelli
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
2 siblings, 1 reply; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-09 11:30 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, f.fainelli, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Cc: Álvaro Fernández Rojas
Add support for the gated clock controllers found on the BCM6318.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/clk/bcm/clk-bcm63xx-gate.c | 44 ++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/clk/bcm/clk-bcm63xx-gate.c b/drivers/clk/bcm/clk-bcm63xx-gate.c
index 98e884957db8..12394c091d13 100644
--- a/drivers/clk/bcm/clk-bcm63xx-gate.c
+++ b/drivers/clk/bcm/clk-bcm63xx-gate.c
@@ -40,6 +40,48 @@ static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = {
{ },
};
+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
+ { .name = "adsl_asb", .bit = 0, },
+ { .name = "usb_asb", .bit = 1, },
+ { .name = "mips_asb", .bit = 2, },
+ { .name = "pcie_asb", .bit = 3, },
+ { .name = "phymips_asb", .bit = 4, },
+ { .name = "robosw_asb", .bit = 5, },
+ { .name = "sar_asb", .bit = 6, },
+ { .name = "sdr_asb", .bit = 7, },
+ { .name = "swreg_asb", .bit = 8, },
+ { .name = "periph_asb", .bit = 9, },
+ { .name = "cpubus160", .bit = 10, },
+ { .name = "adsl", .bit = 11, },
+ { .name = "sar124", .bit = 12, },
+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
+ { .name = "pcie", .bit = 14, },
+ { .name = "robosw250", .bit = 16, },
+ { .name = "robosw025", .bit = 17, },
+ { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
+ { .name = "usb", .bit = 20, },
+ { .name = "hsspi", .bit = 25, },
+ { .name = "pcie25", .bit = 27, },
+ { .name = "phymips", .bit = 28, },
+ { .name = "afe", .bit = 29, },
+ { .name = "qproc", .bit = 30, },
+ { },
+};
+
+static const struct clk_bcm63xx_table_entry bcm6318_ubus_clocks[] = {
+ { .name = "adsl-ubus", .bit = 0, },
+ { .name = "arb-ubus", .bit = 1, .flags = CLK_IS_CRITICAL, },
+ { .name = "mips-ubus", .bit = 2, .flags = CLK_IS_CRITICAL, },
+ { .name = "pcie-ubus", .bit = 3, },
+ { .name = "periph-ubus", .bit = 4, .flags = CLK_IS_CRITICAL, },
+ { .name = "phymips-ubus", .bit = 5, },
+ { .name = "robosw-ubus", .bit = 6, },
+ { .name = "sar-ubus", .bit = 7, },
+ { .name = "sdr-ubus", .bit = 8, },
+ { .name = "usb-ubus", .bit = 9, },
+ { },
+};
+
static const struct clk_bcm63xx_table_entry bcm6328_clocks[] = {
{ .name = "phy_mips", .bit = 0, },
{ .name = "adsl_qproc", .bit = 1, },
@@ -217,6 +259,8 @@ static int clk_bcm63xx_remove(struct platform_device *pdev)
static const struct of_device_id clk_bcm63xx_dt_ids[] = {
{ .compatible = "brcm,bcm3368-clocks", .data = &bcm3368_clocks, },
+ { .compatible = "brcm,bcm6318-clocks", .data = &bcm6318_clocks, },
+ { .compatible = "brcm,bcm6318-ubus-clocks", .data = &bcm6318_ubus_clocks, },
{ .compatible = "brcm,bcm6328-clocks", .data = &bcm6328_clocks, },
{ .compatible = "brcm,bcm6358-clocks", .data = &bcm6358_clocks, },
{ .compatible = "brcm,bcm6362-clocks", .data = &bcm6362_clocks, },
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
2020-06-09 11:30 ` [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
@ 2020-06-10 2:23 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2020-06-10 2:23 UTC (permalink / raw)
To: Álvaro Fernández Rojas, mturquette, sboyd, robh+dt,
f.fainelli, bcm-kernel-feedback-list, julia.lawall, f4bug,
jonas.gorski, lkp, linux-clk, devicetree, linux-arm-kernel,
linux-kernel
On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> Add BCM6318 to the binding documentation for the gated clock controllers found
> on BCM63xx SoCs.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-09 11:30 ` [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
@ 2020-06-10 2:27 ` Florian Fainelli
2020-06-10 6:12 ` Álvaro Fernández Rojas
0 siblings, 1 reply; 14+ messages in thread
From: Florian Fainelli @ 2020-06-10 2:27 UTC (permalink / raw)
To: Álvaro Fernández Rojas, mturquette, sboyd, robh+dt,
f.fainelli, bcm-kernel-feedback-list, julia.lawall, f4bug,
jonas.gorski, lkp, linux-clk, devicetree, linux-arm-kernel,
linux-kernel
On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
> + { .name = "adsl_asb", .bit = 0, },
> + { .name = "usb_asb", .bit = 1, },
> + { .name = "mips_asb", .bit = 2, },
> + { .name = "pcie_asb", .bit = 3, },
> + { .name = "phymips_asb", .bit = 4, },
> + { .name = "robosw_asb", .bit = 5, },
> + { .name = "sar_asb", .bit = 6, },
> + { .name = "sdr_asb", .bit = 7, },
> + { .name = "swreg_asb", .bit = 8, },
> + { .name = "periph_asb", .bit = 9, },
> + { .name = "cpubus160", .bit = 10, },
> + { .name = "adsl", .bit = 11, },
> + { .name = "sar124", .bit = 12, },
Nit: this should be sar125
> + { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
> + { .name = "pcie", .bit = 14, },
> + { .name = "robosw250", .bit = 16, },
> + { .name = "robosw025", .bit = 17, },
> + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
> + { .name = "usb", .bit = 20, },
This should probably be "usbd" to indicate this is the USB device clock
(not host)
With that fixed:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-10 2:27 ` Florian Fainelli
@ 2020-06-10 6:12 ` Álvaro Fernández Rojas
2020-06-10 8:29 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-10 6:12 UTC (permalink / raw)
To: Florian Fainelli
Cc: mturquette, sboyd, robh+dt, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Hi Florian,
> El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@gmail.com> escribió:
>
>
>
> On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
>> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
>> + { .name = "adsl_asb", .bit = 0, },
>> + { .name = "usb_asb", .bit = 1, },
>> + { .name = "mips_asb", .bit = 2, },
>> + { .name = "pcie_asb", .bit = 3, },
>> + { .name = "phymips_asb", .bit = 4, },
>> + { .name = "robosw_asb", .bit = 5, },
>> + { .name = "sar_asb", .bit = 6, },
>> + { .name = "sdr_asb", .bit = 7, },
>> + { .name = "swreg_asb", .bit = 8, },
>> + { .name = "periph_asb", .bit = 9, },
>> + { .name = "cpubus160", .bit = 10, },
>> + { .name = "adsl", .bit = 11, },
>> + { .name = "sar124", .bit = 12, },
>
> Nit: this should be sar125
Nice catch, I will fix this in v2.
>
>> + { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
>> + { .name = "pcie", .bit = 14, },
>> + { .name = "robosw250", .bit = 16, },
>> + { .name = "robosw025", .bit = 17, },
>> + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
>> + { .name = "usb", .bit = 20, },
>
> This should probably be "usbd" to indicate this is the USB device clock
> (not host)
Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
#define USBD_CLK_EN (1 << 20)
#define USBH_CLK_EN (1 << 20)
>
> With that fixed:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> --
> Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-10 6:12 ` Álvaro Fernández Rojas
@ 2020-06-10 8:29 ` Philippe Mathieu-Daudé
2020-06-10 15:14 ` Florian Fainelli
0 siblings, 1 reply; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-10 8:29 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: Florian Fainelli, Michael Turquette, Stephen Boyd, Rob Herring,
bcm-kernel-feedback-list, Julia Lawall, Jonas Gorski,
kbuild test robot, linux-clk,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM, open list
Hi,
On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas
<noltari@gmail.com> wrote:
>
> Hi Florian,
>
> > El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@gmail.com> escribió:
> >
> >
> >
> > On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> >> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
> >> + { .name = "adsl_asb", .bit = 0, },
> >> + { .name = "usb_asb", .bit = 1, },
> >> + { .name = "mips_asb", .bit = 2, },
> >> + { .name = "pcie_asb", .bit = 3, },
> >> + { .name = "phymips_asb", .bit = 4, },
> >> + { .name = "robosw_asb", .bit = 5, },
> >> + { .name = "sar_asb", .bit = 6, },
> >> + { .name = "sdr_asb", .bit = 7, },
> >> + { .name = "swreg_asb", .bit = 8, },
> >> + { .name = "periph_asb", .bit = 9, },
> >> + { .name = "cpubus160", .bit = 10, },
> >> + { .name = "adsl", .bit = 11, },
> >> + { .name = "sar124", .bit = 12, },
> >
> > Nit: this should be sar125
>
> Nice catch, I will fix this in v2.
>
> >
> >> + { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
> >> + { .name = "pcie", .bit = 14, },
> >> + { .name = "robosw250", .bit = 16, },
> >> + { .name = "robosw025", .bit = 17, },
> >> + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
> >> + { .name = "usb", .bit = 20, },
> >
> > This should probably be "usbd" to indicate this is the USB device clock
> > (not host)
>
> Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
> #define USBD_CLK_EN (1 << 20)
> #define USBH_CLK_EN (1 << 20)
Is there a datasheet to verify that?
>
> >
> > With that fixed:
> >
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> > --
> > Florian
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-09 11:30 [PATCH 0/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-09 11:30 ` [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
2020-06-09 11:30 ` [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
@ 2020-06-10 14:08 ` Álvaro Fernández Rojas
2020-06-10 14:08 ` [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
` (2 more replies)
2 siblings, 3 replies; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-10 14:08 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, f.fainelli, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Cc: Álvaro Fernández Rojas
Add support for the gated clock controllers found on the BCM6318.
Álvaro Fernández Rojas (2):
dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
clk: bcm63xx-gate: add BCM6318 support
.../bindings/clock/brcm,bcm63xx-clocks.txt | 2 +
drivers/clk/bcm/clk-bcm63xx-gate.c | 44 +++++++++++++++++++
2 files changed, 46 insertions(+)
--
2.26.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
@ 2020-06-10 14:08 ` Álvaro Fernández Rojas
2020-06-17 22:23 ` Rob Herring
2020-06-10 14:08 ` [PATCH v2 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-20 0:00 ` [PATCH v2 0/2] " Stephen Boyd
2 siblings, 1 reply; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-10 14:08 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, f.fainelli, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Cc: Álvaro Fernández Rojas
Add BCM6318 to the binding documentation for the gated clock controllers found
on BCM63xx SoCs.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
v2: no changes.
Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt b/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt
index 3041657e2f96..3e7ca5530775 100644
--- a/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt
+++ b/Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt
@@ -3,6 +3,8 @@ Gated Clock Controller Bindings for MIPS based BCM63XX SoCs
Required properties:
- compatible: must be one of:
"brcm,bcm3368-clocks"
+ "brcm,bcm6318-clocks"
+ "brcm,bcm6318-ubus-clocks"
"brcm,bcm6328-clocks"
"brcm,bcm6358-clocks"
"brcm,bcm6362-clocks"
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
2020-06-10 14:08 ` [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
@ 2020-06-10 14:08 ` Álvaro Fernández Rojas
2020-06-20 0:00 ` [PATCH v2 0/2] " Stephen Boyd
2 siblings, 0 replies; 14+ messages in thread
From: Álvaro Fernández Rojas @ 2020-06-10 14:08 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, f.fainelli, bcm-kernel-feedback-list,
julia.lawall, f4bug, jonas.gorski, lkp, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Cc: Álvaro Fernández Rojas
Add support for the gated clock controllers found on the BCM6318.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
v2: correct names for sar125 and usbd
drivers/clk/bcm/clk-bcm63xx-gate.c | 44 ++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/clk/bcm/clk-bcm63xx-gate.c b/drivers/clk/bcm/clk-bcm63xx-gate.c
index 98e884957db8..fce6746cc607 100644
--- a/drivers/clk/bcm/clk-bcm63xx-gate.c
+++ b/drivers/clk/bcm/clk-bcm63xx-gate.c
@@ -40,6 +40,48 @@ static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = {
{ },
};
+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
+ { .name = "adsl_asb", .bit = 0, },
+ { .name = "usb_asb", .bit = 1, },
+ { .name = "mips_asb", .bit = 2, },
+ { .name = "pcie_asb", .bit = 3, },
+ { .name = "phymips_asb", .bit = 4, },
+ { .name = "robosw_asb", .bit = 5, },
+ { .name = "sar_asb", .bit = 6, },
+ { .name = "sdr_asb", .bit = 7, },
+ { .name = "swreg_asb", .bit = 8, },
+ { .name = "periph_asb", .bit = 9, },
+ { .name = "cpubus160", .bit = 10, },
+ { .name = "adsl", .bit = 11, },
+ { .name = "sar125", .bit = 12, },
+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
+ { .name = "pcie", .bit = 14, },
+ { .name = "robosw250", .bit = 16, },
+ { .name = "robosw025", .bit = 17, },
+ { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
+ { .name = "usbd", .bit = 20, },
+ { .name = "hsspi", .bit = 25, },
+ { .name = "pcie25", .bit = 27, },
+ { .name = "phymips", .bit = 28, },
+ { .name = "afe", .bit = 29, },
+ { .name = "qproc", .bit = 30, },
+ { },
+};
+
+static const struct clk_bcm63xx_table_entry bcm6318_ubus_clocks[] = {
+ { .name = "adsl-ubus", .bit = 0, },
+ { .name = "arb-ubus", .bit = 1, .flags = CLK_IS_CRITICAL, },
+ { .name = "mips-ubus", .bit = 2, .flags = CLK_IS_CRITICAL, },
+ { .name = "pcie-ubus", .bit = 3, },
+ { .name = "periph-ubus", .bit = 4, .flags = CLK_IS_CRITICAL, },
+ { .name = "phymips-ubus", .bit = 5, },
+ { .name = "robosw-ubus", .bit = 6, },
+ { .name = "sar-ubus", .bit = 7, },
+ { .name = "sdr-ubus", .bit = 8, },
+ { .name = "usb-ubus", .bit = 9, },
+ { },
+};
+
static const struct clk_bcm63xx_table_entry bcm6328_clocks[] = {
{ .name = "phy_mips", .bit = 0, },
{ .name = "adsl_qproc", .bit = 1, },
@@ -217,6 +259,8 @@ static int clk_bcm63xx_remove(struct platform_device *pdev)
static const struct of_device_id clk_bcm63xx_dt_ids[] = {
{ .compatible = "brcm,bcm3368-clocks", .data = &bcm3368_clocks, },
+ { .compatible = "brcm,bcm6318-clocks", .data = &bcm6318_clocks, },
+ { .compatible = "brcm,bcm6318-ubus-clocks", .data = &bcm6318_ubus_clocks, },
{ .compatible = "brcm,bcm6328-clocks", .data = &bcm6328_clocks, },
{ .compatible = "brcm,bcm6358-clocks", .data = &bcm6358_clocks, },
{ .compatible = "brcm,bcm6362-clocks", .data = &bcm6362_clocks, },
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-10 8:29 ` Philippe Mathieu-Daudé
@ 2020-06-10 15:14 ` Florian Fainelli
2020-06-13 17:53 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 14+ messages in thread
From: Florian Fainelli @ 2020-06-10 15:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Álvaro Fernández Rojas
Cc: Michael Turquette, Stephen Boyd, Rob Herring,
bcm-kernel-feedback-list, Julia Lawall, Jonas Gorski,
kbuild test robot, linux-clk,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM, open list
On 6/10/2020 1:29 AM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas
> <noltari@gmail.com> wrote:
>>
>> Hi Florian,
>>
>>> El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@gmail.com> escribió:
>>>
>>>
>>>
>>> On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
>>>> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
>>>> + { .name = "adsl_asb", .bit = 0, },
>>>> + { .name = "usb_asb", .bit = 1, },
>>>> + { .name = "mips_asb", .bit = 2, },
>>>> + { .name = "pcie_asb", .bit = 3, },
>>>> + { .name = "phymips_asb", .bit = 4, },
>>>> + { .name = "robosw_asb", .bit = 5, },
>>>> + { .name = "sar_asb", .bit = 6, },
>>>> + { .name = "sdr_asb", .bit = 7, },
>>>> + { .name = "swreg_asb", .bit = 8, },
>>>> + { .name = "periph_asb", .bit = 9, },
>>>> + { .name = "cpubus160", .bit = 10, },
>>>> + { .name = "adsl", .bit = 11, },
>>>> + { .name = "sar124", .bit = 12, },
>>>
>>> Nit: this should be sar125
>>
>> Nice catch, I will fix this in v2.
>>
>>>
>>>> + { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
>>>> + { .name = "pcie", .bit = 14, },
>>>> + { .name = "robosw250", .bit = 16, },
>>>> + { .name = "robosw025", .bit = 17, },
>>>> + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
>>>> + { .name = "usb", .bit = 20, },
>>>
>>> This should probably be "usbd" to indicate this is the USB device clock
>>> (not host)
>>
>> Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
>> #define USBD_CLK_EN (1 << 20)
>> #define USBH_CLK_EN (1 << 20)
>
> Is there a datasheet to verify that?
Not a public one, but I can confirm this is correct given the internal
datasheet.
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-10 15:14 ` Florian Fainelli
@ 2020-06-13 17:53 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-13 17:53 UTC (permalink / raw)
To: Florian Fainelli
Cc: Álvaro Fernández Rojas, Michael Turquette,
Stephen Boyd, Rob Herring, bcm-kernel-feedback-list,
Julia Lawall, Jonas Gorski, kbuild test robot, linux-clk,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM, open list
On Wed, Jun 10, 2020 at 5:32 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 6/10/2020 1:29 AM, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas
> > <noltari@gmail.com> wrote:
> >>
> >> Hi Florian,
> >>
> >>> El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@gmail.com> escribió:
> >>>
> >>>
> >>>
> >>> On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> >>>> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
> >>>> + { .name = "adsl_asb", .bit = 0, },
> >>>> + { .name = "usb_asb", .bit = 1, },
> >>>> + { .name = "mips_asb", .bit = 2, },
> >>>> + { .name = "pcie_asb", .bit = 3, },
> >>>> + { .name = "phymips_asb", .bit = 4, },
> >>>> + { .name = "robosw_asb", .bit = 5, },
> >>>> + { .name = "sar_asb", .bit = 6, },
> >>>> + { .name = "sdr_asb", .bit = 7, },
> >>>> + { .name = "swreg_asb", .bit = 8, },
> >>>> + { .name = "periph_asb", .bit = 9, },
> >>>> + { .name = "cpubus160", .bit = 10, },
> >>>> + { .name = "adsl", .bit = 11, },
> >>>> + { .name = "sar124", .bit = 12, },
> >>>
> >>> Nit: this should be sar125
> >>
> >> Nice catch, I will fix this in v2.
> >>
> >>>
> >>>> + { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
> >>>> + { .name = "pcie", .bit = 14, },
> >>>> + { .name = "robosw250", .bit = 16, },
> >>>> + { .name = "robosw025", .bit = 17, },
> >>>> + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
> >>>> + { .name = "usb", .bit = 20, },
> >>>
> >>> This should probably be "usbd" to indicate this is the USB device clock
> >>> (not host)
> >>
> >> Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
> >> #define USBD_CLK_EN (1 << 20)
> >> #define USBH_CLK_EN (1 << 20)
> >
> > Is there a datasheet to verify that?
>
> Not a public one, but I can confirm this is correct given the internal
> datasheet.
OK thank you Florian.
> --
> Florian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
2020-06-10 14:08 ` [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
@ 2020-06-17 22:23 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2020-06-17 22:23 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: lkp, bcm-kernel-feedback-list, linux-clk, mturquette,
linux-kernel, robh+dt, devicetree, julia.lawall, sboyd,
f.fainelli, linux-arm-kernel, f4bug, jonas.gorski
On Wed, 10 Jun 2020 16:08:57 +0200, Álvaro Fernández Rojas wrote:
> Add BCM6318 to the binding documentation for the gated clock controllers found
> on BCM63xx SoCs.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> v2: no changes.
>
> Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] clk: bcm63xx-gate: add BCM6318 support
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
2020-06-10 14:08 ` [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
2020-06-10 14:08 ` [PATCH v2 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
@ 2020-06-20 0:00 ` Stephen Boyd
2 siblings, 0 replies; 14+ messages in thread
From: Stephen Boyd @ 2020-06-20 0:00 UTC (permalink / raw)
To: noltari
Cc: bcm-kernel-feedback-list, devicetree, f.fainelli, f4bug,
jonas.gorski, julia.lawall, linux-arm-kernel, linux-clk,
linux-kernel, lkp, mturquette, robh+dt
> Add support for the gated clock controllers found on the BCM6318.
>
> Álvaro Fernández Rojas (2):
> dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
> clk: bcm63xx-gate: add BCM6318 support
>
> .../bindings/clock/brcm,bcm63xx-clocks.txt | 2 +
> drivers/clk/bcm/clk-bcm63xx-gate.c | 44 +++++++++++++++++++
> 2 files changed, 46 insertions(+)
>
Sorry please don't send these in reply to the original patch series. I
have a hard time finding new patch series in my 'thread summary' view.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-06-20 0:00 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-09 11:30 [PATCH 0/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-09 11:30 ` [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
2020-06-10 2:23 ` Florian Fainelli
2020-06-09 11:30 ` [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-10 2:27 ` Florian Fainelli
2020-06-10 6:12 ` Álvaro Fernández Rojas
2020-06-10 8:29 ` Philippe Mathieu-Daudé
2020-06-10 15:14 ` Florian Fainelli
2020-06-13 17:53 ` Philippe Mathieu-Daudé
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
2020-06-10 14:08 ` [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
2020-06-17 22:23 ` Rob Herring
2020-06-10 14:08 ` [PATCH v2 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-20 0:00 ` [PATCH v2 0/2] " Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).