* [PATCH v4] staging: rtl8712: remove unnecessary parentheses
@ 2022-04-07 12:59 Alaa Mohamed
2022-04-07 17:46 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Alaa Mohamed @ 2022-04-07 12:59 UTC (permalink / raw)
To: outreachy
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-staging,
linux-kernel, eng.alaamohamedsoliman.am
Reported by checkpatch:
Remove unnecessary parentheses around structure field references
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
Changes in v2:
- Edit commit subject
- Edit commit message
- Fix the same check in more lines
- Remove space before '.skey' in
"memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
---
Changes in v3:
return the space before '.skey' in
"memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
---
Changes in v4:
edit commit message to be clearer.
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 3b6926613257..f1e352b7f83e 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta,
(param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len));
if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */
memcpy(psta->tkiptxmickey. skey,
- &(param->u.crypt.key[16]), 8);
+ ¶m->u.crypt.key[16], 8);
memcpy(psta->tkiprxmickey. skey,
- &(param->u.crypt.key[24]), 8);
+ ¶m->u.crypt.key[24], 8);
padapter->securitypriv. busetkipkey = false;
mod_timer(&padapter->securitypriv.tkip_timer,
jiffies + msecs_to_jiffies(50));
@@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u32 ht_ielen = 0;
char *p;
u8 ht_cap = false;
- struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+ struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
u8 *prates;
@@ -1494,7 +1494,7 @@ static int r8711_wx_set_enc(struct net_device *dev,
u32 keyindex_provided;
struct NDIS_802_11_WEP wep;
enum NDIS_802_11_AUTHENTICATION_MODE authmode;
- struct iw_point *erq = &(wrqu->encoding);
+ struct iw_point *erq = &wrqu->encoding;
struct _adapter *padapter = netdev_priv(dev);
key = erq->flags & IW_ENCODE_INDEX;
@@ -1589,8 +1589,8 @@ static int r8711_wx_get_enc(struct net_device *dev,
{
uint key;
struct _adapter *padapter = netdev_priv(dev);
- struct iw_point *erq = &(wrqu->encoding);
- struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+ struct iw_point *erq = &wrqu->encoding;
+ struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
union Keytype *dk = padapter->securitypriv.DefKey;
if (!check_fwstate(pmlmepriv, _FW_LINKED)) {
@@ -1670,7 +1670,7 @@ static int r871x_wx_set_auth(struct net_device *dev,
union iwreq_data *wrqu, char *extra)
{
struct _adapter *padapter = netdev_priv(dev);
- struct iw_param *param = (struct iw_param *)&(wrqu->param);
+ struct iw_param *param = (struct iw_param *)&wrqu->param;
int paramid;
int paramval;
int ret = 0;
@@ -1964,7 +1964,7 @@ static int r871x_get_ap_info(struct net_device *dev,
return -EINVAL;
data[32] = 0;
- spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL);
+ spin_lock_irqsave(&pmlmepriv->scanned_queue.lock, irqL);
phead = &queue->queue;
plist = phead->next;
while (1) {
@@ -1974,7 +1974,7 @@ static int r871x_get_ap_info(struct net_device *dev,
if (!mac_pton(data, bssid)) {
netdev_info(dev, "r8712u: Invalid BSSID '%s'.\n",
(u8 *)data);
- spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock),
+ spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock,
irqL);
return -EINVAL;
}
@@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev,
}
plist = plist->next;
}
- spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL);
+ spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL);
if (pdata->length >= 34) {
if (copy_to_user((u8 __user *)pdata->pointer + 32,
(u8 *)&pdata->flags, 1))
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4] staging: rtl8712: remove unnecessary parentheses
2022-04-07 12:59 [PATCH v4] staging: rtl8712: remove unnecessary parentheses Alaa Mohamed
@ 2022-04-07 17:46 ` Greg KH
2022-04-07 18:02 ` Alaa Mohamed
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2022-04-07 17:46 UTC (permalink / raw)
To: Alaa Mohamed
Cc: outreachy, Larry.Finger, florian.c.schilhabel, linux-staging,
linux-kernel
On Thu, Apr 07, 2022 at 02:59:47PM +0200, Alaa Mohamed wrote:
> Reported by checkpatch:
>
> Remove unnecessary parentheses around structure field references
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> Changes in v2:
> - Edit commit subject
> - Edit commit message
> - Fix the same check in more lines
> - Remove space before '.skey' in
> "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
> ---
> Changes in v3:
> return the space before '.skey' in
> "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
> ---
> Changes in v4:
> edit commit message to be clearer.
> ---
Why did you send this patch twice?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] staging: rtl8712: remove unnecessary parentheses
2022-04-07 17:46 ` Greg KH
@ 2022-04-07 18:02 ` Alaa Mohamed
2022-04-07 18:28 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Alaa Mohamed @ 2022-04-07 18:02 UTC (permalink / raw)
To: Greg KH
Cc: outreachy, Larry.Finger, florian.c.schilhabel, linux-staging,
linux-kernel
On ٧/٤/٢٠٢٢ ١٩:٤٦, Greg KH wrote:
> On Thu, Apr 07, 2022 at 02:59:47PM +0200, Alaa Mohamed wrote:
>> Reported by checkpatch:
>>
>> Remove unnecessary parentheses around structure field references
>>
>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
>> ---
>> Changes in v2:
>> - Edit commit subject
>> - Edit commit message
>> - Fix the same check in more lines
>> - Remove space before '.skey' in
>> "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
>> ---
>> Changes in v3:
>> return the space before '.skey' in
>> "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
>> ---
>> Changes in v4:
>> edit commit message to be clearer.
>> ---
> Why did you send this patch twice?
That was by mistake , sorry
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] staging: rtl8712: remove unnecessary parentheses
2022-04-07 18:02 ` Alaa Mohamed
@ 2022-04-07 18:28 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2022-04-07 18:28 UTC (permalink / raw)
To: Alaa Mohamed
Cc: outreachy, Larry.Finger, florian.c.schilhabel, linux-staging,
linux-kernel
On Thu, Apr 07, 2022 at 08:02:37PM +0200, Alaa Mohamed wrote:
>
> On ٧/٤/٢٠٢٢ ١٩:٤٦, Greg KH wrote:
> > On Thu, Apr 07, 2022 at 02:59:47PM +0200, Alaa Mohamed wrote:
> > > Reported by checkpatch:
> > >
> > > Remove unnecessary parentheses around structure field references
> > >
> > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> > > ---
> > > Changes in v2:
> > > - Edit commit subject
> > > - Edit commit message
> > > - Fix the same check in more lines
> > > - Remove space before '.skey' in
> > > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
> > > ---
> > > Changes in v3:
> > > return the space before '.skey' in
> > > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
> > > ---
> > > Changes in v4:
> > > edit commit message to be clearer.
> > > ---
> > Why did you send this patch twice?
> That was by mistake , sorry
When you do so, please let us know which to take, as it is hard to know
if there was a difference or not.
Realize that for some of us, we get hundreds of patches to review daily.
Being obvious as to what to, and not to, ignore, is helpful.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4] staging: rtl8712: remove unnecessary parentheses
@ 2022-04-07 12:48 Alaa Mohamed
0 siblings, 0 replies; 5+ messages in thread
From: Alaa Mohamed @ 2022-04-07 12:48 UTC (permalink / raw)
To: outreachy
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-staging,
linux-kernel, eng.alaamohamedsoliman.am
Reported by checkpatch:
Remove unnecessary parentheses around structure field references
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
Changes in v2:
- Edit commit subject
- Edit commit message
- Fix the same check in more lines
- Remove space before '.skey' in
"memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
---
Changes in v3:
return the space before '.skey' in
"memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
---
Changes in v4:
edit commit message to be clearer.
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 3b6926613257..f1e352b7f83e 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta,
(param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len));
if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */
memcpy(psta->tkiptxmickey. skey,
- &(param->u.crypt.key[16]), 8);
+ ¶m->u.crypt.key[16], 8);
memcpy(psta->tkiprxmickey. skey,
- &(param->u.crypt.key[24]), 8);
+ ¶m->u.crypt.key[24], 8);
padapter->securitypriv. busetkipkey = false;
mod_timer(&padapter->securitypriv.tkip_timer,
jiffies + msecs_to_jiffies(50));
@@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u32 ht_ielen = 0;
char *p;
u8 ht_cap = false;
- struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+ struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
u8 *prates;
@@ -1494,7 +1494,7 @@ static int r8711_wx_set_enc(struct net_device *dev,
u32 keyindex_provided;
struct NDIS_802_11_WEP wep;
enum NDIS_802_11_AUTHENTICATION_MODE authmode;
- struct iw_point *erq = &(wrqu->encoding);
+ struct iw_point *erq = &wrqu->encoding;
struct _adapter *padapter = netdev_priv(dev);
key = erq->flags & IW_ENCODE_INDEX;
@@ -1589,8 +1589,8 @@ static int r8711_wx_get_enc(struct net_device *dev,
{
uint key;
struct _adapter *padapter = netdev_priv(dev);
- struct iw_point *erq = &(wrqu->encoding);
- struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+ struct iw_point *erq = &wrqu->encoding;
+ struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
union Keytype *dk = padapter->securitypriv.DefKey;
if (!check_fwstate(pmlmepriv, _FW_LINKED)) {
@@ -1670,7 +1670,7 @@ static int r871x_wx_set_auth(struct net_device *dev,
union iwreq_data *wrqu, char *extra)
{
struct _adapter *padapter = netdev_priv(dev);
- struct iw_param *param = (struct iw_param *)&(wrqu->param);
+ struct iw_param *param = (struct iw_param *)&wrqu->param;
int paramid;
int paramval;
int ret = 0;
@@ -1964,7 +1964,7 @@ static int r871x_get_ap_info(struct net_device *dev,
return -EINVAL;
data[32] = 0;
- spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL);
+ spin_lock_irqsave(&pmlmepriv->scanned_queue.lock, irqL);
phead = &queue->queue;
plist = phead->next;
while (1) {
@@ -1974,7 +1974,7 @@ static int r871x_get_ap_info(struct net_device *dev,
if (!mac_pton(data, bssid)) {
netdev_info(dev, "r8712u: Invalid BSSID '%s'.\n",
(u8 *)data);
- spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock),
+ spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock,
irqL);
return -EINVAL;
}
@@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev,
}
plist = plist->next;
}
- spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL);
+ spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL);
if (pdata->length >= 34) {
if (copy_to_user((u8 __user *)pdata->pointer + 32,
(u8 *)&pdata->flags, 1))
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-07 18:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 12:59 [PATCH v4] staging: rtl8712: remove unnecessary parentheses Alaa Mohamed
2022-04-07 17:46 ` Greg KH
2022-04-07 18:02 ` Alaa Mohamed
2022-04-07 18:28 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-04-07 12:48 Alaa Mohamed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).