linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Luis Oliveira <Luis.Oliveira@synopsys.com>, <wsa@the-dreams.de>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<jarkko.nikula@linux.intel.com>,
	<mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <Ramiro.Oliveira@synopsys.com>, <Joao.Pinto@synopsys.com>,
	<CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module
Date: Thu, 5 Jan 2017 12:13:56 +0000	[thread overview]
Message-ID: <9747bb4d-9a52-789d-32e9-ddbef9e129e4@synopsys.com> (raw)
In-Reply-To: <b27405b9-b768-34e7-d61a-433100f9856d@synopsys.com>

On 28-Dec-16 18:10, Luis Oliveira wrote:
> On 28-Dec-16 17:10, Andy Shevchenko wrote:
>> On Wed, 2016-12-28 at 16:41 +0000, Luis Oliveira wrote:
>>> On 28-Dec-16 16:31, Andy Shevchenko wrote:
>>>> On Wed, 2016-12-28 at 15:53 +0000, Luis Oliveira wrote:
>>>>> On 28-Dec-16 15:44, Andy Shevchenko wrote:
>>>>>> On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote:
>>>>>>> - Slave mode selected in platform module (devicetree support
>>>>>>> only)
>>>>>>> - Check for ACPI - not supported in SLAVE mode:
>>>>>>>   - Changed the ifndef style to the use of ACPI_HANDLE that
>>>>>>> returns
>>>>>>> NULL
>>>>>>>     if the device was not enumerated from ACPI namespace.
>>>>>>
>>>>>> I'm not sure what is wrong with ACPI?
>>>>>
>>>>> I dont have a way to test it. Just that.
>>>>
>>>> Okay, can you provide an excerpt to see how it will look like in
>>>> DTS?
>>>
>>> Yes, it looks like this now:
>>>
>>> 	i2c@0x2000 {
>>> 			compatible = "snps,designware-i2c";
>>> 			#address-cells = <1>;
>>> 			#size-cells = <0>;
>>> 			reg = <0x2000 0x100>;
>>> 			clock-frequency = <400000>;
>>> 			clocks = <&i2cclk>;
>>> 			interrupts = <0>;
>>>
>>> 			eeprom@64 {
>>> 				compatible = "linux,slave-24c02";
>>> 				reg = <0x40000064>;
>>> 			};
>>> 	};
>>
>> +1 to Carlos' comment.
> 
> Agree, I'm on it.
> 
>>
>>>>  
>>>>>>> -	dev->functionality = I2C_FUNC_10BIT_ADDR |
>>>>>>> DW_IC_DEFAULT_FUNCTIONALITY;
>>>>>>> -
>>>>>>> -	i2c_dw_configure_master(pdev);
>>>>>>> +	if (ACPI_HANDLE(&pdev->dev) == NULL) {
>>>>>>
>>>>>> I don't think you need this at all.
>>>>>
>>>>> This is to avoid the use of the "ifdef" style I used before.
>>>>
>>>> My point is to drop it completely.
>>>>
>>>>>>
>>>>>>> +		device_for_each_child_node(&pdev->dev, child)
>>>>>>> {
>>>>>>
>>>>>> This is resource agnostic.
>>>>>>
>>>>>>> +			fwnode_property_read_u32(child,
>>>>>>> "reg",
>>>>>>> &reg);
>>>>>>
>>>>>> This is as well.
>>>>>
>>>>> Are you suggesting I use of_ functions?
>>>>
>>>> Nope. See above.
>>
>> So, ACPI has a property to support slave mode for I2CSerialBus() macro.
>>
>> I would propose to create a helper function in i2c-core.c which will be
>> responsible for mode detection
>>
>> ... i2c_slave_mode_detect()
>> {
>> ...
>>  if (IS_BUILTIN(CONFIG_OF) && dev->of_node) {
>>   ... (use of_*() here) ...
>>  } else if (IS_BUILTIN(CONFIG_ACPI) && ACPI_HANDLE(dev))
>>   dev_dbg(..., "ACPI slave is not supported yet\n");
>>   ... to master ...
>>  } else {
>>   ... default to master ...
>>  }
>> }
>> EXPORT_...();
>>
>> Make it as a separate patch.
>>
> 
> Oh I see, yes it looks good. I will check it. Thanks
> 

Hi Andy,

I implemented a helper function as you proposed and it looks like this:

int i2c_slave_mode_detect(struct device *dev)
{
	struct device_node *child;
	u32 reg;
	
	if (IS_BUILTIN(CONFIG_OF) && dev->of_node) {
		for_each_child_of_node(dev->of_node, child) {
			of_property_read_u32(child, "reg", &reg);
			if (reg & I2C_OWN_SLAVE_ADDRESS)
				return 1;
		}
	} else if (IS_BUILTIN(CONFIG_ACPI) && ACPI_HANDLE(dev))
		dev_dbg(dev, "ACPI slave is not supported yet\n");
	else
		return 0;
	return 0;
}

Before I submit the patch to the i2c-core.c I wonder if I could have some
comment on the implementation.

Thanks,
Luis

  reply	other threads:[~2017-01-05 12:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28 14:43 [PATCH v5 0/7] i2c: designware: add I2C SLAVE support Luis Oliveira
2016-12-28 14:43 ` [PATCH v5 1/7] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2016-12-28 14:43 ` [PATCH v5 2/7] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2016-12-28 15:12   ` Andy Shevchenko
2016-12-28 15:30     ` Luis Oliveira
2016-12-28 14:43 ` [PATCH v5 3/7] i2c: designware: MASTER mode as separated driver Luis Oliveira
2016-12-28 14:43 ` [PATCH v5 4/7] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2016-12-28 15:17   ` Andy Shevchenko
2016-12-28 14:43 ` [PATCH v5 5/7] i2c: designware: add SLAVE mode functions Luis Oliveira
2016-12-28 15:36   ` Andy Shevchenko
2016-12-28 16:00     ` Luis Oliveira
2016-12-31 23:45   ` kbuild test robot
2016-12-28 14:43 ` [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Luis Oliveira
2016-12-28 15:44   ` Andy Shevchenko
2016-12-28 15:53     ` Luis Oliveira
2016-12-28 16:31       ` Andy Shevchenko
2016-12-28 16:41         ` Luis Oliveira
2016-12-28 16:49           ` Carlos Palminha
2016-12-28 17:10           ` Andy Shevchenko
2016-12-28 18:10             ` Luis Oliveira
2017-01-05 12:13               ` Luis Oliveira [this message]
2017-01-05 12:43                 ` Andy Shevchenko
2016-12-28 14:43 ` [PATCH v5 7/7] i2c: designware: style changes in existing code Luis Oliveira
2016-12-28 15:50   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9747bb4d-9a52-789d-32e9-ddbef9e129e4@synopsys.com \
    --to=luis.oliveira@synopsys.com \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=Ramiro.Oliveira@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).